From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA68C433EF for ; Sun, 3 Jul 2022 08:37:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F31546B0074; Sun, 3 Jul 2022 04:37:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE0936B0075; Sun, 3 Jul 2022 04:37:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCF3E6B0078; Sun, 3 Jul 2022 04:37:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CEB0F6B0074 for ; Sun, 3 Jul 2022 04:37:35 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9E9ED60F0C for ; Sun, 3 Jul 2022 08:37:35 +0000 (UTC) X-FDA: 79645134870.24.904749F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP id DB448140044 for ; Sun, 3 Jul 2022 08:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2vHa2oW1s9FxDcP/QY8NLotlVe+ag/ALlheTMGjt8eU=; b=c2zq3UuOmgEOcNgHxzDFudylWG UPZnp+WyFmPm2le0NasLLv/Ps0U6i5qykiiSPvtESA/J6ZwoiNl7spkdBdkRQjRJcjd7l5GpIo7xz 2iV64+BGpD2FS87Gh/NNz6u/qO4f1NBtXsWCNABUA8w/Jkt6CG7U1S2Tu6oIFhSNUosyPqj315CkK HFluSdq/9Z7Ru+8y/QskJpb9aAwNT/oAsiFUwJ1242G3dG2aOCE9I9FpVvuYq0AiiAamDejvco9d8 7tCRoZ1Zzpf1XUvuTGXkTCsFMgj52F+He6GY1yYLCfcZp0ZVldOeS5MyquXS4K6fW0aoilwhAH3Jr +NwM78Jg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7v6f-00GL2Z-8f; Sun, 03 Jul 2022 08:37:29 +0000 Date: Sun, 3 Jul 2022 09:37:29 +0100 From: Matthew Wilcox To: Jens Axboe Cc: linux-mm@kvack.org, Shakeel Butt , Stefan Roesch Subject: Re: [PATCH v2] mm: honor FGP_NOWAIT for page cache page allocation Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656837455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2vHa2oW1s9FxDcP/QY8NLotlVe+ag/ALlheTMGjt8eU=; b=0Q2XmnJmz5PePGaR0OdpeeV3aLhsqgv7PYUZHNVz3zxs2fNMNKGTwodO5XXPWl6RxsN7+S UQ77Yc8e8qHAfzH/S8Sh4ZnjpTMYx7MDHFBvyRItDX8ckKUqXCFZwL+snVasAAOJb+VHQu RdnJWyCYBI4ppu5n3X0fgLZaoSPtd5w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656837455; a=rsa-sha256; cv=none; b=aOk4VwztZD8fib3UPPH+q8mLQfY5aCk+ubjSr/YiX5ltgc7N3PrJgBTejkOsSantVr5YNS U9aXW8Edef+IzhhAobKhFvJBzDMJpswwv8Kq/g6ZTQVSU2yJMzfC2hdwf/wgQ6QOvvFVUo mG0RUO3oIbVeyYjx3vJJ88uTyqxeqac= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=c2zq3UuO; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=c2zq3UuO; dmarc=none; spf=none (imf23.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: jfdzh5xshycdbp54qz4aunwgnshm9m6q X-Rspamd-Queue-Id: DB448140044 X-HE-Tag: 1656837454-708777 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 02, 2022 at 09:43:32AM -0600, Jens Axboe wrote: > +++ b/mm/filemap.c > @@ -1988,6 +1988,10 @@ struct folio *__filemap_get_folio(struct address_space *mapping, pgoff_t index, > gfp |= __GFP_WRITE; > if (fgp_flags & FGP_NOFS) > gfp &= ~__GFP_FS; > + if (fgp_flags & FGP_NOWAIT) { > + gfp &= ~GFP_KERNEL; > + gfp |= GFP_NOWAIT | __GFP_NOWARN; > + } Wouldn't it be simpler to write: if (fgp_flags & FGP_NOWAIT) { gfp &= ~__GFP_DIRECT_RECLAIM; gfp |= __GFP_NOWARN; } (I'd prefer it if the caller passed in the GFP flags that it actually wants, but looking at the patches that prompted this, that seems rather annoying to do)