From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A05C433EF for ; Sun, 3 Jul 2022 03:41:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8ECC6B0072; Sat, 2 Jul 2022 23:41:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3DED6B0073; Sat, 2 Jul 2022 23:41:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2E1B6B0074; Sat, 2 Jul 2022 23:41:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9162E6B0072 for ; Sat, 2 Jul 2022 23:41:02 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 6984A120FC6 for ; Sun, 3 Jul 2022 03:41:02 +0000 (UTC) X-FDA: 79644387564.31.6CEA911 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 248614004B for ; Sun, 3 Jul 2022 03:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yUcXbxB06hdRD0R+rVE1I7cbEXp854NTpON98IkjV5M=; b=hae7218pokCBDtYmMXlJ2Nu9su E8Erlh/UHAOael315DED6pcBJwmbU22YI3PtudAZ8Rs04oQWOWcfAzzuiDnmaL7rLsMSG9gHp49qh y8wcbL1q/dVGANQlr0shMXgguZ5D7oG1YBIhlLUzquksCsaK5inYItqdR2ckqGuTPUC0eDgJwWJ3o 2OXnTAwBM7vuSb40hOTRGQ1moOCFtMGws5QLIV+WHbhPKO7CPfPBpjprUJyyc3VOLi7ixvgtIkETA YEYbLzZ6qIZ6ofgd7Wuk8220p4cw3mlzjMSKMRSjJQcmBvKdLFvFfM4Kn5EZB4Ab0n5meRLFNcd4x 3B8n0zCA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7qTa-00GDPg-Ot; Sun, 03 Jul 2022 03:40:50 +0000 Date: Sun, 3 Jul 2022 04:40:50 +0100 From: Matthew Wilcox To: Baolin Wang Cc: Mike Rapoport , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v3 2/3] mm: Add PUD level pagetable account Message-ID: References: <6a6a768634b9ce8537154264e35e6a66a79b6ca8.1656586863.git.baolin.wang@linux.alibaba.com> <1234a28a-dca0-5836-9066-4ab2d4fbcc95@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1234a28a-dca0-5836-9066-4ab2d4fbcc95@linux.alibaba.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656819662; a=rsa-sha256; cv=none; b=KLLQIOY1Csm0DA8WfqrxtEy5P0X1fVFxbgg+ihyZXoSvHKgAd+RiCIHxlOJE2gf0kntShR Vq6aWjuzMZRvepSBo85PfO1qrmJ+tddQhLljux3aEqhlWMWcdQ0iDkwRjvxjAj1ENcETgC vStR0xBbovj+ORIuUEmBHROJWkIxEss= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hae7218p; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656819662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yUcXbxB06hdRD0R+rVE1I7cbEXp854NTpON98IkjV5M=; b=HeyGh7Wp7aLy0i7lPZmroA4QLzxNWQbrE3oyIoK4MtYAzCkH6GWQkRccOmYPlBW9iF6MAQ CP8vek4ta/Y2XGYhtVsZPnVthgIJ4Q9VpCwyeBw+fyCifkbeOa6LIzRBIWTdeESNi5H53T 6yAG6NkDKit5hpGtRktC3htrJQ8MR0A= Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hae7218p; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 248614004B X-Stat-Signature: ybpm5d97d97aih67nwfyx4nzesmh9r41 X-Rspam-User: X-HE-Tag: 1656819660-29865 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 01, 2022 at 04:04:21PM +0800, Baolin Wang wrote: > > Using pgtable_pud_page_ctor() and pgtable_pud_page_dtor() would be > > consistent with what we currently have for PTEs and PMDs. > > > > This applies to all the additions of pgtable_page_dec() and > > pgtable_page_inc(). > > OK. I can add pgtable_pud_page_ctor() and pgtable_pud_page_dtor() helpers to > keep consistent, which are just wrappers of pgtable_page_inc() and > pgtable_page_dec(). I think you misunderstand Mike. Don't add pgtable_page_inc() and pgtable_page_dec(). Just add pgtable_pud_page_ctor() and pgtable_pud_page_dtor(). At least, that was what I said last time yo uposted these patches.