From: Matthew Wilcox <willy@infradead.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Mike Rapoport <rppt@linux.ibm.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 2/3] mm: Add PUD level pagetable account
Date: Sun, 3 Jul 2022 04:40:50 +0100 [thread overview]
Message-ID: <YsEPwvgUd0sIjso/@casper.infradead.org> (raw)
In-Reply-To: <1234a28a-dca0-5836-9066-4ab2d4fbcc95@linux.alibaba.com>
On Fri, Jul 01, 2022 at 04:04:21PM +0800, Baolin Wang wrote:
> > Using pgtable_pud_page_ctor() and pgtable_pud_page_dtor() would be
> > consistent with what we currently have for PTEs and PMDs.
> >
> > This applies to all the additions of pgtable_page_dec() and
> > pgtable_page_inc().
>
> OK. I can add pgtable_pud_page_ctor() and pgtable_pud_page_dtor() helpers to
> keep consistent, which are just wrappers of pgtable_page_inc() and
> pgtable_page_dec().
I think you misunderstand Mike.
Don't add pgtable_page_inc() and pgtable_page_dec(). Just add
pgtable_pud_page_ctor() and pgtable_pud_page_dtor(). At least, that
was what I said last time yo uposted these patches.
next prev parent reply other threads:[~2022-07-03 3:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 11:11 [RFC PATCH v3 0/3] Add PUD and kernel PTE " Baolin Wang
2022-06-30 11:11 ` [RFC PATCH v3 1/3] mm: Factor out the pagetable pages account into new helper function Baolin Wang
2022-06-30 14:11 ` Mike Rapoport
2022-07-01 8:00 ` Baolin Wang
2022-07-02 10:15 ` Mike Rapoport
2022-07-03 13:48 ` Baolin Wang
2022-06-30 11:11 ` [RFC PATCH v3 2/3] mm: Add PUD level pagetable account Baolin Wang
2022-06-30 14:17 ` Mike Rapoport
2022-07-01 8:04 ` Baolin Wang
2022-07-03 3:40 ` Matthew Wilcox [this message]
2022-07-03 14:06 ` Baolin Wang
2022-07-03 14:28 ` Mike Rapoport
2022-07-03 14:49 ` Baolin Wang
2022-07-03 14:52 ` Matthew Wilcox
2022-07-03 15:07 ` Baolin Wang
2022-07-03 3:47 ` Matthew Wilcox
2022-07-03 14:18 ` Mike Rapoport
2022-06-30 11:11 ` [RFC PATCH v3 3/3] mm: Add kernel PTE level pagetable pages account Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsEPwvgUd0sIjso/@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox