From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5979C43334 for ; Sat, 2 Jul 2022 21:59:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B81ED6B0072; Sat, 2 Jul 2022 17:59:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0A856B0073; Sat, 2 Jul 2022 17:59:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9849F6B0074; Sat, 2 Jul 2022 17:59:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 84AD26B0072 for ; Sat, 2 Jul 2022 17:59:39 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3BE1C33B8B for ; Sat, 2 Jul 2022 21:59:39 +0000 (UTC) X-FDA: 79643527278.22.CABCBA7 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf19.hostedemail.com (Postfix) with ESMTP id D7B721A004D for ; Sat, 2 Jul 2022 21:59:38 +0000 (UTC) Received: by mail-qt1-f176.google.com with SMTP id ck6so4711248qtb.7 for ; Sat, 02 Jul 2022 14:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CRmpJqPfR2Ffc8HgrJVdi9vtvYXJmh3FYn3557q1NwE=; b=IM5wTLBzQjNlhxRrQd9duTSaviX9W642sXlAB85N1J/s7j5rmEna+8IABQod6CKWwf idRQLlJu1V3fyKxBBgZT8orNNwSfG3ldK93UWDDfwO+2whPF1ZAxLA40DoQvxU5BfMNp 3lBbbYWyQlIivNwXQikzuuHqR4sZAigx4GkkKHfZlqHeuEoeLfDb/PifXKGZipSv/aeN Cynt/+Yyu7uFh0AOVPy3Vsn+npnyt9GaCOHUIl2GPSlPaA5FV2+u3jZ48DmkHJn3sw2W Qhb1WicuxCijgoIjMRw1yzx8xh+1vtZ7swikn0STs41+ERPMsE0gL2i/YGW133S/wqfx tCEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CRmpJqPfR2Ffc8HgrJVdi9vtvYXJmh3FYn3557q1NwE=; b=NoH6QVdGFTkz31hZRMQ0ffpGCLA7hHZr6rP4Qg+U2673POYdjwEVwMPGR2UaxjrqGy 0cQtUQcx8tHVt7eBB/QSvaTgxOy3W/thXFQXgL7kuv3hWAy2ZEn2kmlIKvbo7NLRttGH IxF7xliJ6ooHGAIAdEcy1T8yTT/qPkR35RCQNWAMeSjLy77p2sbs5hVMyURxSJj8rNbi y1ZCycCLArS6ww8M4VjIUY6L8QsgWp6kO3+JrVL+3E8rxz61WIZ89+MHuiYhbIunfPa6 KDnyd+3DQPqhPNkTDtxzW+VyUsnG/lbUQ5x+cFwR80c3jP4ZZ3WePxKLOb3G52u29j/U /xgg== X-Gm-Message-State: AJIora/jBeeOkxjCRQpWDK7SrtqdBTXnNXFU4l20tNrJtdbKQZGchvJR xlrIF1zjOJCrHGug+Nfgplo= X-Google-Smtp-Source: AGRyM1vsKaZ4Q845hwAJdZ+Iup3JowgDZtmbhIizUAD0kSH6BZk1L5rQHvQIxX0hZopZgMtlLU/zgg== X-Received: by 2002:a05:6214:c6e:b0:472:edeb:f694 with SMTP id t14-20020a0562140c6e00b00472edebf694mr2331526qvj.90.1656799178059; Sat, 02 Jul 2022 14:59:38 -0700 (PDT) Received: from localhost ([2601:4c1:c100:1230:e838:b1c2:b125:986a]) by smtp.gmail.com with ESMTPSA id q15-20020ac8450f000000b003177f0fb61esm16496345qtn.75.2022.07.02.14.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Jul 2022 14:59:37 -0700 (PDT) Date: Sat, 2 Jul 2022 14:59:37 -0700 From: Yury Norov To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Howells , Geert Uytterhoeven , Jonathan Corbet , "Kirill A . Shutemov" , Matthew Wilcox , NeilBrown , Rasmus Villemoes , Russell King , Vlastimil Babka , William Kucharski , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 5/8] lib/cpumask: change return types to unsigned where appropriate Message-ID: References: <20220701125430.2907638-1-yury.norov@gmail.com> <20220701125430.2907638-6-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IM5wTLBz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of yury.norov@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=yury.norov@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656799178; a=rsa-sha256; cv=none; b=rI7zU6VDS5u5IAT5edM0/70za1M7gux9QcsedMJLUfbk5tgvTuxGKYMV6Lpai5dMq70X72 us2R+Q+dKVNc7kJ0ScywCJpLVM1GzCIxjYSuhaiyyn98UzbZnoiFafJNf1KAY7+jevXZa6 sme+z6I1DH6gHGafsFfeK+csiyGT7o8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656799178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CRmpJqPfR2Ffc8HgrJVdi9vtvYXJmh3FYn3557q1NwE=; b=MEr3/V2hodoqsWxahv0vyFMFPAuCzTYWnLxTr+qJErw/fiolB2jCAsd2rzGjap5lM4bZLH bzusGDaMtDyBnzyNjV1bBZ5soOu1MpqIFE4xLaBLummitP7J80jiYJed/TRLDPhghYTXvd BXYeo0ScCK6x9g6YJLL6B3EHc245rXM= X-Stat-Signature: mrpgt1eu1nj65b1pgmt3ufttibgzhzfr X-Rspamd-Queue-Id: D7B721A004D Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IM5wTLBz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of yury.norov@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=yury.norov@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1656799178-648124 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 02, 2022 at 03:00:19PM +0300, Andy Shevchenko wrote: > On Fri, Jul 01, 2022 at 05:54:27AM -0700, Yury Norov wrote: > > Switch return types to unsigned int where return values cannot be negative. > > ... > > > -int cpumask_any_and_distribute(const struct cpumask *src1p, > > +unsigned int cpumask_any_and_distribute(const struct cpumask *src1p, > > const struct cpumask *src2p); > > It breaks indentation of the second line. I'd prefer to keep 2nd line untouched to not trash history for nothing. > > ... > > > -int cpumask_next_and(int n, const struct cpumask *src1p, > > +unsigned int cpumask_next_and(int n, const struct cpumask *src1p, > > const struct cpumask *src2p) > > Ditto. > > And seems a lot of cases in the series like this. > > -- > With Best Regards, > Andy Shevchenko >