From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9D47C433EF for ; Sat, 2 Jul 2022 12:00:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 524466B0071; Sat, 2 Jul 2022 08:00:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5946B0073; Sat, 2 Jul 2022 08:00:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EB1C6B0074; Sat, 2 Jul 2022 08:00:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2FFE66B0071 for ; Sat, 2 Jul 2022 08:00:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 0D81260E8D for ; Sat, 2 Jul 2022 12:00:45 +0000 (UTC) X-FDA: 79642018050.05.634DEAD Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf18.hostedemail.com (Postfix) with ESMTP id 3E64E1C009B for ; Sat, 2 Jul 2022 12:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656763244; x=1688299244; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TmBINPi4YWQq6jPhvMGuqgLplCQN4DhZzS9sXB4R8Ug=; b=mZOFmINXngT/+z7MfSIXXIUaO3nZT3wKVBPbjenzIOfCF8jdcIvQ6MSC h5RMPz9W5YFB1OLflESrZpqdGLUzYGmrfVA2xEnNVl/sAoH+QA2R401Tn DkhBrse/yhkRAK50XL+Im4wEFXgXgee9reycFHry5V3xEXXl2F0lVeJ7Y gy5OpfdF6aDKMa+Hta8ZfckFvbOWH8M5Fl+yYQ6njWBWjZE0MizXUvxQ8 n5MZbAHeDUd13OisImSb+YQ7HyA/OgKEb5v8wxXwvH4Fz2zF+vsepPdfg 1E0/tkYvAcgXsB4JtAfXbn1W0/RWFOikEvV8b7qVhJ9v+xwSLY+fSPuPp g==; X-IronPort-AV: E=McAfee;i="6400,9594,10395"; a="346808389" X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="346808389" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 05:00:42 -0700 X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="838343902" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 05:00:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1o7bnQ-0013au-0e; Sat, 02 Jul 2022 15:00:20 +0300 Date: Sat, 2 Jul 2022 15:00:19 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Howells , Geert Uytterhoeven , Jonathan Corbet , "Kirill A . Shutemov" , Matthew Wilcox , NeilBrown , Rasmus Villemoes , Russell King , Vlastimil Babka , William Kucharski , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 5/8] lib/cpumask: change return types to unsigned where appropriate Message-ID: References: <20220701125430.2907638-1-yury.norov@gmail.com> <20220701125430.2907638-6-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701125430.2907638-6-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mZOFmINX; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf18.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656763244; a=rsa-sha256; cv=none; b=GXEanjCxWGtwDHZI/426LvCkdEpE7XpA7kRcRLsgw7R8yjx9rkBVOov5tt1GTsSzRmGlGP HykX6hY8Elz1XunH3UC28exJzwSFDXYhDkl/wu1x/DtvCtL6xCYGH3d524bt5znX9Hcw0V Of5eRgSnT9eO30jaC+mvQYKVyz8iH3E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656763244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BbViA9khyhj8S4KtmDZEfyPSNIx1en57Kx0WQknG/yA=; b=YBBMDJflBIKe3f6rA9CVNFzU56YgEpD6uqLJoVuesE+NFT+UTbOy4+rVyw/RTO0PaQLITi bwuVDqFrxeP1aJII/hzpIKVHDvq9QAr+i2L/yUGldsc9CE8JVF4CqiJVkCnBcbBqD5XZp1 qs08NacscVJbdzF6G9umvfr+U71sPjU= X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mZOFmINX; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf18.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3E64E1C009B X-Stat-Signature: 687tzz7iu6fbdjmbuyqe4yqexr1et5t6 X-HE-Tag: 1656763243-900382 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 01, 2022 at 05:54:27AM -0700, Yury Norov wrote: > Switch return types to unsigned int where return values cannot be negative. ... > -int cpumask_any_and_distribute(const struct cpumask *src1p, > +unsigned int cpumask_any_and_distribute(const struct cpumask *src1p, > const struct cpumask *src2p); It breaks indentation of the second line. ... > -int cpumask_next_and(int n, const struct cpumask *src1p, > +unsigned int cpumask_next_and(int n, const struct cpumask *src1p, > const struct cpumask *src2p) Ditto. And seems a lot of cases in the series like this. -- With Best Regards, Andy Shevchenko