From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Howells <dhowells@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jonathan Corbet <corbet@lwn.net>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Matthew Wilcox <willy@infradead.org>, NeilBrown <neilb@suse.de>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Russell King <linux@armlinux.org.uk>,
Vlastimil Babka <vbabka@suse.cz>,
William Kucharski <william.kucharski@oracle.com>,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mm@kvack.org
Subject: Re: [PATCH 5/8] lib/cpumask: change return types to unsigned where appropriate
Date: Sat, 2 Jul 2022 15:00:19 +0300 [thread overview]
Message-ID: <YsAzU3g2QpgmIGre@smile.fi.intel.com> (raw)
In-Reply-To: <20220701125430.2907638-6-yury.norov@gmail.com>
On Fri, Jul 01, 2022 at 05:54:27AM -0700, Yury Norov wrote:
> Switch return types to unsigned int where return values cannot be negative.
...
> -int cpumask_any_and_distribute(const struct cpumask *src1p,
> +unsigned int cpumask_any_and_distribute(const struct cpumask *src1p,
> const struct cpumask *src2p);
It breaks indentation of the second line.
...
> -int cpumask_next_and(int n, const struct cpumask *src1p,
> +unsigned int cpumask_next_and(int n, const struct cpumask *src1p,
> const struct cpumask *src2p)
Ditto.
And seems a lot of cases in the series like this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-07-02 12:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 12:54 [PATCH 0/8] lib: cleanup bitmap-related headers Yury Norov
2022-07-01 12:54 ` [PATCH 1/8] arm: align find_bit declarations with generic kernel Yury Norov
2022-07-02 11:55 ` Andy Shevchenko
2022-07-01 12:54 ` [PATCH 2/8] lib/bitmap: change return types to bool where appropriate Yury Norov
2022-07-01 12:54 ` [PATCH 3/8] lib/bitmap: change type of bitmap_weight to unsigned int Yury Norov
2022-07-02 11:57 ` Andy Shevchenko
2022-07-01 12:54 ` [PATCH 4/8] cpumask: change return types to bool where appropriate Yury Norov
2022-07-01 12:54 ` [PATCH 5/8] lib/cpumask: change return types to unsigned " Yury Norov
2022-07-02 12:00 ` Andy Shevchenko [this message]
2022-07-02 21:59 ` Yury Norov
2022-07-01 12:54 ` [PATCH 6/8] lib/cpumask: move trivial wrappers around find_bit to the header Yury Norov
2022-07-01 12:54 ` [PATCH 7/8] mm: split include/linux/gfp.h Yury Norov
2022-07-02 12:05 ` Andy Shevchenko
2022-07-02 12:09 ` Andy Shevchenko
2022-07-02 22:06 ` Yury Norov
2022-07-01 12:54 ` [PATCH 8/8] lib/cpumask: move some one-line wrappers to header file Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsAzU3g2QpgmIGre@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=neilb@suse.de \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox