From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF896C43334 for ; Sat, 2 Jul 2022 11:58:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3005C6B0071; Sat, 2 Jul 2022 07:58:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B0676B0073; Sat, 2 Jul 2022 07:58:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 177966B0074; Sat, 2 Jul 2022 07:58:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 05A9E6B0071 for ; Sat, 2 Jul 2022 07:58:02 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C2AAF35AAA for ; Sat, 2 Jul 2022 11:58:01 +0000 (UTC) X-FDA: 79642011162.15.30D372C Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf17.hostedemail.com (Postfix) with ESMTP id D8E384004A for ; Sat, 2 Jul 2022 11:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656763080; x=1688299080; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=re3LFd38nLBlu3MQiWD1Ny6wrWGEckMsB9soYe/z/cY=; b=BVMYYTt0YzzRc/gF/hrTb1UpC9gU/U17CzFpL8WTJA4x9MmTt3pqiGvb x3iUGLv+ImMi2U7W9FokUoYAenOIx9ypBF5U1SmS95YffyO/msbv3nACP a2pLUYHfgQ5ptaaow1jAd2xFa0tiv5iJYD+2pKKVdg0kGa4PUfvzaxRTr 3KR0DRpqPbnYCYluRJc6d50vKsZ8tMRBXIx6758ls7hl2jTgNgu9ZjLEl ZhEw8NRWsuWavQbXk75aIgZEBUXAWImHqCiBHHt4Ubvj8z7F3ClcctuB3 O4jLXrdvTz+8bMju02tID7gS4vXtzzThvMjMvJJ9tOjIHLpf85GPCvBW4 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10395"; a="280380388" X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="280380388" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 04:57:59 -0700 X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="541992929" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 04:57:55 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1o7bl1-0013ah-1H; Sat, 02 Jul 2022 14:57:51 +0300 Date: Sat, 2 Jul 2022 14:57:51 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Howells , Geert Uytterhoeven , Jonathan Corbet , "Kirill A . Shutemov" , Matthew Wilcox , NeilBrown , Rasmus Villemoes , Russell King , Vlastimil Babka , William Kucharski , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 3/8] lib/bitmap: change type of bitmap_weight to unsigned int Message-ID: References: <20220701125430.2907638-1-yury.norov@gmail.com> <20220701125430.2907638-4-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701125430.2907638-4-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656763081; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nx2Cscref2oW2SEOE6ixAJxVqtzSQwCLQWnvnelgnAI=; b=4gb/HE6HIceMoVYpNGPK+SpVFgfK27N3lViedMdBvTlMt8sgo7/ImX9Rg3Wh5hsDImz0sR UPt14w9qv48QRcttGsE1oYZhmcVzYxtWIpChadiuJb8eur0idQR6ChUbiPBWXL7vNo4N6n 5V9NIniiFM/7ayWqif4tQcwl9cjBaXo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656763081; a=rsa-sha256; cv=none; b=8jprMuKQYckSZ9p3Z4EJ3Ry1ovOibxD9MeEjbp6DCIDuToVodUXisEdyS8reHmaNKt6oz3 tao8MS6yoYExmYGU3CCyxUlJMA4JueVfjg7DkkiQQvaD6oysvSQ5bcOdEUg+qEWbC/JYJe BZgVBGkpNIqjpQzMX8s8xr43qBn10/8= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BVMYYTt0; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=andriy.shevchenko@linux.intel.com X-Stat-Signature: y6pur3ywarx8aim6oq951jfdrsp83x7t X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BVMYYTt0; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.55.52.93) smtp.mailfrom=andriy.shevchenko@linux.intel.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D8E384004A X-HE-Tag: 1656763080-307126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 01, 2022 at 05:54:25AM -0700, Yury Norov wrote: > bitmap_weight() doesn't return negative values, so change it's type > to unsigned int. Patch (the code) suggests something else. > It may help compiler to generate better code and > catch bugs. ... > -int __bitmap_weight(const unsigned long *bitmap, unsigned int nbits); > +unsigned long __bitmap_weight(const unsigned long *bitmap, unsigned int nbits); -- With Best Regards, Andy Shevchenko