From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28FE6C433EF for ; Sat, 2 Jul 2022 11:56:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D48E6B0071; Sat, 2 Jul 2022 07:56:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 484016B0073; Sat, 2 Jul 2022 07:56:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34CCB6B0074; Sat, 2 Jul 2022 07:56:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 22EB46B0071 for ; Sat, 2 Jul 2022 07:56:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id DA40012141B for ; Sat, 2 Jul 2022 11:56:07 +0000 (UTC) X-FDA: 79642006374.06.3C1B35B Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf17.hostedemail.com (Postfix) with ESMTP id A379D40039 for ; Sat, 2 Jul 2022 11:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656762966; x=1688298966; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IHRxPXI2AjXfX75L8NFTEgjJ1hQ1grsVio3ExHvN1eY=; b=gTxzzXpHJggiIgHsqsxfsAf+cdWFYUMbYnbEFyfbNeAplcuvxdY7Fdyr qxoE54YKPxAOis9BxS6B/TAoLg4cJm1TxWPlwqsoHz9KhyRatCzFFPGhb fMAE4XDrJGm/Te0GQXqdOt2dkTpKPYZB1KcgMp0OjbCUsZgFIASMFpJ9Q ooIJ4zkM520bi2F5FMGThbuneURrMSJXn3paTg1myI5RwQY6D450XNmNR 0rLNaT6xQru37s0Zw49N7uLsdfAbsNknk0+DViAOrRW9f399Z8goLFIpl 7bAp0pbsN1B07asQ6Q2gVBRvAXxHKKF0RfM9KvONkcJseFezy2YmMNEfj w==; X-IronPort-AV: E=McAfee;i="6400,9594,10395"; a="265854506" X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="265854506" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 04:56:04 -0700 X-IronPort-AV: E=Sophos;i="5.92,239,1650956400"; d="scan'208";a="768758377" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2022 04:56:00 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1o7bjA-0013aa-2j; Sat, 02 Jul 2022 14:55:56 +0300 Date: Sat, 2 Jul 2022 14:55:56 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Howells , Geert Uytterhoeven , Jonathan Corbet , "Kirill A . Shutemov" , Matthew Wilcox , NeilBrown , Rasmus Villemoes , Russell King , Vlastimil Babka , William Kucharski , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 1/8] arm: align find_bit declarations with generic kernel Message-ID: References: <20220701125430.2907638-1-yury.norov@gmail.com> <20220701125430.2907638-2-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701125430.2907638-2-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gTxzzXpH; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656762967; a=rsa-sha256; cv=none; b=l/vfs/zgxPk0VBrwgmTYFNU1a0oMaiSD0TyX60KQpc0pR9/tGQC0UURiO9q/6Ph15bE46R ZUkNrW1KODFDokgmwLziGE9AcP1T//6O+MM+pnl5P2IfMMTngX+sQ92IKVdQzDfJZ4uFtT 5xu6KXvngzEdUu+mMggkGSdopAIQCsA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656762967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jniYWa7KNIJDc+8OPzuwcr6Op5QYheM5pRl/jK9oOBw=; b=W3ndlesfoK31wYLjTofPrRNLe9Yf0jQ+F2lRdiEcNy7T+7kMUcfNGhjs3YLMBiMSZLZY5n O+cPCGhmtDO7Cjm0RCpai7B0bNllkK6XKhX8iAgdNB88kNCTCH3usYSFbhMa0MjBe5Yv8r lXuZev9eQtEoP8wfGEAHRh72y+Wqs4U= X-Stat-Signature: icsu7edt31pp5wn7aeo8cyjqiz4tbqwi X-Rspamd-Queue-Id: A379D40039 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gTxzzXpH; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf17.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=andriy.shevchenko@linux.intel.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1656762966-532948 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 01, 2022 at 05:54:23AM -0700, Yury Norov wrote: > ARM has their own implementation for find_bit functions, and function > declarations are different with those in generic headers. Fix it. ... > -extern int _find_first_zero_bit_le(const unsigned long *p, unsigned size); > -extern int _find_next_zero_bit_le(const unsigned long *p, int size, int offset); > -extern int _find_first_bit_le(const unsigned long *p, unsigned size); > -extern int _find_next_bit_le(const unsigned long *p, int size, int offset); > +unsigned long _find_first_zero_bit_le(const unsigned long *p, unsigned long size); > +unsigned long _find_next_zero_bit_le(const unsigned long *p, > + unsigned long size, unsigned long offset); > +unsigned long _find_first_bit_le(const unsigned long *p, unsigned long size); > +unsigned long _find_next_bit_le(const unsigned long *p, > + unsigned long size, unsigned long offset); Indentation seems broken. Also for all: is double space required? ... > +unsigned long _find_next_bit_be(const unsigned long *p, > + unsigned long size, unsigned long offset); Indentation of the second line is broken (u in 'unsigned' should be in the same column as 'const'). -- With Best Regards, Andy Shevchenko