From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D387EC433EF for ; Wed, 13 Jul 2022 15:36:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 332CC940147; Wed, 13 Jul 2022 11:36:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E12B940134; Wed, 13 Jul 2022 11:36:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 183AF940147; Wed, 13 Jul 2022 11:36:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 01FE0940134 for ; Wed, 13 Jul 2022 11:36:00 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CACADF84 for ; Wed, 13 Jul 2022 15:36:00 +0000 (UTC) X-FDA: 79682477280.22.85DE099 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 3DF9340043 for ; Wed, 13 Jul 2022 15:36:00 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 44C28618B6; Wed, 13 Jul 2022 15:35:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F184C34114; Wed, 13 Jul 2022 15:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657726558; bh=mgxy9tQlFOmuXGe/eDtjY4cNpf4Y+AzDQIzHZ79WdcU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pYuTs0tk2wj9krwWwVU7XAoM7TqSndfIBr601D0J36JHSuzoIsmSftnD3LfBN6j5f CYyX76ZU0MrLKgJD/zO+5IhBxFj7Ecl2Nv56vs33nbQsSofTebQ0St3dfQAy2/JxL6 RpzqIQIwIHqfOlPztwzTmSGZW4F4OGi0ri2DGtJ0= Date: Wed, 13 Jul 2022 17:35:54 +0200 From: Greg Kroah-Hartman To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Richard Palethorpe , Jeroen Hofstee , Linux Memory Management List , kernel test robot , lkp@intel.com, lkp@lists.01.org, ltp@lists.linux.it, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jiri Slaby , Marc Kleine-Budde , Paolo Abeni , Sebastian Andrzej Siewior , Vincent Mailhol , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] can: slcan: do not sleep with a spin lock held Message-ID: References: <20220713151947.56379-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220713151947.56379-1-dario.binacchi@amarulasolutions.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657726560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S02Q96gyMgPN8msNY/iAuR/VLqeGPTMZ8lTsCCfZuGg=; b=6ZpK6om4EoaGYrl3hcJ8PQL98DXxDbpmgIAJC4+i30QPkNZ0hHm1VBu3+SlCGT9AIXZ5px CDexq5+ijS0S9JMAZh2ViebvVBQ5R8P3tefRVssnOMgKmmLeX9xgXhjV11uRIlD+03tlN1 Ne8lNs7DLJ9wR0FeANCRX0/XfFtIYiY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=pYuTs0tk; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf01.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657726560; a=rsa-sha256; cv=none; b=vFDgCGA3+ePzCPeSZSMoij1JW8Fke7Z3CB13U0ZTh6Z9NeXY6sV+okq4QD7mSRWCE8XKIz uaML+RrKXmRMZjc31NakCykOKDUP/sjlSWUMPYEo9IrebDwPfqSyd+5NZfRPXSzomiCluq Cldk3dmWnwloIcA0gpXAuWeGFfjrSdk= X-Stat-Signature: w46as8ain4u4ju6gm1hewc9enjchmd58 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3DF9340043 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=pYuTs0tk; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf01.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspam-User: X-HE-Tag: 1657726560-836221 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 13, 2022 at 05:19:47PM +0200, Dario Binacchi wrote: > We can't call close_candev() with a spin lock held, so release the lock > before calling it. > > Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") > Reported-by: kernel test robot > Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ > Signed-off-by: Dario Binacchi > > --- > > drivers/net/can/slcan/slcan-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c > index 54d29a410ad5..6aaf2986effc 100644 > --- a/drivers/net/can/slcan/slcan-core.c > +++ b/drivers/net/can/slcan/slcan-core.c > @@ -688,6 +688,7 @@ static int slc_close(struct net_device *dev) > /* TTY discipline is running. */ > clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); > } > + spin_unlock_bh(&sl->lock); > netif_stop_queue(dev); Can you have a lock held when calling netif_stop_queue()? You don't mention this in your changelog text :( thanks, greg k-h