From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B66CCA47F for ; Tue, 12 Jul 2022 17:14:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15CFE9400B6; Tue, 12 Jul 2022 13:14:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E769940063; Tue, 12 Jul 2022 13:14:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC8099400B6; Tue, 12 Jul 2022 13:14:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D9F93940063 for ; Tue, 12 Jul 2022 13:14:14 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A5C1133C83 for ; Tue, 12 Jul 2022 17:14:14 +0000 (UTC) X-FDA: 79679096028.13.6F1764F Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf24.hostedemail.com (Postfix) with ESMTP id C1D7118006D for ; Tue, 12 Jul 2022 17:14:13 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id e132so8161558pgc.5 for ; Tue, 12 Jul 2022 10:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Jhqmx1a3F3cpz1DnOcnLOd5lTX3lDuBQWvMPshL+1qM=; b=Jla/g/inmpG3zTcJ5TNBbqXAnO2dtrwQRsF6L4Biv6W1qKPFpAX8mvWOVwoo9TcIIf 92lSPgeI468yuk4qwFc/fGQHZ9oAxCMS1A9qzemNqWAowXGKhWD2OysGpbxofB7X1HJF DOHelVFFV5Sz0izUmQNiH48+Ctb3R5jORGutorIjKV1J9jxvu3Fh9T7sapT5ZG+ZGN1j Bl2STq/CIh6ZVykyyzBO4uyMKDYL+V0rA6JpSuf9gqkhZsKa5IBBLoBzjrrLY2OEo2ON Qlom6AjipgipFdKj9u2gHme0XAMUYZ1RRfIF0rDbd4h7KCshl9oj/TjdeIlwHEYCyMua Anag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Jhqmx1a3F3cpz1DnOcnLOd5lTX3lDuBQWvMPshL+1qM=; b=GS8lZz5KEMxdGDvjkUlEdQytYQ6ERZHBIcMS7hqW08ujrwonRIj2X3EsmhwPSuuyqp +OSHrTwHQr4Xgq72Yy4uOvpLmueuQmZPzIAGk+LzdvzbMV1+FdC0WYMj3IRoR2yuwxwI UJyZMeYaTxJdoQtXRLx8BI4J8mor9jn7vgVzNomVPzxqoGQ5a0X26OfEhVpVBCBzD+kx nvaaaz10fkbpc58jYxIWI3L7HribKfh7X008Ablt8EAVYVcOU/NeH7KtiOs4LgS1uOZG rlqGdcQosLxPeAdXAeUbS8jqZ9O7s7Mx1oFr0cAmnuh20imBzUPT5NW2IZBbekEKCkls 2Y4g== X-Gm-Message-State: AJIora+iwgqLRwRY2Zo/qO2PRZVyxyaz4XybkF7SmxvBz5l2ZQf6oDii RYjSoxV42oyDlzb5lZWijrau6g== X-Google-Smtp-Source: AGRyM1tYEQ2QXekZM1uVi8LwzDh3RPAlAiKbJNgrNvyTMtlimVir4Vn9JQGubSHxNjSvHk8y6ddx8A== X-Received: by 2002:a63:4b17:0:b0:412:83cf:ecaf with SMTP id y23-20020a634b17000000b0041283cfecafmr21108378pga.105.1657646052403; Tue, 12 Jul 2022 10:14:12 -0700 (PDT) Received: from google.com (55.212.185.35.bc.googleusercontent.com. [35.185.212.55]) by smtp.gmail.com with ESMTPSA id c37-20020a634e25000000b004119deff40dsm6372884pgb.23.2022.07.12.10.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 10:14:12 -0700 (PDT) Date: Tue, 12 Jul 2022 10:14:06 -0700 From: Zach O'Keefe To: Yang Shi Cc: Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , Rongwei Wang , SeongJae Park , Song Liu , Vlastimil Babka , Zi Yan , Linux MM , Andrea Arcangeli , Andrew Morton , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia , Pavel Begunkov , Thomas Bogendoerfer Subject: Re: [mm-unstable v7 01/18] mm/khugepaged: remove redundant transhuge_vma_suitable() check Message-ID: References: <20220706235936.2197195-1-zokeefe@google.com> <20220706235936.2197195-2-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657646054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jhqmx1a3F3cpz1DnOcnLOd5lTX3lDuBQWvMPshL+1qM=; b=nBFSDbA0uFbzErN5u60RTk1OvwwW3kiL7xi1VaKxDLS9Rh9hBJjoATHqfXFYh3S9UcHIdP VPRV+Qv68E76SBVcmRJ4XCw16V2GXRNLMfogz9T4qI4L7lDdVA7Jyxp74j6zWPIdEq/+pd vZ2lmjkyEbKzQuKLKZ8RAKfexvQEsDs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Jla/g/in"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of zokeefe@google.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657646054; a=rsa-sha256; cv=none; b=CdB/hTg6IChDKVhi1XYcsD0Q3poBx3pAJSsbfdXEFW01CaxhNLMSJ9BF+UFJTK4JzoR7Tl m4QcfT/bB00KAQO29Ue8um7Lo6j5UuC9PfZ+K6gsjAm15t4drs2DIshzYeibxtvVCNdINV HhYjL9MzSH7p3rdZr6cnJhNJLixKyS4= X-Stat-Signature: pn89t1b8whpg8ynxitqbrj8drw6pmqcq X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C1D7118006D Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Jla/g/in"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of zokeefe@google.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspam-User: X-HE-Tag: 1657646053-507709 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Jul 11 13:38, Yang Shi wrote: > On Wed, Jul 6, 2022 at 5:06 PM Zach O'Keefe wrote: > > > > transhuge_vma_suitable() is called twice in hugepage_vma_revalidate() > > path. Remove the first check, and rely on the second check inside > > hugepage_vma_check(). > > > > Signed-off-by: Zach O'Keefe > > --- > > mm/khugepaged.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > > index cfe231c5958f..5269d15e20f6 100644 > > --- a/mm/khugepaged.c > > +++ b/mm/khugepaged.c > > @@ -918,8 +918,6 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, > > if (!vma) > > return SCAN_VMA_NULL; > > > > - if (!transhuge_vma_suitable(vma, address)) > > - return SCAN_ADDRESS_RANGE; > > It seems this is the only user of SCAN_ADDRESS_RANGE, so > SCAN_ADDRESS_RANGE could be deleted as well. > Good catch! Was able to remove this. Thanks again, Zach > > if (!hugepage_vma_check(vma, vma->vm_flags, false, false)) > > return SCAN_VMA_CHECK; > > /* > > -- > > 2.37.0.rc0.161.g10f37bed90-goog > >