From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB44C43334 for ; Tue, 12 Jul 2022 13:46:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26D93940088; Tue, 12 Jul 2022 09:46:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21E52940063; Tue, 12 Jul 2022 09:46:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E7D1940088; Tue, 12 Jul 2022 09:46:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F0545940063 for ; Tue, 12 Jul 2022 09:46:53 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id C2E49120801 for ; Tue, 12 Jul 2022 13:46:53 +0000 (UTC) X-FDA: 79678573506.10.DF288E2 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf08.hostedemail.com (Postfix) with ESMTP id 4B06A160059 for ; Tue, 12 Jul 2022 13:46:53 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id i8-20020a17090a4b8800b001ef8a65bfbdso8048820pjh.1 for ; Tue, 12 Jul 2022 06:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=i7pZ4PcipKYLrg0ho7Izlf0nD/aZAytT61KCebmsGXA=; b=j7EIx30iRF+2HYXv+oTF5XP+Hclxwo8vMAG9yALcmlAzyWtJK91XzrMsj2CeteF0A1 mBNc+huHbJkp5zItEfuc29jgdyYV+nuMaULb3KVdNHxDiP5Zr6AE1gJutQc5QClX4fqq AC/Zlg20TiSEUQk0X6rXnhH3GshANyr8yKxm+MJk1xEM/dNYNFIT5f+39bw9RRiGeaYr iFpBWTuISkl0jcP3S9rqcpJWvdP9suHkv41nFnn7TwuDply6hwgyi3JqQJ0USFd6dPK9 Nel3FNcICqnnSoj5KO3JpsrXnniTQEHQFyNoOD27y3l4w8VqOEJCCG+5c/3qvx6Wo/PI SDrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=i7pZ4PcipKYLrg0ho7Izlf0nD/aZAytT61KCebmsGXA=; b=xFETc66YSLkPVlBa/xl220EBFHS6T7m2CD1N3tF7J0zeUx+QkV1LhRUKVEebIJlGkj dk7bzosefkp60HhBLO+il49DM0K3s6EjXFsiq0NjYWPTc7BX404e1I5u4owcDbxHGoCU b6i/pxfwrXIiC60zjnfAVOfb3T98bgZSgLC5eefJfMOYKZNmXM9cwcJB/NdU9bR9yVZ2 Wub/I1TsS+XL7iVOowSPFrm+D6lVxoPoSQUwkAFtgmuMXhBx+jup3GpwpmQTvJAEGfAS 7jkyJyQCna6um/wdD93wxk39XAmYIrWNpqxto20JlSf3OfsoiGlLyaGiM0AUNsSS0LSl +niw== X-Gm-Message-State: AJIora9M/Q3p7OyZFFSsoulGvWxh11dsnGXpAue5Qfb7+G+5Dl/y600G r1MIGWJsYSu7sFGYbW+FpA9GGnEn3wCzFAgt X-Google-Smtp-Source: AGRyM1tvY17Lh7iUPOBQUQuMP3B7mO9AeKvogeiXgqztU0GtsnRE+TXC9K1pgwLxypsdjFjrEw07ag== X-Received: by 2002:a17:90b:388e:b0:1f0:3d7f:e620 with SMTP id mu14-20020a17090b388e00b001f03d7fe620mr4617398pjb.31.1657633612049; Tue, 12 Jul 2022 06:46:52 -0700 (PDT) Received: from google.com (55.212.185.35.bc.googleusercontent.com. [35.185.212.55]) by smtp.gmail.com with ESMTPSA id c38-20020a631c66000000b0041166bf9ca8sm6191311pgm.34.2022.07.12.06.46.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 06:46:51 -0700 (PDT) Date: Tue, 12 Jul 2022 06:46:48 -0700 From: Zach O'Keefe To: Dan Carpenter Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: [akpm-mm:mm-unstable 284/293] mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc' Message-ID: References: <202207100715.TBIYQ4fc-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202207100715.TBIYQ4fc-lkp@intel.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657633613; a=rsa-sha256; cv=none; b=nGriIsZqWrnTIOGv4Rjz9usSmBL3JkME1E8KA/TneZ0N0xsxGJEapFsb+7y1WFikaxTGHp c3znUCN9D6kCsV6uShgeOua7z1VNrqwj5ks6SXzMWn02nJAWy8sgIDwO7gLmWkIUf7M2rF 3XrObavJ9eugVwj5skm3dikxvvVOQrk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=j7EIx30i; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657633613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i7pZ4PcipKYLrg0ho7Izlf0nD/aZAytT61KCebmsGXA=; b=75OMqcO3TDHICFGAnb9/L97kN8I26aG9O+XOApe4K76n8ORv0QVyvlbgbTdOFo30TWKzJ7 0g/JM2B2R0dLsl+SLhy6mwOslSpKWuSn6NhOGBxW15TzUXPapLjWZ0iRp6jBLEnztVElwR j8VMzcnDtEidc2SAq0ZEeyz/R/SzssY= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4B06A160059 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=j7EIx30i; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Stat-Signature: t74okpojb59wxtpbhy91598sq85duxtn X-Rspam-User: X-HE-Tag: 1657633613-173334 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Jul 12 15:35, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable > head: 0e9f775fb0b4adf1a4ef50ea156ead09a0fc5194 > commit: 9f626ffb1d1c5c26b4a8e0fdffec784a5f773274 [284/293] mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse > config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220710/202207100715.TBIYQ4fc-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc' > > vim +/cc +2409 mm/khugepaged.c > > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2387 int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2388 unsigned long start, unsigned long end) > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2389 { > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2390 struct collapse_control *cc; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2391 struct mm_struct *mm = vma->vm_mm; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2392 unsigned long hstart, hend, addr; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2393 int thps = 0, last_fail = SCAN_FAIL; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2394 bool mmap_locked = true; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2395 > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2396 BUG_ON(vma->vm_start > start); > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2397 BUG_ON(vma->vm_end < end); > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2398 > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2399 cc = kmalloc(sizeof(*cc), GFP_KERNEL); > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2400 if (!cc) > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2401 return -ENOMEM; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2402 cc->is_khugepaged = false; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2403 cc->last_target_node = NUMA_NO_NODE; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2404 > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2405 *prev = vma; > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2406 > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2407 /* TODO: Support file/shmem */ > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 2408 if (!vma->anon_vma || !vma_is_anonymous(vma)) > 9f626ffb1d1c5c Zach O'Keefe 2022-07-06 @2409 return -EINVAL; > > kfree(cc);? > > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp > Yikes. Glad this was caught - my apologies here. Thanks Dan/lkp!