From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75963C433EF for ; Tue, 12 Jul 2022 13:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4006940071; Tue, 12 Jul 2022 09:27:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF17B940063; Tue, 12 Jul 2022 09:27:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B7AF940071; Tue, 12 Jul 2022 09:27:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8BE76940063 for ; Tue, 12 Jul 2022 09:27:42 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 531D034E7F for ; Tue, 12 Jul 2022 13:27:42 +0000 (UTC) X-FDA: 79678525164.18.E37ADF1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id DDEED180061 for ; Tue, 12 Jul 2022 13:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657632461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DC68EZcp8HbHnL+RJJnc8fD/j/Lhx9vJKALlsi90sNc=; b=JN03ZOgGpmaBCqYAjrO1tBPM3ggTslg/tZ39iUJ/Q4QXPjZ6LrwMh5yb09Veez4pH8u+Jj YVE+Ht9d8DyfZn0EUBuyJuiZ0NzyiZ5kd3d8Yj6ac6iwknzSOMNPb+DSdS2HP05Glb1fqN ozbo1Fwu7ufijhZUmcgskyaH+Wbr6sw= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-58-esq7UgZONAKirjn8zlvUVQ-1; Tue, 12 Jul 2022 09:27:40 -0400 X-MC-Unique: esq7UgZONAKirjn8zlvUVQ-1 Received: by mail-qv1-f71.google.com with SMTP id ld6-20020a056214418600b00472ffe4640eso1802264qvb.13 for ; Tue, 12 Jul 2022 06:27:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DC68EZcp8HbHnL+RJJnc8fD/j/Lhx9vJKALlsi90sNc=; b=uCKBVmMB1IHVNB9IZDBfU6u5yJ3Ka0sLQr1cI8ri2+13BjUQmXOXO1mxJMAngNvHRt lgj4DVnSvhAvNzSu+i8I24BP6uNscCV3aiKKu/xCTtlMUEUiv7VVCrBAWaBjivRYMdcP 1rt2SnnHUTR4D2Mz2fyThIZYBVjzWo+IeYxKBrVkWLzRdQGb4jOf24eL0h9ryUfYrJ6e hFg/8DlPnlJB/msl9fNCeEYN5bdoX8la/iQsPNPiwq2Wx2w+Q3/2OpUKb8vzG9iCpgkW ZlCJ4s4eDsvLzlaRPLifyUf0qRzxSAB8pw6MqwI+K9GROpx+P7s//dHcwCYQWrFEA+6f 9EXg== X-Gm-Message-State: AJIora/kmfSORPCWMSjiI5SIOrzylFhPOfIhUBARixc2vDZ0zuse5vjD 7nWqdpgdKkDkxh63Nl84Q9srMtFKIzLTwvTHom9kK6GGBAbMA9x+kbQq3n0pg0y3wSHIxptdOaJ 6WmXZLKG3vMc= X-Received: by 2002:a05:6214:c8a:b0:473:26f:59e0 with SMTP id r10-20020a0562140c8a00b00473026f59e0mr17562255qvr.63.1657632459749; Tue, 12 Jul 2022 06:27:39 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vwHUvgExMAHhJ8Gd2okDEZPQ1R189/OcIsXzRgysYWzxhAs75REVpZWXe77Sgmk3CxU4XqpQ== X-Received: by 2002:a05:6214:c8a:b0:473:26f:59e0 with SMTP id r10-20020a0562140c8a00b00473026f59e0mr17562224qvr.63.1657632459456; Tue, 12 Jul 2022 06:27:39 -0700 (PDT) Received: from xz-m1.local (bras-base-aurron9127w-grc-37-74-12-30-48.dsl.bell.ca. [74.12.30.48]) by smtp.gmail.com with ESMTPSA id s12-20020a05620a29cc00b006b28349678dsm10208701qkp.80.2022.07.12.06.27.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 06:27:37 -0700 (PDT) Date: Tue, 12 Jul 2022 09:27:36 -0400 From: Peter Xu To: Nadav Amit Cc: Andrew Morton , linux-mm@kvack.org, Nadav Amit , James Houghton , David Hildenbrand , Mike Rapoport , Jan Kara , Andrea Arcangeli , stable@vger.kernel.org Subject: Re: [PATCH] userfaultfd: provide properly masked address for huge-pages Message-ID: References: <20220711165906.2682-1-namit@vmware.com> MIME-Version: 1.0 In-Reply-To: <20220711165906.2682-1-namit@vmware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657632462; a=rsa-sha256; cv=none; b=0IZAHMPBrfr6TMXSiZsFldLyWwuTWTGx6i0qgNEoVFQZcMibgy8e1a3ZDgLtm/f9kNHexx WuP5Tqa8ygzDgP2qMlgTqVBcwoBJU/ujA8MeelONLK/buC9gxe83ox9odevCvjkviSScsF DWKfXdzouTa/679ydEUg8RJkFA/Oo34= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JN03ZOgG; spf=none (imf16.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657632462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DC68EZcp8HbHnL+RJJnc8fD/j/Lhx9vJKALlsi90sNc=; b=WPRgcVCxOEmeRMohChfGqitQgNFWeiSnoNjGPx+aSY6M1S8rjpIOzoxEUA4svNLBD4ePuv GC0u4e2YFtiTTdDcMYSUCqiH1rVHSe2iJW5b3rcCeNyFxNd8dwtzgM+q7DxnXAJzueFJlm 9ymXryUziWptfLlNE5lb1+5fZtXwR5w= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DDEED180061 X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JN03ZOgG; spf=none (imf16.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: 889my81h3cny9g1oe7hai8ep3t5rapsz X-HE-Tag: 1657632461-861150 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 11, 2022 at 09:59:06AM -0700, Nadav Amit wrote: > From: Nadav Amit > > Commit 824ddc601adc ("userfaultfd: provide unmasked address on > page-fault") was introduced to fix an old bug, in which the offset in > the address of a page-fault was masked. Concerns were raised - although > were never backed by actual code - that some userspace code might break > because the bug has been around for quite a while. To address these > concerns a new flag was introduced, and only when this flag is set by > the user, userfaultfd provides the exact address of the page-fault. > > The commit however had a bug, and if the flag is unset, the offset was > always masked based on a base-page granularity. Yet, for huge-pages, the > behavior prior to the commit was that the address is masked to the > huge-page granulrity. > > While there are no reports on real breakage, fix this issue. If the flag > is unset, use the address with the masking that was done before. > > Fixes: 824ddc601adc ("userfaultfd: provide unmasked address on page-fault") > Reported-by: James Houghton > Cc: Peter Xu > Cc: David Hildenbrand > Cc: Mike Rapoport > Cc: Jan Kara > Cc: Andrea Arcangeli > Cc: > Signed-off-by: Nadav Amit Reviewed-by: Peter Xu -- Peter Xu