From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F04C433EF for ; Thu, 14 Jul 2022 04:24:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABE6794016E; Thu, 14 Jul 2022 00:24:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A45B7940134; Thu, 14 Jul 2022 00:24:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E5FD94016E; Thu, 14 Jul 2022 00:24:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7B1F3940134 for ; Thu, 14 Jul 2022 00:24:03 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2B39A102F for ; Thu, 14 Jul 2022 04:24:03 +0000 (UTC) X-FDA: 79684412766.12.86464B4 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id 1BC594007B for ; Thu, 14 Jul 2022 04:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wvxNVC7v6IRfhPDvi+vlda/Ydr6xcl7uzGy3JRiwJsk=; b=h6zx/qtQBkYoU+/liavyngGoGQ qsOPbojToSP07GYfoD4L1Rj/BdqAn48dD0TbbkCv6s0frYjwB2NxyHfS8sg/zexGgCpRPzE/TYQFN Li5G/evrqQyw+eHnbHDEYkA4UPfWAFvroO4nVkNVpo0j73IBWKbiJAUxbwqIo60Snl76iyVaNU4i/ PwqGuaMEcrYNxkwnJJxhEXZau/ZDirtLGlKAl9iQ27dKm5Nb57sDSzijqu4zBp3yAGRrB/+7UcQNB Eqroje4xhcnqhz99amuRSNTyDZf+KIL39W8xd/Abw/myVnEL3l8woK+0k4FNHzi/b7nJee72rFeH8 mFG3QhHQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBqOC-00AasH-TU; Thu, 14 Jul 2022 04:23:48 +0000 Date: Wed, 13 Jul 2022 21:23:48 -0700 From: Christoph Hellwig To: Song Liu Cc: Christoph Hellwig , Song Liu , bpf , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-modules@vger.kernel.org" , "mcgrof@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "mhiramat@kernel.org" , "naveen.n.rao@linux.ibm.com" , "davem@davemloft.net" , "anil.s.keshavamurthy@intel.com" , "keescook@chromium.org" , "dave@stgolabs.net" , "daniel@iogearbox.net" , Kernel Team , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "rick.p.edgecombe@intel.com" , "akpm@linux-foundation.org" Subject: Re: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which allocates RO+X memory Message-ID: References: <20220713071846.3286727-1-song@kernel.org> <20220713071846.3286727-2-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657772642; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wvxNVC7v6IRfhPDvi+vlda/Ydr6xcl7uzGy3JRiwJsk=; b=GyYTAnwuRpJjISFpbxE/Sjf/FboRJCMuZ07F/304JZ+OPCIfpZDKdG29ENA+lsGXYoFBGR i8tQ/E1HIRKphZELH0Z1m5HVKx7RIjI5qFFoim94Djm7e4bdSdHJcO7p6Nj2dMXTyuPl0D nh/PZiCBRAxUIFbghj257ra+bsL75Oo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="h6zx/qtQ"; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+ea129a1fdab225db75dd+6899+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ea129a1fdab225db75dd+6899+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657772642; a=rsa-sha256; cv=none; b=g8+Yq2nb0sxmchxbRtbzG4iJJDCJkmo8yBiTgCxz3uf9PVnB76RZFExEwajXkGTaq1dRjG ijGSODBt/t6inc6pwv0ZUs2ggKdoOi02kSSlgkXJhwD8x+33KGIjwiu3ySPAxex5WjTb4T sXZn+ZFJh3cIVoGjgrbLvbxGzoldXMQ= X-Stat-Signature: 8arayt3m4guc5m66hrceimpzkgwf6375 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1BC594007B Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="h6zx/qtQ"; dmarc=none; spf=none (imf11.hostedemail.com: domain of BATV+ea129a1fdab225db75dd+6899+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+ea129a1fdab225db75dd+6899+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: X-HE-Tag: 1657772640-150157 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 13, 2022 at 03:49:45PM +0000, Song Liu wrote: > > > > On Jul 13, 2022, at 3:08 AM, Christoph Hellwig wrote: > > > > NAK. This is not something that should be an exported public API > > ever. > > Hmm.. I will remove EXPORT_SYMBOL_GPL (if we ever do a v2 of this..) Even without that it really is not a vmalloc API anyway. Executable memory needs to be written first, so we should allocate it in that state and only mark it executable after that write has completed.