From: Christoph Hellwig <hch@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: Christoph Hellwig <hch@infradead.org>, Song Liu <song@kernel.org>,
bpf <bpf@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"anil.s.keshavamurthy@intel.com" <anil.s.keshavamurthy@intel.com>,
"keescook@chromium.org" <keescook@chromium.org>,
"dave@stgolabs.net" <dave@stgolabs.net>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
Kernel Team <Kernel-team@fb.com>,
"x86@kernel.org" <x86@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"rick.p.edgecombe@intel.com" <rick.p.edgecombe@intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which allocates RO+X memory
Date: Wed, 13 Jul 2022 21:23:48 -0700 [thread overview]
Message-ID: <Ys+aVKFJaQd130Pn@infradead.org> (raw)
In-Reply-To: <BE896037-B79C-4B38-B777-96002C5861F5@fb.com>
On Wed, Jul 13, 2022 at 03:49:45PM +0000, Song Liu wrote:
>
>
> > On Jul 13, 2022, at 3:08 AM, Christoph Hellwig <hch@infradead.org> wrote:
> >
> > NAK. This is not something that should be an exported public API
> > ever.
>
> Hmm.. I will remove EXPORT_SYMBOL_GPL (if we ever do a v2 of this..)
Even without that it really is not a vmalloc API anyway. Executable
memory needs to be written first, so we should allocate it in that state
and only mark it executable after that write has completed.
next prev parent reply other threads:[~2022-07-14 4:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220713071846.3286727-1-song@kernel.org>
[not found] ` <20220713071846.3286727-2-song@kernel.org>
2022-07-13 9:53 ` Peter Zijlstra
2022-07-13 10:08 ` Christoph Hellwig
2022-07-13 15:49 ` Song Liu
2022-07-14 4:23 ` Christoph Hellwig [this message]
2022-07-14 4:54 ` Song Liu
2022-07-14 18:15 ` Uladzislau Rezki
2022-07-15 0:24 ` Song Liu
2022-07-13 10:20 ` Peter Zijlstra
2022-07-13 15:48 ` Song Liu
2022-07-13 20:26 ` Peter Zijlstra
2022-07-13 21:20 ` Song Liu
2022-07-14 10:10 ` Peter Zijlstra
2022-07-14 5:16 ` Christoph Hellwig
2022-07-14 7:26 ` Peter Zijlstra
2022-08-05 5:29 ` Song Liu
2022-08-05 5:29 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ys+aVKFJaQd130Pn@infradead.org \
--to=hch@infradead.org \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox