From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5D3C433EF for ; Wed, 29 Jun 2022 15:47:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73B118E000D; Wed, 29 Jun 2022 11:47:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EABB8E0009; Wed, 29 Jun 2022 11:47:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B21B8E000D; Wed, 29 Jun 2022 11:47:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 45AC48E0009 for ; Wed, 29 Jun 2022 11:47:35 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 178C2203FD for ; Wed, 29 Jun 2022 15:47:35 +0000 (UTC) X-FDA: 79631703270.02.E80B67A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id AB20AC000F for ; Wed, 29 Jun 2022 15:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656517654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U8Ds3TbgTN/BrvT8Bwf0Lryi8VbFB5ioWWlf5jjfYQo=; b=D8c8PakH6L0C4svJ1dKfkTLCpxDoimpziNrXoY5P/0+TpdArUkUT8Q2VW3nepErlQfSuQP eorQRih/AMrwUr8yDjNycqLxamzQqS/ZfNmu8pRYFmFZ/yWUfSjt3n4cnBbUwQVp67SvNr zO3463NmHnTmHv6NBr1rBa+EEc/LQTg= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-427-tkbgsL5SPHCNGLeAkYM1Ag-1; Wed, 29 Jun 2022 11:47:32 -0400 X-MC-Unique: tkbgsL5SPHCNGLeAkYM1Ag-1 Received: by mail-io1-f71.google.com with SMTP id c8-20020a056602334800b0067500ca88aaso8412720ioz.0 for ; Wed, 29 Jun 2022 08:47:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U8Ds3TbgTN/BrvT8Bwf0Lryi8VbFB5ioWWlf5jjfYQo=; b=BZ3/HskSfqs1xsIUoDj1mfcsjXfLdmLu5GOz8FRQNatAHi0E0F2cFUdb60weOf7fyP Vp8Y2dB5g3KV8Dwyo4lsJy9cWmXt3Odmc81lhASh/vRFSsuS5KIeyHdE2OwCykaobDqT 9F7E3GDwd7JJiTTJRDApPxOUN5/jhVPDDOVTt8HCUnEBZ9XfJOakuBLRYqiY5bwKcZKu ERUpDzsc/JOBQ5T41iLCDV4W/3PIe7u4A6BEXqoUd7v0mIdVMBhMcuOZWhuu2hbHI4jJ yGYQ3nXmXJk5iWAGyTY5DowVS6vmFyPPM38HpHCTi2FY8Gs9hnnnuH4fEqseHHDoEGzg jocg== X-Gm-Message-State: AJIora8SFUursZCgjlRkE7DlfkP7t00FyNvjyQtprT62yaLJtEQZLgP1 mA8d/vTrsmMAOZ0nMeZfZ95PLBg0y8h6Nph9Fmf3gq5xWSL4hp5VhXYj2EDLlCrmkGV4XO9UQTf OB3gArieuGro= X-Received: by 2002:a05:6602:2cce:b0:675:544e:da0b with SMTP id j14-20020a0566022cce00b00675544eda0bmr1865127iow.123.1656517652113; Wed, 29 Jun 2022 08:47:32 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uu/XLV/wT9doTP58QoaWMZhzxtKJWV9+WuLdJ85w0ChD+SfmtkCnXBya/7EZkV1EBDilbTMQ== X-Received: by 2002:a05:6602:2cce:b0:675:544e:da0b with SMTP id j14-20020a0566022cce00b00675544eda0bmr1865111iow.123.1656517651766; Wed, 29 Jun 2022 08:47:31 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id a22-20020a027356000000b00331cfbce17csm7439570jae.100.2022.06.29.08.47.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 08:47:30 -0700 (PDT) Date: Wed, 29 Jun 2022 11:47:29 -0400 From: Peter Xu To: John Hubbard Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE Message-ID: References: <20220622213656.81546-1-peterx@redhat.com> <20220622213656.81546-2-peterx@redhat.com> <16c181d3-09ef-ace4-c910-0a13fc245e48@nvidia.com> <177284f9-416d-c142-a826-e9a497751fca@nvidia.com> MIME-Version: 1.0 In-Reply-To: <177284f9-416d-c142-a826-e9a497751fca@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D8c8PakH; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656517654; a=rsa-sha256; cv=none; b=n9yLp9lBDnYJkrVLGzZBdfMEPYK7LFOCJXsZXMGN4Iqw/d63cqyik/kSu038FUVGhByerr KFlVSAuNxrXtsOmC9yGdaOOSi84EJwlUixpWL2AhwZvFLgr2d4QzgrpQWhuffPZCMH6OEm r7aUPtrDQ80598f2iPdqHq4sXibfhcU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656517654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U8Ds3TbgTN/BrvT8Bwf0Lryi8VbFB5ioWWlf5jjfYQo=; b=CwasIbl/v7NeiJlVAbeR4GmNxk+OYdOGZ6W6xMa33oyL9wVpbosK1IKmwKr4ugo8R12o6t hwNfjy3RnQwDVbtGVuF0FQJjgc2iqWGD5QAoMG9VmyoCdPKXuk9WJW0GZ3bAwcTPbPS+dj LboU4SndY5Ty9xqlf9NigUiCIJ9nl9c= X-Stat-Signature: qn38o3quxg5ueqte663qa3wbao5bykjq X-Rspamd-Server: rspam08 X-Rspam-User: X-Rspamd-Queue-Id: AB20AC000F Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D8c8PakH; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf10.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com X-HE-Tag: 1656517654-585353 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 28, 2022 at 05:31:43PM -0700, John Hubbard wrote: > On 6/28/22 15:33, Peter Xu wrote: > > > The key point is the connection between "locked" and killable. If the comment > > > explained why "locked" means "killable", that would help clear this up. The > > > NOWAIT sentence is also confusing to me, and adding "mostly NOWAIT" does not > > > clear it up either... :) > > > > Sorry to have a comment that makes it feels confusing. I tried to > > explicitly put the comment to be after setting FAULT_FLAG_KILLABLE but > > obviously I didn't do my job well.. > > > > Maybe that NOWAIT thing adds more complexity but not even necessary. > > > > Would below one more acceptable? > > > > /* > > * We'll only be able to respond to signals when "locked != > > * NULL". When with it, we'll always respond to SIGKILL > > * (as implied by FAULT_FLAG_KILLABLE above), and we'll > > * respond to non-fatal signals only if the GUP user has > > * specified FOLL_INTERRUPTIBLE. > > */ > > > It looks like part of this comment is trying to document a pre-existing > concept, which is that faultin_page() only ever sets FAULT_FLAG_KILLABLE > if locked != NULL. I'd say that's not what I wanted to comment.. I wanted to express that INTERRUPTIBLE should rely on KILLABLE, that's also why I put the comment to be after KILLABLE, not before. IMHO it makes sense already to have "interruptible" only if "killable", no matter what's the pre-requisite for KILLABLE (in this case it's having "locked" being non-null). > The problem I am (personally) having is that I don't yet understand why > or how those are connected: what is it about having locked non-NULL that > means the process is killable? (Can you explain why that is?) Firstly RETRY_KILLABLE relies on ALLOW_RETRY, because if we don't allow retry at all it means we'll never wait in handle_mm_fault() anyway, then no need to worry on being interrupted by any kind of signal (fatal or not). Then if we allow retry, we need some way to know "whether mmap_sem is released or not" during the process for the caller (because the caller cannot see VM_FAULT_RETRY). That's why we added "locked" parameter, so that we can set *locked=false to tell the caller we have released mmap_sem. I think that's why we have "locked" defined as "we allow this page fault request to retry and wait, during wait we can always allow fatal signals". I think that's defined throughout the gup call interfaces too, and faultin_page() is the last step to talk to handle_mm_fault(). To make this whole picture complete, NOWAIT is another thing that relies on ALLOW_RETRY but just to tell "oh please never release the mmap_sem at all". For example, when we want to make sure no vma will be released after faultin_page() returned. > > If that were clear, I think I could suggest a good comment wording. IMHO it's a little bit weird to explain "locked" here, especially after KILLABLE is set, that's why I didn't try to mention "locked" in my 2nd attempt. There are some comments for "locked" above the definition of faultin_page(), I think that'll be a nicer place to enrich explanations for "locked", and it seems even more suitable as a separate patch? Thanks, -- Peter Xu