From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18551C43334 for ; Tue, 28 Jun 2022 23:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7224D8E0001; Tue, 28 Jun 2022 19:02:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D2186B0072; Tue, 28 Jun 2022 19:02:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 599828E0001; Tue, 28 Jun 2022 19:02:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 482FE6B0071 for ; Tue, 28 Jun 2022 19:02:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 25BC7123235 for ; Tue, 28 Jun 2022 23:02:40 +0000 (UTC) X-FDA: 79629170880.28.A343891 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id A503218001B for ; Tue, 28 Jun 2022 23:02:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656457358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BILLrOx0KBGDparaBoWGr82nDo23bdigh/cJQEB6on8=; b=PbF5nDNrtGFSvAcTm9NcBM9T+KSpvPpEME1I0wdJiMOZh0gb8OjKtykhFIVW/VVOc7Qj9G 25WB1GlK+dqSiT66gjZEzErE8lzI/ktENTcjQxm9DZEHo8bfP1626cJQAl41VGq521Fj3E yDd1IT+CSHJmjTmWwmhkZKUU99upmZE= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-01DzqckVMhC6-H3pdXMo6Q-1; Tue, 28 Jun 2022 19:02:35 -0400 X-MC-Unique: 01DzqckVMhC6-H3pdXMo6Q-1 Received: by mail-il1-f200.google.com with SMTP id z1-20020a92cec1000000b002da6e27e130so6855389ilq.2 for ; Tue, 28 Jun 2022 16:02:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BILLrOx0KBGDparaBoWGr82nDo23bdigh/cJQEB6on8=; b=AJ1yWfDAR0F+YEMqN14IIDw6hsXBNkdKh4jIptcbPvgleaYkWIlIfq+gUi6Bj7kZTC YSjEEZ7O3CBmlhYHDl7+OrcK025fnE959MtELZkm14v2Rm02B334UScEWspUzG65wReR f7OfdfUI58BToD4L/iTZGoHtmWSVqplPDgBY9D2oLql9K1WsCnJWK7kEE+K2o894dyDb pnioUo5hiRj9AyYQr4WTY2OlwmokLbvX3jhYuxTDIs7UqxNJmznkoVkk4uSrhsRUOb67 ykGsg/U6S2wODRNQjDaZmazsj56/IFZSe3SavLVLzP81+CH2uZeA/U5VNcAvWEi50DHb 2bVQ== X-Gm-Message-State: AJIora9YqnAZnsUqw/y+cj0HkubSZlrvC94pw4fbmo8Ge9ERYvVShs9v hf4PMpOQFfD623D+4g2/KB31LGuG6F2sXOvQ/8PeMpPf6vH5MQDfaA8sA6Ny9clB45+Oit6lvZV hqK9n9yJTmjc= X-Received: by 2002:a05:6638:1446:b0:331:e0cc:bd15 with SMTP id l6-20020a056638144600b00331e0ccbd15mr289899jad.89.1656457354972; Tue, 28 Jun 2022 16:02:34 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sktsRJzoU53vy6uKrBPRFlirO/gd0xp0mF0YJcR9N5sGdjb8aEiG+AA9O8limDyR6fBWNUhA== X-Received: by 2002:a05:6638:1446:b0:331:e0cc:bd15 with SMTP id l6-20020a056638144600b00331e0ccbd15mr289894jad.89.1656457354776; Tue, 28 Jun 2022 16:02:34 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id x8-20020a6bd008000000b006755ae0679bsm1816220ioa.50.2022.06.28.16.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 16:02:34 -0700 (PDT) Date: Tue, 28 Jun 2022 19:02:32 -0400 From: Peter Xu To: John Hubbard Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 2/4] kvm: Merge "atomic" and "write" in __gfn_to_pfn_memslot() Message-ID: References: <20220622213656.81546-1-peterx@redhat.com> <20220622213656.81546-3-peterx@redhat.com> <02831f10-3077-8836-34d0-bb853516099f@nvidia.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656457359; a=rsa-sha256; cv=none; b=GpXdnCniKjRPXu5lROuwK9HnQYChCXQ2phn0/2YFot7h6pTmhlGL0Bk+ZQZIamDKNuumSW YmbVv05JEdBtMD8EIXuNKyNCFwq9rtZwgMZhGjMt7yDZ7iALlwpBO63/sQDlCCd2TtrPw1 CqBoyTGeawG0ut3xrGH0rsEeXZ4R1Q8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PbF5nDNr; spf=none (imf06.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656457359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BILLrOx0KBGDparaBoWGr82nDo23bdigh/cJQEB6on8=; b=V6v1jkjgFhxjJFm9NAA7hyy03YdpUyeJAzQkVKAPE+SOT84KyyFn6IxA9dvecYxusq+tq/ 533oKqD6Hlz0ftfd9N8+mJIqAH8J6KVyzgsSxfdErYSstwTDYTl9zNPJvvsJAUoxF+nasz hThmkn56DBEKKkOKowXpB3EVEJf9qcA= X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PbF5nDNr; spf=none (imf06.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Stat-Signature: 1j51q8un8bctiniuuu5f1xua9b48ruzy X-Rspamd-Queue-Id: A503218001B X-HE-Tag: 1656457359-534724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 28, 2022 at 03:55:22PM -0700, John Hubbard wrote: > On 6/28/22 15:50, Peter Xu wrote: > > And if you see the patch I actually did something similar (in kvm_host.h): > > > > /* gfn_to_pfn (gtp) flags */ > > ... > > > > I'd still go for GTP, but let me know if you think any of the above is > > better, I can switch. > > > > Yeah, I'll leave that call up to you. I don't have anything better. :) Thanks. I'll also give it a shot with Sean's suggestion on struct when repost (I doubt whether I can bare with 4 bools after all..). If that goes well we don't worry this too since there'll be no flag introduced. -- Peter Xu