From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1037C433EF for ; Tue, 28 Jun 2022 22:50:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39BFC6B0071; Tue, 28 Jun 2022 18:50:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34B376B0072; Tue, 28 Jun 2022 18:50:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 212198E0001; Tue, 28 Jun 2022 18:50:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0F1016B0071 for ; Tue, 28 Jun 2022 18:50:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C1C64233B5 for ; Tue, 28 Jun 2022 22:50:09 +0000 (UTC) X-FDA: 79629139338.01.6ABD802 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 1D4AF40037 for ; Tue, 28 Jun 2022 22:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656456608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W3kLhAZGK2ncHck2YD7sSY1Nrpc3ON/goS7rYhosu+8=; b=UL1SNrMwUdd20s0cmAaG3JJ2iRMZW4q3oCJwymQxqFI0j5fBBS9VBlwy78BQ0Sl0fXBv5n cA/n+wWOjakgC2kc/8BYvqqbR+y/laS/f1SiVFMj3EEDybVJ/4Yy1OuUPGusRjxT471g8R iG/pqxJAawUAz7fOzaIw3qzBVz9LqmY= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-384--bdaiiEyMRKfa262b0m3iQ-1; Tue, 28 Jun 2022 18:50:07 -0400 X-MC-Unique: -bdaiiEyMRKfa262b0m3iQ-1 Received: by mail-il1-f197.google.com with SMTP id z18-20020a056e02089200b002dab7cef3d2so1171044ils.16 for ; Tue, 28 Jun 2022 15:50:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=W3kLhAZGK2ncHck2YD7sSY1Nrpc3ON/goS7rYhosu+8=; b=Y3bhg5PSD8diA+tRRdBFfqHJtb+snb2l09NUi0QmGWURyC/G2NqAuGAeZkd3Ltj1Nv USKB/v8sfA7Poo1RaQm0+g/kudo6cvE1OrZespsrH+PJTSPdcw3TxJXIWUFWwa0o57MP ERBWlVZLqSKKpsgWPEGZH1EZ1a52Cr69l+hkfmJTiL2Bap+b+3sGfNAPV29esAeii8hV BsGUVJj9bv8rUE5POxSqkBmoNeM+qUHmP+CwbUtIT1RC4isO9Arwj+FP0dp217xnXdDj wUk/9XNTWC3DMiVRJETX+uxGxPt4JmhS8ubGSO6cJU7nsX3vJ0XsHd0RsZQCMtfYPUbg fRfA== X-Gm-Message-State: AJIora9rCBNlopGNeNx4RKtGRY5njxJILUPZKxer4kw6Sq15KIJb5OVN eTj+3dZLeiWhmu/oMIqplK204mR10v2Cc2+x1pNeaSeClVEeFvmbxCdf/v3jreTOEz35i1tAu6j X0YOn55c/U0U= X-Received: by 2002:a05:6e02:15c9:b0:2da:c33e:49c7 with SMTP id q9-20020a056e0215c900b002dac33e49c7mr18969ilu.26.1656456606273; Tue, 28 Jun 2022 15:50:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uvOepd4UW7ERHSNp4aEwCJ76y/hhPsMiiTQrUS6nrxdaYCpU21kA6tkiY9yBbjfWLSCFQliA== X-Received: by 2002:a05:6e02:15c9:b0:2da:c33e:49c7 with SMTP id q9-20020a056e0215c900b002dac33e49c7mr18948ilu.26.1656456606042; Tue, 28 Jun 2022 15:50:06 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id j25-20020a02a699000000b00339c33df66bsm6537922jam.118.2022.06.28.15.50.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 15:50:05 -0700 (PDT) Date: Tue, 28 Jun 2022 18:50:03 -0400 From: Peter Xu To: John Hubbard Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 2/4] kvm: Merge "atomic" and "write" in __gfn_to_pfn_memslot() Message-ID: References: <20220622213656.81546-1-peterx@redhat.com> <20220622213656.81546-3-peterx@redhat.com> <02831f10-3077-8836-34d0-bb853516099f@nvidia.com> MIME-Version: 1.0 In-Reply-To: <02831f10-3077-8836-34d0-bb853516099f@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656456609; a=rsa-sha256; cv=none; b=YqFd4QVRo1u/uLrD0IfFSfllHezzw0PRLG8R42TYI67tBv+Z5urNC5NbXYf4WW+oJ7un3f nB01EemtiLNmDUE3pghwzvpSXDf3Awx9jL/iHqMOrCHRmqj0TlwMOYXEJE+9e32qfVvL0H UvUDYAOxMU6kAMnrs5ZJQBZ3bEW7DUM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UL1SNrMw; spf=none (imf04.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656456609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W3kLhAZGK2ncHck2YD7sSY1Nrpc3ON/goS7rYhosu+8=; b=H5WEaZwgOvMAypUNrJv525aFYZ1wOrfzuZgFex/9GLZ6Cdtnt4ntHhRtjlgrPpaCzTu00n CLfcgwbG1fOa5HurQ/FSswR9LHAMMx4uTtC/zbtN44tt+fDA/mYJGIy3zgJaBMKkv8MCs5 X5TCs3osojrbXCBkemBOdFDC1hEPV3M= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1D4AF40037 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UL1SNrMw; spf=none (imf04.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Stat-Signature: 3te3sztrhodmp9xxxk7womu1u8qrn73j X-HE-Tag: 1656456608-152664 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 28, 2022 at 02:52:04PM -0700, John Hubbard wrote: > On 6/28/22 12:46, Peter Xu wrote: > > I'd try to argu with "I prefixed it with kvm_", but oh well.. yes they're a > > bit close :) > > > > > > > > Yes, "read the code", but if you can come up with a better TLA than GTP > > > here, let's consider using it. > > > > Could I ask what's TLA? Any suggestions on the abbrev, btw? > > "Three-Letter Acronym". I love "TLA" because the very fact that one has > to ask what it means, shows why using them makes it harder to communicate. :) Ha! > > As for alternatives, here I'll demonstrate that "GTP" actually is probably > better than anything else I can come up with, heh. Brainstorming: > > * GPN ("Guest pfn to pfn") > * GTPN (similar, but with a "T" for "to") > * GFNC ("guest frame number conversion") Always a challenge on the naming kongfu. :-D One good thing on using TLA in macros, flags and codes (rather than simply mention some three letters): we can easily jump to the label of any of the flags when we want to figure out what it means, and logically there'll (and should) be explanations of the abbrev in the headers if it's a good header. Example: it's even not easy to figure out what GFP is in GFP_KERNEL flag for someone not familiar with mm (when I wrote this line, I got lost!), but when that happens we do jump label and at the entry of gfp.h we'll see: * ... The GFP acronym stands for get_free_pages(), And if you see the patch I actually did something similar (in kvm_host.h): /* gfn_to_pfn (gtp) flags */ ... I'd still go for GTP, but let me know if you think any of the above is better, I can switch. Thanks, -- Peter Xu