From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D07DC43334 for ; Tue, 28 Jun 2022 19:31:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B6996B0071; Tue, 28 Jun 2022 15:31:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 966AD6B0072; Tue, 28 Jun 2022 15:31:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E1278E0001; Tue, 28 Jun 2022 15:31:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 69E0D6B0071 for ; Tue, 28 Jun 2022 15:31:44 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 36F1F372D3 for ; Tue, 28 Jun 2022 19:31:44 +0000 (UTC) X-FDA: 79628639328.07.2257057 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id EC95B2002F for ; Tue, 28 Jun 2022 19:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656444702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aM7N7xOZQpVcWKhBhevjLYz+PsasfZgbqn1eTYJzU7E=; b=dccDbxioVQqfFR9VnWFFn5/PTnmJxFw317J687kUmemrPiNFIIfPVCKbzHcELmDOnKKYiZ 0SUIBSt2A8qrhRrVlZzdbzwcjDrRxUNlJspaRaU3TH1IuRD+/pktQ851TFZI9fnBvjMc4D WepHa/5/gFj3AWSi2ztiriQRvK2CuuE= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-77-Vr14AiNdNvGhHiuaBzJwkg-1; Tue, 28 Jun 2022 15:31:41 -0400 X-MC-Unique: Vr14AiNdNvGhHiuaBzJwkg-1 Received: by mail-il1-f197.google.com with SMTP id h5-20020a056e021d8500b002daba64574dso734953ila.3 for ; Tue, 28 Jun 2022 12:31:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aM7N7xOZQpVcWKhBhevjLYz+PsasfZgbqn1eTYJzU7E=; b=Zh1JaD3AJmxZ9z6G1ygqr8vQRvR2RGQuSSrgRgGM033STRjzSGffgLiCYc6tUjb+bt NkjwTsyu96EoTHkS7OqixTJ398RNmHPl/k5uS9VlVgofXAaqJH0tH+6onjmXk+rSBUeM Oq469waSuglMjJiZUMfjd+VjHs5l337KVX+u1DcbgJThxd0XWa9R9RuGMEIUIqD8mp4u 4ayYRrj2gFzZUyx4p7aTnOQW+1sSMqVxgJ5v6RuPhNc7r+beM3EJlcqjsFKGz5uzXjkn Cfq3eYgm3B2lvf2hEB0gkaMwxgSwci+2Ex5EYEJzQLzmzKq4zPmoEyRBBRqlHR56Gath qeRA== X-Gm-Message-State: AJIora83Fg2pWD+2VlikORFoZFHkrKtzDjKFzNtFDC0YykaGDYrTSz4B jqIPF4WHrF9XibeLfjBCTWGG9rpxBUb12L3sNdG56ylHoDbQnw/v58w99eKxPOsZjrr4ii5I2LD V7KQg1B6cB9Q= X-Received: by 2002:a05:6638:3802:b0:32e:3d9a:9817 with SMTP id i2-20020a056638380200b0032e3d9a9817mr12530752jav.206.1656444700419; Tue, 28 Jun 2022 12:31:40 -0700 (PDT) X-Google-Smtp-Source: AGRyM1to+EXCpnTsEmC5xi0MGItOFv+6X/o+CybOlBIbsbLbyXX0AmgJOhw77pJBXL2meXzcD8YUgw== X-Received: by 2002:a05:6638:3802:b0:32e:3d9a:9817 with SMTP id i2-20020a056638380200b0032e3d9a9817mr12530733jav.206.1656444700166; Tue, 28 Jun 2022 12:31:40 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id h8-20020a92d848000000b002da9f82c703sm2049757ilq.5.2022.06.28.12.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 12:31:39 -0700 (PDT) Date: Tue, 28 Jun 2022 15:31:37 -0400 From: Peter Xu To: John Hubbard Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Andrew Morton , David Hildenbrand , "Dr . David Alan Gilbert" , Andrea Arcangeli , Linux MM Mailing List , Sean Christopherson Subject: Re: [PATCH 1/4] mm/gup: Add FOLL_INTERRUPTIBLE Message-ID: References: <20220622213656.81546-1-peterx@redhat.com> <20220622213656.81546-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dccDbxio; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf03.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656444703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aM7N7xOZQpVcWKhBhevjLYz+PsasfZgbqn1eTYJzU7E=; b=haIPM58inUY9/f02LYZOK7sMH9KtF25HiD1d3DHN2B1gaISwGU2kk9XNOGIM17wIMPAIPf vd4mn3Fmg5I9/Hk+qN+1ihvAYe5trj3uO4+zI2V8Q+9brfKTd0foIxlAjt4syY3WSLoA46 PBMHAafxxqoxoA9rOXnSKCULiOLJr+k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656444703; a=rsa-sha256; cv=none; b=wzq/3XRvgDH1dp/39vuzF5B6OzyVlvfif+IQVlMEthRnAe/beSA4978yHYOe4B9OdsQ8r6 Idpulg13TMvtg7/YQwQtwXcAiGqDrnU/VvC8cUf3qTXLwzohuLizJtqyUEu87kZVX8Z3pS tSvpx5g9XbvxDtqZkMSrxr6tXWkG3LQ= X-Stat-Signature: 6frcf6zy59hbkwaj8jieq5d1uepqzpr9 X-Rspamd-Queue-Id: EC95B2002F X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dccDbxio; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf03.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com X-Rspamd-Server: rspam12 X-HE-Tag: 1656444702-150996 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, John, Thanks for your comments! On Mon, Jun 27, 2022 at 07:07:28PM -0700, John Hubbard wrote: [...] > > @@ -2941,6 +2941,7 @@ struct page *follow_page(struct vm_area_struct *vma, unsigned long address, > > #define FOLL_SPLIT_PMD 0x20000 /* split huge pmd before returning */ > > #define FOLL_PIN 0x40000 /* pages must be released via unpin_user_page */ > > #define FOLL_FAST_ONLY 0x80000 /* gup_fast: prevent fall-back to slow gup */ > > +#define FOLL_INTERRUPTIBLE 0x100000 /* allow interrupts from generic signals */ > > Perhaps, s/generic/non-fatal/ ? Sure. > > diff --git a/mm/gup.c b/mm/gup.c > > index 551264407624..ad74b137d363 100644 > > --- a/mm/gup.c > > +++ b/mm/gup.c > > @@ -933,8 +933,17 @@ static int faultin_page(struct vm_area_struct *vma, > > fault_flags |= FAULT_FLAG_WRITE; > > if (*flags & FOLL_REMOTE) > > fault_flags |= FAULT_FLAG_REMOTE; > > - if (locked) > > + if (locked) { > > fault_flags |= FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE; > > + /* > > + * We should only grant FAULT_FLAG_INTERRUPTIBLE when we're > > + * (at least) killable. It also mostly means we're not > > + * with NOWAIT. Otherwise ignore FOLL_INTERRUPTIBLE since > > + * it won't make a lot of sense to be used alone. > > + */ > > This comment seems a little confusing due to its location. We've just > checked "locked", but the comment is talking about other constraints. > > Not sure what to suggest. Maybe move it somewhere else? I put it here to be after FAULT_FLAG_KILLABLE we just set. Only if we have "locked" will we set FAULT_FLAG_KILLABLE. That's also the key we grant "killable" attribute to this GUP. So I thought it'll be good to put here because I want to have FOLL_INTERRUPTIBLE dependent on "locked" being set. > > > + if (*flags & FOLL_INTERRUPTIBLE) > > + fault_flags |= FAULT_FLAG_INTERRUPTIBLE; > > + } > > if (*flags & FOLL_NOWAIT) > > fault_flags |= FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_RETRY_NOWAIT; > > if (*flags & FOLL_TRIED) { > > @@ -1322,6 +1331,22 @@ int fixup_user_fault(struct mm_struct *mm, > > } > > EXPORT_SYMBOL_GPL(fixup_user_fault); > > +/* > > + * GUP always responds to fatal signals. When FOLL_INTERRUPTIBLE is > > + * specified, it'll also respond to generic signals. The caller of GUP > > + * that has FOLL_INTERRUPTIBLE should take care of the GUP interruption. > > + */ > > +static bool gup_signal_pending(unsigned int flags) > > +{ > > + if (fatal_signal_pending(current)) > > + return true; > > + > > + if (!(flags & FOLL_INTERRUPTIBLE)) > > + return false; > > + > > + return signal_pending(current); > > +} > > + > > OK. > > > /* > > * Please note that this function, unlike __get_user_pages will not > > * return 0 for nr_pages > 0 without FOLL_NOWAIT > > @@ -1403,11 +1428,11 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm, > > * Repeat on the address that fired VM_FAULT_RETRY > > * with both FAULT_FLAG_ALLOW_RETRY and > > * FAULT_FLAG_TRIED. Note that GUP can be interrupted > > - * by fatal signals, so we need to check it before we > > + * by fatal signals of even common signals, depending on > > + * the caller's request. So we need to check it before we > > * start trying again otherwise it can loop forever. > > */ > > - > > - if (fatal_signal_pending(current)) { > > + if (gup_signal_pending(flags)) { > > This is new and bold. :) Signals that an application was prepared to > handle can now cause gup to quit early. I wonder if that will break any > use cases out there (SIGPIPE...) ? Note: I introduced the new FOLL_INTERRUPTIBLE flag, so only if the caller explicitly passing in that flag could there be a functional change. IOW, no functional change intended for this single patch, not before I start to let KVM code passing over that flag. > > Generally, gup callers handle failures pretty well, so it's probably > not too bad. But I wanted to mention the idea that handled interrupts > might be a little surprising here. Yes as I mentioned anyway it'll be an opt-in flag, so by default we don't need to worry at all, IMHO, because it should really work exactly like before, otherwise I had a bug somewhere else.. :) Thanks, -- Peter Xu