From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A203AC43334 for ; Tue, 28 Jun 2022 15:07:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 272D88E0003; Tue, 28 Jun 2022 11:07:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2236F8E0002; Tue, 28 Jun 2022 11:07:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EC578E0003; Tue, 28 Jun 2022 11:07:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 01F718E0002 for ; Tue, 28 Jun 2022 11:07:27 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C10898AB for ; Tue, 28 Jun 2022 15:07:27 +0000 (UTC) X-FDA: 79627973334.14.2190F47 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf25.hostedemail.com (Postfix) with ESMTP id 400C6A002E for ; Tue, 28 Jun 2022 15:07:25 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id x8so7869955pgj.13 for ; Tue, 28 Jun 2022 08:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=anQ27xOQvEX+Td238fWqiSq/k4JFfrd9qwDUWfXBswY=; b=pN+cBhSszTlUkwollR+maUGR17eDKbdWuZXiPaxMadT+7domXFQ/U9qvjmFHV2KcJR 2mlQ9X/e5RizmM56f2d1J0SyAF+sZMdlj9vrp38VZf/un9gw9w9TdlJJ+eyGozM55kjX Ni+dMtXxkjP7LKNhQ/VPXHGOUjrnOEnAR9lVPvPuKMZKjeYx8Z5rN3b4ltUuSf5tYwaP szqudDmvN59Z52cIAVu2JaH25aVltFy+OTp9yl20Zkv9zJTVr0y0BeE1HeKk2B0u04cr FoNjpcASq8t3PvOdKq+pcaSRtqHW9thomXiTHVyo4Hv3I1ghFtyEGBuBYTv6VRlcIZgI F5pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=anQ27xOQvEX+Td238fWqiSq/k4JFfrd9qwDUWfXBswY=; b=vduxBHrDag2yaWKV2dIvOT0u0syUbQVMpGKf3Bf4k7pEa8QyIhd/am+xcyTy0p+PeG NL97MalI8Pv6oL/tZI8r/ul+avcHYCxMnR3izBRLhkyHaHxFOr6PXi7DNlvcRSgIX+cx h9nS2d7t/DOjK84u1md1NJrOBxMBVmxG9PmTe06RS67nfLTR+oUAYuV/FdYzUIRj2kmI 0faZa6TQ734th58UbD167a9XBBdfJgai6EwbeQJcZ7YQvbJwsRL3KbAG6zoV22cp66kl d4ZymvdFUbNVKJGN1KmAVqTWuGl/D6aOTWPMkjtcdSUcyhc0YZDh0YpwxIaUBLlbMrNR ofqA== X-Gm-Message-State: AJIora9S7Hz+IB+q5tu0tgCikpe8tGdwtTpqufuda2qfzfZlqC1dO1aY MEQp2D7tGDiu0NsZhWIjxAcYWs5KfDQB+rmt X-Google-Smtp-Source: AGRyM1uw8AEKAAkQ7VZZ0u/DQBpg8EZi4a78W86U5RZMo9OdkrA7cftvvhfepOTV1K7E40Vyk8a0Qg== X-Received: by 2002:a63:145e:0:b0:405:70e2:1d04 with SMTP id 30-20020a63145e000000b0040570e21d04mr17313720pgu.487.1656428499924; Tue, 28 Jun 2022 08:01:39 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:e153:cfbc:e790:5935]) by smtp.gmail.com with ESMTPSA id jh5-20020a170903328500b0015e8d4eb2b4sm9402296plb.254.2022.06.28.08.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 08:01:39 -0700 (PDT) Date: Tue, 28 Jun 2022 23:01:30 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, shy828301@gmail.com, willy@infradead.org, zokeefe@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/16] mm/huge_memory: use helper touch_pmd in huge_pmd_set_accessed Message-ID: References: <20220628132835.8925-1-linmiaohe@huawei.com> <20220628132835.8925-6-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628132835.8925-6-linmiaohe@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656428847; a=rsa-sha256; cv=none; b=x24/uvmb8Dx+OsAjxNxHv2wAPTnodw6bdSiWB3pT/4M0UEFT+nfW74mmLKVDd5kvJ23yDx Jrn8xjuY30LdRdYBCZQIBMBZm07djQickr/mNfh4Z+KvjHm/vQ7cveAFmKLQskBozM2cpU QxZqEpCoqOzhMYSa1I0yaZD/3oscXaE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=pN+cBhSs; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656428847; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=anQ27xOQvEX+Td238fWqiSq/k4JFfrd9qwDUWfXBswY=; b=otCYIXmYOiAVuFC1E2PKYDeIz5sxfw0P++7CZUqjyFplMMgpCPJrszfOEQmtYkIg6qN7IG nyDXgIsGYAbuwHLjRXJBphRalFdy9iThye8x4BSg+b/6+Kaf3BJsLh//3Z+WBj78oHCe/5 QMjpjMev/Wv1fEnG5pJ5rvY3SMUAkTA= X-Stat-Signature: 39ci1xcimcns7sxjy6j88tnxf484659w X-Rspamd-Queue-Id: 400C6A002E Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=pN+cBhSs; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf25.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1656428845-615877 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 28, 2022 at 09:28:24PM +0800, Miaohe Lin wrote: > Use helper touch_pmd to set pmd accessed to simplify the code and improve > the readability. No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 18 +++++------------- > 1 file changed, 5 insertions(+), 13 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d55d5efa06c8..d9fe9b034783 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1120,15 +1120,15 @@ EXPORT_SYMBOL_GPL(vmf_insert_pfn_pud_prot); > #endif /* CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD */ > > static void touch_pmd(struct vm_area_struct *vma, unsigned long addr, > - pmd_t *pmd, int flags) > + pmd_t *pmd, bool write) The same as comments as mentioned in previous thread. E.g. follow_devmap_pmd() and follow_trans_huge_pmd(). Thanks. > { > pmd_t _pmd; > > _pmd = pmd_mkyoung(*pmd); > - if (flags & FOLL_WRITE) > + if (write) > _pmd = pmd_mkdirty(_pmd); > if (pmdp_set_access_flags(vma, addr & HPAGE_PMD_MASK, > - pmd, _pmd, flags & FOLL_WRITE)) > + pmd, _pmd, write)) > update_mmu_cache_pmd(vma, addr, pmd); > } > > @@ -1398,21 +1398,13 @@ void huge_pud_set_accessed(struct vm_fault *vmf, pud_t orig_pud) > > void huge_pmd_set_accessed(struct vm_fault *vmf) > { > - pmd_t entry; > - unsigned long haddr; > bool write = vmf->flags & FAULT_FLAG_WRITE; > - pmd_t orig_pmd = vmf->orig_pmd; > > vmf->ptl = pmd_lock(vmf->vma->vm_mm, vmf->pmd); > - if (unlikely(!pmd_same(*vmf->pmd, orig_pmd))) > + if (unlikely(!pmd_same(*vmf->pmd, vmf->orig_pmd))) > goto unlock; > > - entry = pmd_mkyoung(orig_pmd); > - if (write) > - entry = pmd_mkdirty(entry); > - haddr = vmf->address & HPAGE_PMD_MASK; > - if (pmdp_set_access_flags(vmf->vma, haddr, vmf->pmd, entry, write)) > - update_mmu_cache_pmd(vmf->vma, vmf->address, vmf->pmd); > + touch_pmd(vmf->vma, vmf->address, vmf->pmd, write); > > unlock: > spin_unlock(vmf->ptl); > -- > 2.23.0 > >