From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA30C43334 for ; Tue, 28 Jun 2022 14:59:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6CCD8E0003; Tue, 28 Jun 2022 10:59:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D44ED8E0002; Tue, 28 Jun 2022 10:59:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0D398E0003; Tue, 28 Jun 2022 10:59:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B36FC8E0002 for ; Tue, 28 Jun 2022 10:59:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 74CD9329D7 for ; Tue, 28 Jun 2022 14:59:33 +0000 (UTC) X-FDA: 79627953426.16.EE396CD Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf15.hostedemail.com (Postfix) with ESMTP id B59A5A002C for ; Tue, 28 Jun 2022 14:59:32 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id c205so12237774pfc.7 for ; Tue, 28 Jun 2022 07:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QGQSSYQX10LNSqyvqRv+smUAZqnB+eZ8I09EE8BQPHc=; b=PobbbbzgJSQqZlq6zR24jX++8aI9boMYE/I6rpgYFZBGikOgLgeOype3+LCQFDCZgs NfVgdo0vn8M4RJt1oFBjZ6umNPNfoibA8/K1lAz5WQ1FPTwFETxC3cKLiIcGHtmr0Z4L i/Xsw7iMXWYI8TkB9SC06p5sZEh1xU+gjb/a5KrJFEA0nvyQuu3W8yQhGmUDMkXWclxs JSHrC5TJp89CGuiafwf7AFVKC44qCb/ulvWGkOyfbNPobFQu/CuRfB3ikOfSjWYdjfY1 YpX13TM35aqmgB342YXQbTiq4idrNENHhFKWdxb26sIARInWbWHp73AI8NLfz9BlrEh/ n6ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QGQSSYQX10LNSqyvqRv+smUAZqnB+eZ8I09EE8BQPHc=; b=FrUcwO8mtss+O2u5f79v1OI25U38/rLT9jtN4DDBEj9szTMw/gEypbjJiV+NX0YAC4 qVSkvH+D8GXQO5cuFMxd+zXtvRml5ta1sDDRG7AnazbGFJxo0xxkEovDqRPzH6hYbsW2 Vd2PxITGLU++CtihaptWAciIemr3CMgQvJdERGohYXmsqyxEOuXDVeoCPY+OFvIY1aVu N68aQDKrQ0BQDJu10Vn/XdSD/sdjJPj5d8a8gcH5YU4Lf3uf2QjVH2UsSpQpo3IESnUM V1t5hQQ1aCPMNpfmP+47Y+zRKSvKZHiMMpk6FOKoJqgoltccL5n9ayqpiuuVzZdZNbui syaw== X-Gm-Message-State: AJIora9vHytQCgK7rDM7QF1Boc7r5CiOjhK+kHqcw1crl7+ogutIj7SR ak04Cb9v74Y9vmKKUmXF/asVvg== X-Google-Smtp-Source: AGRyM1vERWFgmHaTBD7rBeqykB1fv4baPNjmA2gRpPKZnB723Y/Vv8hdfTsEMQ8qMiw5Pg4MhxACvA== X-Received: by 2002:a05:6a00:1305:b0:512:ebab:3b20 with SMTP id j5-20020a056a00130500b00512ebab3b20mr5250523pfu.82.1656428371845; Tue, 28 Jun 2022 07:59:31 -0700 (PDT) Received: from localhost ([2408:8207:18da:2310:e153:cfbc:e790:5935]) by smtp.gmail.com with ESMTPSA id n67-20020a622746000000b005254eb7627fsm9557142pfn.203.2022.06.28.07.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 07:59:31 -0700 (PDT) Date: Tue, 28 Jun 2022 22:59:24 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, shy828301@gmail.com, willy@infradead.org, zokeefe@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/16] mm/huge_memory: use helper touch_pud in huge_pud_set_accessed Message-ID: References: <20220628132835.8925-1-linmiaohe@huawei.com> <20220628132835.8925-5-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220628132835.8925-5-linmiaohe@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656428373; a=rsa-sha256; cv=none; b=DvgaYPVpiJglS/zC+P82EqqpjbUtoftMHu2+SPr1OEOOmcnWFhRrCFvIGrv8MvNrmEAzkM 4eCNzNXuFXFGSeYUgfw8NPpvvt5nZnZ00GMOf2sKuJI1KPgJU9Uf56PpgRF/KKmLfNT+zZ xUJC48cBF0bHDSsf+s57V9fCklnpToM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Pobbbbzg; spf=pass (imf15.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656428373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QGQSSYQX10LNSqyvqRv+smUAZqnB+eZ8I09EE8BQPHc=; b=f3aqdoM5zARHqmbnelNunhYJJq6/zQjwLKY0IlwnhgZsOZVADUPPhYg8f1aiLS6sPkvjum 5DHRO9E9IunDCVSwkLdotSG7R6UyF4EvMa7O+wrxrf3ozyjyZRDZcElZfU0EWrqrADNRYK 6LU0AxVMPTEqqxVBZZH9pkV5WK71yAY= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B59A5A002C X-Rspam-User: X-Stat-Signature: 6sdtr5p9it8oqdp4nag1brpnapcz75og Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Pobbbbzg; spf=pass (imf15.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1656428372-775030 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 28, 2022 at 09:28:23PM +0800, Miaohe Lin wrote: > Use helper touch_pud to set pud accessed to simplify the code and improve > the readability. No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index f7164ef8b6e3..d55d5efa06c8 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1284,15 +1284,15 @@ int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm, > > #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD > static void touch_pud(struct vm_area_struct *vma, unsigned long addr, > - pud_t *pud, int flags) > + pud_t *pud, bool write) You have change the last parameter. Have you forgotten to update its user of follow_devmap_pud()? Thanks. > { > pud_t _pud; > > _pud = pud_mkyoung(*pud); > - if (flags & FOLL_WRITE) > + if (write) > _pud = pud_mkdirty(_pud); > if (pudp_set_access_flags(vma, addr & HPAGE_PUD_MASK, > - pud, _pud, flags & FOLL_WRITE)) > + pud, _pud, write)) > update_mmu_cache_pud(vma, addr, pud); > } > > @@ -1384,21 +1384,13 @@ int copy_huge_pud(struct mm_struct *dst_mm, struct mm_struct *src_mm, > > void huge_pud_set_accessed(struct vm_fault *vmf, pud_t orig_pud) > { > - pud_t entry; > - unsigned long haddr; > bool write = vmf->flags & FAULT_FLAG_WRITE; > > vmf->ptl = pud_lock(vmf->vma->vm_mm, vmf->pud); > if (unlikely(!pud_same(*vmf->pud, orig_pud))) > goto unlock; > > - entry = pud_mkyoung(orig_pud); > - if (write) > - entry = pud_mkdirty(entry); > - haddr = vmf->address & HPAGE_PUD_MASK; > - if (pudp_set_access_flags(vmf->vma, haddr, vmf->pud, entry, write)) > - update_mmu_cache_pud(vmf->vma, vmf->address, vmf->pud); > - > + touch_pud(vmf->vma, vmf->address, vmf->pud, write); > unlock: > spin_unlock(vmf->ptl); > } > -- > 2.23.0 > >