From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 767FCC43334 for ; Tue, 28 Jun 2022 03:03:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 056068E0003; Mon, 27 Jun 2022 23:03:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 005F18E0001; Mon, 27 Jun 2022 23:03:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E36C78E0003; Mon, 27 Jun 2022 23:03:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D05178E0001 for ; Mon, 27 Jun 2022 23:03:37 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9DE186110F for ; Tue, 28 Jun 2022 03:03:37 +0000 (UTC) X-FDA: 79626149274.07.142ED38 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 0B74340037 for ; Tue, 28 Jun 2022 03:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CuGJhLbS9IkE7VTbFjMhJYW2Xfxy5se8WnpHZFVzwbM=; b=iJ0t/LUzaOKaiqLAkTpQkf4M8d MdeoKwSr+5w6YVsKXop+K+FrAfjK7qmhiCVhVt8rHUFO9zVEVSTzWGC5uxA+5ZCNO4Hxz/KAtajRn SGndeL42gx0z4CxihZmkJUQKSfZbDqlePhHdAJ3/lqQVZuFpI5OrGPnAtmxnQzkW8GeXmVmE0r1uF kjwMTkkhLJ++4r/tHq4WG7pErEVklcDYnzr+mimN1rVKxINqQkatTbDj2n2U9nnXM6s6T5UTnzc29 aJELZ4oRb/5UAW3HeWh5jV9LQDXRJh9X7ZsKhMxVJsHsJ/qJmA63a62RfecrGuS2pVjYNmK3twAkJ e883mXLw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o61Vb-00Bv39-7y; Tue, 28 Jun 2022 03:03:23 +0000 Date: Tue, 28 Jun 2022 04:03:23 +0100 From: Matthew Wilcox To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] filemap: minor cleanup for filemap_write_and_wait_range Message-ID: References: <20220627132351.55680-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220627132351.55680-1-linmiaohe@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656385417; a=rsa-sha256; cv=none; b=TLy/nFOwqhym9dFfgo55FNCLhMu7JETssa622RduXiRYczcSGZL1rHOIhPLJnmYlKnC7qN LIu06qhjDbVZVBEm+tFSjdzJpy8oU/p+R6M8AtHKqGmmVti2hkIdlVkyzalvYD93VYbgg2 UVyaqsNyrJV+lVmJwZZndqsy3j/YjwA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="iJ0t/LUz"; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656385417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CuGJhLbS9IkE7VTbFjMhJYW2Xfxy5se8WnpHZFVzwbM=; b=xYYHvhX/U3I2eYEVaqftGw8XCOChwqzFdCW1zQNWwVgs9M7DgqkNQJthAcFlNCVN8gQQgp ODs8uOExk5IOx0lrt9F7jnAuDFs8Jz5Uhh5nSwM0fn5r9yNWvUTb0nJEvLoSacnm8KJLLW He2KxHRtbdgomZ31aoHUwuYk3SKmlJ0= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0B74340037 X-Rspam-User: X-Stat-Signature: muatb7dndaneam7q8aeesuyj711mq4pm Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="iJ0t/LUz"; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1656385415-945920 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 27, 2022 at 09:23:51PM +0800, Miaohe Lin wrote: > Restructure the logic in filemap_write_and_wait_range to simplify the code > and make it more consistent with file_write_and_wait_range. No functional > change intended. > > Signed-off-by: Miaohe Lin Looks OK to me at a quick glance. I'll look at it more closely next week when I'm back from holiday.