From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53132C43334 for ; Mon, 27 Jun 2022 16:22:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D96C18E0003; Mon, 27 Jun 2022 12:22:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D47118E0001; Mon, 27 Jun 2022 12:22:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE6E98E0003; Mon, 27 Jun 2022 12:22:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B1C698E0001 for ; Mon, 27 Jun 2022 12:22:51 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 793E434F43 for ; Mon, 27 Jun 2022 16:22:51 +0000 (UTC) X-FDA: 79624534542.13.DACB0C5 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf28.hostedemail.com (Postfix) with ESMTP id 276ACC0038 for ; Mon, 27 Jun 2022 16:22:51 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id 73-20020a17090a0fcf00b001eaee69f600so9946850pjz.1 for ; Mon, 27 Jun 2022 09:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=BseriqoiozT548bWf87kfEM21QE/lsC7Xh53iRBx2LmFdeNav386MocuZafko2ZdzZ JQe5ovxOhcstFhT8iCD21C825q81Za8C3tdgW13ebnSYPD7k8WHS3yPH0VHQSCGZnmQf FicGbHrtEuD0O3jI+Q4LIietAgpYwoWp5qedMxPLBADENHHnn+UkkXouxHyxDA/j0F9g moM6KAIDklQszHLohnncrg9SWHa8qDcecTbUS930nHP7JYFxSIbGRQKh+59wLE+AXy7E fCLhJT8SPzPCj5eph3yGYAVFqleuzS1aYTb4Me1axhRhNHXk+NS3u9/PAs9nbb1c6HO+ fcfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=vQoZcwj6jSbn1SasgMSW/iWnS8kO6/z+oHzwMKvVeWw8W6WsVn8Cet3+Wmnivxg/UB awwu1a+nRhjm4wC6fV1j7RVGHGRiCuPt0vxGemaoDj/2wUsoeibDo15FUOJOJtSbHecs sjDRbneX4FFF40AfSx6HYxL0Bwf/1C8MS9V/8Kq0Hx3/t6H2OB9H1aXvr2ZIT1XjvFF5 jbaF6e+JqEOnJvY4/u3J8Jc9diH9RmB+53nqpTStj8WI76UG+6HX+gdIse6eLmZnHL8r FUB6o37Hv1ZMyLsE6e4FoK2YGrKxMiTPBkCmwiBcNG95kQ13fp4a6bCldPuSAN3Lay6Q h6NQ== X-Gm-Message-State: AJIora9e4iP9AHZ77aeZwiuK6mWuGNY5+WBTzF4I/nDgRrJPcC10WG4q qSgZjt2JBhCGjIklSOJ1jBpz3Q== X-Google-Smtp-Source: AGRyM1v1/klo71FJcOnTZoW3zB85VLk+X/utjbZmu0W37du2cpFLJFufJZy1ShhykQNqxxTcsGcOvw== X-Received: by 2002:a17:902:e54f:b0:16a:29de:9603 with SMTP id n15-20020a170902e54f00b0016a29de9603mr15741779plf.46.1656346970060; Mon, 27 Jun 2022 09:22:50 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id o14-20020a17090a4e8e00b001e2bd411079sm9752135pjh.20.2022.06.27.09.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 09:22:49 -0700 (PDT) Date: Mon, 27 Jun 2022 16:22:46 +0000 From: Sean Christopherson To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats. Message-ID: References: <20220606222058.86688-1-yosryahmed@google.com> <20220606222058.86688-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606222058.86688-4-yosryahmed@google.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656346971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cV3hVzy9TYCqPFueATEq37SOh6vFTuLA/SrvAB62Xzg=; b=Rs934S/UmbkYCNM9f3ebarGIq9Usdm34WoKqlUGgKR95ddUDdo24/43vJ57qXlyVdCLOob 6BAPt2hY1PMatyzezMpZTZwzVGbFd2B1sB48agKKuRnH3k/J1ZYoBJEfmvjaGPRcXs7q0J gTGsNllWiDUEj0CMxJZGtFLG5x52K+8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656346971; a=rsa-sha256; cv=none; b=EGNFmHMnQHprc0QlmI3lz6zvUOLJMpkvPiHGFL1stIbe4+Y95CcMjB9JU6hxU7otkdbMOB rbvVq6p1Dv93nvtdVHPhsm3WWDHuOXdEzhy9TY2bQD4s7PA5/iee/AV8jSpoVDsC4v17D3 4iiPb8TafoopsTi8p/BnlehjZ95Tfco= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Bseriqoi; spf=pass (imf28.hostedemail.com: domain of seanjc@google.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Bseriqoi; spf=pass (imf28.hostedemail.com: domain of seanjc@google.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 276ACC0038 X-Stat-Signature: z4rroygwa4bgwhskk8nrw34c5s5mfya1 X-HE-Tag: 1656346970-349074 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 06, 2022, Yosry Ahmed wrote: > Count the pages used by KVM mmu on x86 for in secondary pagetable stats. "for in" is funky. And it's worth providing a brief explanation of what the secondary pagetable stats actually are. "secondary" is confusingly close to "second level pagetables", e.g. might be misconstrued as KVM counters for the number of stage-2 / two-dimension paging page (TDP) tables. Code looks good, though it needs a rebased on kvm/queue.