From: Christoph Hellwig <hch@infradead.org>
To: cgel.zte@gmail.com
Cc: viro@zeniv.linux.org.uk, hughd@google.com,
ran.xiaokai@zte.com.cn, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] drop caches: skip tmpfs and ramfs
Date: Sat, 25 Jun 2022 02:19:44 -0700 [thread overview]
Message-ID: <YrbTMJAuwY59CwRS@infradead.org> (raw)
In-Reply-To: <20220624182121.995294-1-ran.xiaokai@zte.com.cn>
On Fri, Jun 24, 2022 at 06:21:21PM +0000, cgel.zte@gmail.com wrote:
> From: Ran Xiaokai <ran.xiaokai@zte.com.cn>
>
> All tmpfs and ramfs pages have PG_dirty bit set
> once they are allocated and added to the pagecache。So pages
> can not be freed from tmpfs or ramfs. So skip tmpfs and ramfs
> when drop caches.
Hard coding magic constants in VFS code is a bad idea. If you have
numbers to justify this change (which should go into this commit log),
it can be properly solved by a flag on the super block,
file_system_type or even better bdi.
next prev parent reply other threads:[~2022-06-25 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 18:21 cgel.zte
2022-06-25 9:19 ` Christoph Hellwig [this message]
2022-06-25 9:31 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrbTMJAuwY59CwRS@infradead.org \
--to=hch@infradead.org \
--cc=cgel.zte@gmail.com \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ran.xiaokai@zte.com.cn \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox