From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F119C43334 for ; Fri, 24 Jun 2022 23:17:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 485CC8E0244; Fri, 24 Jun 2022 19:17:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4362B6B00EE; Fri, 24 Jun 2022 19:17:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6BD8E0244; Fri, 24 Jun 2022 19:17:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 17E386B00ED for ; Fri, 24 Jun 2022 19:17:25 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DD5C255C for ; Fri, 24 Jun 2022 23:17:24 +0000 (UTC) X-FDA: 79614692808.10.B44B402 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 4ECAD1C0022 for ; Fri, 24 Jun 2022 23:17:24 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3CBCB62325; Fri, 24 Jun 2022 23:17:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D5F4C34114; Fri, 24 Jun 2022 23:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656112642; bh=SRbeoCVoiP6sAFPfqupaswhL4ShhqUzJCFcbcVdT1ws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WasipiMD3gyvv8IhJSrx1zqYqylQVtMNii+iyRVfl/rJC9Q+8LGcF3wvYtYneavOB esoo5iPRq1xTCGkgbKkETprVcICaaACnkkLB6rY6EQ5zdn+fjcvSEwGMzn8qWG2fzm sVrHZISZSeo+DgynPlJ3YuKMNRzO6TPlFaPaO3d1L22HuOr4Q4BT2t50h5nPOaA8d9 +s3LEW6ofy8z9jNyNXcV10qtKwUi6a9cHzkbwwajvVQwpwup3UMtMPdIA6mSfg+L9G m7UXT840HdH3MXqH/pcQMKF3prpUJl5AAKEox9pZ1APA0KADGeM8cIhQq3wcRDd+Fx oWUgUTqYmwB+A== Date: Fri, 24 Jun 2022 16:17:20 -0700 From: Nathan Chancellor To: Matthew Wilcox Cc: Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org Subject: Re: Triggered assertion from "mm: Add an assertion that PG_private and folio->private are in sync" Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656112644; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Oubx8AQw13zrTBVBlzOlTrSpxQdvxuyCbpM+StqsRAg=; b=SjPomn83aF7+QvqAxC5n6+/NE8xuRlO70366MVOaq2PdRmKBhcKstU+NpeNTAraHYq+ztE mYB/MGsVpv/mIsNESbzjzc4B0YGU2leJtii3/ZCimLSBjduxVueT5Ej5TwiMTJfcSFQipb TeLQE1sCBk0VoGjbIDGpbTENZl82h8Y= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WasipiMD; spf=pass (imf20.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656112644; a=rsa-sha256; cv=none; b=Ch7auj1cDbNpFhQXbLYqcIMRiZCukytV1IcXER1YkbDdCxR7z1LZZrboxWhtyi6AAJiw8h 3/RWcmplV4lEuE/2Cfhe3siydttErpysTJSjGlXgG+HW3lflDaNir1MBaBWNS00Jo88cCg kzLD7k8al+nZPIVW2tKrsjprInx4vZI= Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WasipiMD; spf=pass (imf20.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: mzkfqnb1kgocuagxssotix3hghwoba8i X-Rspamd-Queue-Id: 4ECAD1C0022 X-HE-Tag: 1656112644-645484 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 25, 2022 at 12:11:22AM +0100, Matthew Wilcox wrote: > On Fri, Jun 24, 2022 at 02:58:28PM -0700, Nathan Chancellor wrote: > > Hi Matthew, > > > > I bisected a boot failure on one of my test machines to your commit > > c462f63731e0 ("mm: Add an assertion that PG_private and folio->private > > are in sync"), which landed in next-20220624. I didn't see this patch > > posted to any mailing list on lore, hence this separate thread; > > apologies if it was and I missed it. I didn't see this reported yet but > > I see the assertion triggered when systemd-zram-setup@zram0 runs: > > urgh, sorry about that. i really need to wean zsmalloc off using struct > page. i'll drop this patch; feel free to just revert it, there's nothing > that will depend on it. Ack, I'll do just that, thanks a lot for the quick reply! Cheers, Nathan