From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51BF6CCA47E for ; Fri, 24 Jun 2022 18:47:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B24A38E0265; Fri, 24 Jun 2022 14:47:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD36E8E0244; Fri, 24 Jun 2022 14:47:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99B9C8E0265; Fri, 24 Jun 2022 14:47:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 87B9A8E0244 for ; Fri, 24 Jun 2022 14:47:41 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4DE2F208CD for ; Fri, 24 Jun 2022 18:47:41 +0000 (UTC) X-FDA: 79614013122.08.682615E Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf11.hostedemail.com (Postfix) with ESMTP id CFC1C40021 for ; Fri, 24 Jun 2022 18:47:40 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id cv13so3570866pjb.4 for ; Fri, 24 Jun 2022 11:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EJ/rs91GRos3tFmq5ZNamdqFk2L/UuGhKzbbDsYJNtw=; b=qWB89vfGH1eZ6L6P3c9n1ivpU+TWzcjZSdX16pMXH01txP3FPQi+War7M31w2TLl34 whyL8MHkzoAU0mmpCh3PFDdDQsnc+wBI+sjdGrzYTFJO8O+ngSkuPWOZGG4k2qF5Ws8I JasJZAIdLjBWosATm3BqRJGTtWLCFv4HPGGEBa81Z8s01sfdW6ydIDagXAZH6y4mn+yP 9F/3KHbLswUuBDD5axQy7qtWFUlf9aXZKWRUhWkz71mfuOUphFJ5z0FeduDV4EfmkdJq jjHAGy9ENfKC6bOLcUv/tgitiur9wpENU0XPx/tYJDFgWoARzw6zRgiH27ZywOTfBusZ SRSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EJ/rs91GRos3tFmq5ZNamdqFk2L/UuGhKzbbDsYJNtw=; b=wsDGYBEdWn3hYv1GD4YH5SmXQqPhggsrKQnR/1K7x7n+09hiOfYC4U0p+hW9RvgCf3 M0G4x2woWGUYWOQiFnApjzA6LRcYjUYOiJF7wPTwm02WnoxTCkzlv6rcvF70GJCJdkiK XUyrjsUxRrFArsJja5Pest8EdpxNbQcVfo8W4Qvw98nUDDdRpM28XbDH3qTBtJEdW8Sa 00fyD2zV7HhMOBrAQ8mdFCKjPM806oEJecr1rIQ9zHmpeh0KB4JMb9K6WUz/xDzp7RRz Yl/lCJJLvFWk4kEYxA6N5PIkbfm2afXAQK2nks4vR6EMCgpt1O9+QgYHtuTNMIBvZaNN +UFA== X-Gm-Message-State: AJIora94Z+8gaVJ/yCfNindGr/F5UY7yKqqbPRKs8QuE92mCz3CZQSKO pHqgrHCLYmzbSAo1tJ42mMLIIA== X-Google-Smtp-Source: AGRyM1t+kwMdSiXf0Ks06lYZdaX+jlwhDvq3Ij1wXRalOpgZ6rqgALtYqLbFm7JPfgOMfj26ASZ2mQ== X-Received: by 2002:a17:903:245:b0:168:efbc:c10 with SMTP id j5-20020a170903024500b00168efbc0c10mr443245plh.71.1656096459617; Fri, 24 Jun 2022 11:47:39 -0700 (PDT) Received: from google.com (55.212.185.35.bc.googleusercontent.com. [35.185.212.55]) by smtp.gmail.com with ESMTPSA id 142-20020a621494000000b0052285857864sm2121661pfu.97.2022.06.24.11.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 11:47:38 -0700 (PDT) Date: Fri, 24 Jun 2022 11:47:34 -0700 From: Zach O'Keefe To: Miaohe Lin Cc: akpm@linux-foundation.org, shy828301@gmail.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/16] mm/huge_memory: fix comment of __pud_trans_huge_lock Message-ID: References: <20220622170627.19786-1-linmiaohe@huawei.com> <20220622170627.19786-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622170627.19786-4-linmiaohe@huawei.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656096460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EJ/rs91GRos3tFmq5ZNamdqFk2L/UuGhKzbbDsYJNtw=; b=qPdfzGPaUqYKwrqPkSKWzshoVxWfaYFifBhT9yesqZB3WWKPNURErOHsyIIEXCVAQTLiA6 34VXN2x2fciewfmBiZCQGcUnXHdZAc7WWBRP90YVsIvUHr+XD8zchQFczJwXW0ujFDE/8z TahTfE9kpBRo/mFtE+f718Yp9qwwVCo= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qWB89vfG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=zokeefe@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656096460; a=rsa-sha256; cv=none; b=qb6JlRaz6PU0dICqVVw6zmRJNPmKIn7BUeybr7vtU0TO5wWihF641DmuJjWsKd3+yYVu0R P0tRoOOUWdSG4EpRIqFacsxjohxNLu3eiq4cUpnzWN6Bgje0QtzP/L4bctdGV4edEuKLcw rz/ufbKgNlZmkfcK3cRQ1RjeUnOOyPI= X-Rspamd-Queue-Id: CFC1C40021 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qWB89vfG; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=zokeefe@google.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qog8sg6ynptcbqdzmm9rpkmjkjkhtorq X-HE-Tag: 1656096460-699256 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23 Jun 01:06, Miaohe Lin wrote: > __pud_trans_huge_lock returns page table lock pointer if a given pud maps > a thp instead of 'true' since introduced. Fix corresponding comments. > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 83fb6c3442ff..a26580da8011 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1903,10 +1903,10 @@ spinlock_t *__pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma) > } > > /* > - * Returns true if a given pud maps a thp, false otherwise. > + * Returns page table lock pointer if a given pud maps a thp, NULL otherwise. > * > - * Note that if it returns true, this routine returns without unlocking page > - * table lock. So callers must unlock it. > + * Note that if it returns page table lock pointe, this routine returns without s/pointe/pointer > + * unlocking page table lock. So callers must unlock it. > */ > spinlock_t *__pud_trans_huge_lock(pud_t *pud, struct vm_area_struct *vma) > { > -- > 2.23.0 >