From: Zach O'Keefe <zokeefe@google.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Miaohe Lin <linmiaohe@huawei.com>,
akpm@linux-foundation.org, shy828301@gmail.com,
willy@infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/16] mm/huge_memory: use flush_pmd_tlb_range in move_huge_pmd
Date: Fri, 24 Jun 2022 11:32:55 -0700 [thread overview]
Message-ID: <YrYDVzT48IhLhwKQ@google.com> (raw)
In-Reply-To: <YrQInzK5g/NJMmSA@FVFYT0MHHV2J.usts.net>
On 23 Jun 14:30, Muchun Song wrote:
> On Thu, Jun 23, 2022 at 01:06:12AM +0800, Miaohe Lin wrote:
> > ARCHes with special requirements for evicting THP backing TLB entries can
> > implement flush_pmd_tlb_range. Otherwise also, it can help optimize TLB
> > flush in THP regime. Using flush_pmd_tlb_range to take advantage of this
> > in move_huge_pmd.
> >
> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>
> LGTM.
>
> Reviewed-by: Muchun Song <songmuchun@bytedace.com>
Reviewed-by: Zach O'Keefe <zokeefe@google.com>
next prev parent reply other threads:[~2022-06-24 18:33 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 17:06 [PATCH 00/16] A few cleanup patches for huge_memory Miaohe Lin
2022-06-22 17:06 ` [PATCH 01/16] mm/huge_memory: use flush_pmd_tlb_range in move_huge_pmd Miaohe Lin
2022-06-23 6:30 ` Muchun Song
2022-06-24 18:32 ` Zach O'Keefe [this message]
2022-06-22 17:06 ` [PATCH 02/16] mm/huge_memory: access vm_page_prot with READ_ONCE in remove_migration_pmd Miaohe Lin
2022-06-23 3:14 ` Kirill A. Shutemov
2022-06-23 12:03 ` Miaohe Lin
2022-06-24 18:40 ` Zach O'Keefe
2022-06-25 3:17 ` Miaohe Lin
2022-06-22 17:06 ` [PATCH 03/16] mm/huge_memory: fix comment of __pud_trans_huge_lock Miaohe Lin
2022-06-23 6:32 ` Muchun Song
2022-06-24 18:47 ` Zach O'Keefe
2022-06-25 3:33 ` Miaohe Lin
2022-06-24 18:56 ` Matthew Wilcox
2022-06-25 3:32 ` Miaohe Lin
2022-06-22 17:06 ` [PATCH 04/16] mm/huge_memory: use helper touch_pud in huge_pud_set_accessed Miaohe Lin
2022-06-23 6:42 ` Muchun Song
2022-06-23 12:08 ` Miaohe Lin
2022-06-22 17:06 ` [PATCH 05/16] mm/huge_memory: use helper touch_pmd in huge_pmd_set_accessed Miaohe Lin
2022-06-23 6:43 ` Muchun Song
2022-06-22 17:06 ` [PATCH 06/16] mm/huge_memory: rename mmun_start to haddr in remove_migration_pmd Miaohe Lin
2022-06-23 6:46 ` Muchun Song
2022-06-22 17:06 ` [PATCH 07/16] mm/huge_memory: minor cleanup for split_huge_pages_pid Miaohe Lin
2022-06-23 3:22 ` Kirill A. Shutemov
2022-06-23 12:07 ` Miaohe Lin
2022-06-22 17:06 ` [PATCH 08/16] mm/huge_memory: use helper macro __ATTR_RW Miaohe Lin
2022-06-23 6:49 ` Muchun Song
2022-06-22 17:06 ` [PATCH 09/16] mm/huge_memory: fix comment in zap_huge_pud Miaohe Lin
2022-06-22 17:06 ` [PATCH 10/16] mm/huge_memory: check pmd_present first in is_huge_zero_pmd Miaohe Lin
2022-06-23 6:59 ` Muchun Song
2022-06-22 17:06 ` [PATCH 11/16] mm/huge_memory: try to free subpage in swapcache when possible Miaohe Lin
2022-06-22 17:06 ` [PATCH 12/16] mm/huge_memory: minor cleanup for split_huge_pages_all Miaohe Lin
2022-06-22 17:06 ` [PATCH 13/16] mm/huge_memory: add helper __get_deferred_split_queue Miaohe Lin
2022-06-23 7:03 ` Muchun Song
2022-06-23 12:11 ` Miaohe Lin
2022-06-22 17:06 ` [PATCH 14/16] mm/huge_memory: fix comment of page_deferred_list Miaohe Lin
2022-06-23 7:24 ` Muchun Song
2022-06-23 12:26 ` Miaohe Lin
2022-06-24 17:09 ` Zach O'Keefe
2022-06-25 3:18 ` Miaohe Lin
2022-06-22 17:06 ` [PATCH 15/16] mm/huge_memory: correct comment of prep_transhuge_page Miaohe Lin
2022-06-23 7:26 ` Muchun Song
2022-06-22 17:06 ` [PATCH 16/16] mm/huge_memory: comment the subtle logic in __split_huge_pmd Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrYDVzT48IhLhwKQ@google.com \
--to=zokeefe@google.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox