From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1174CC43334 for ; Fri, 24 Jun 2022 15:26:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A6C98E022F; Fri, 24 Jun 2022 11:26:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 556328E020E; Fri, 24 Jun 2022 11:26:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4456D8E022F; Fri, 24 Jun 2022 11:26:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 357798E020E for ; Fri, 24 Jun 2022 11:26:48 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 144172060B for ; Fri, 24 Jun 2022 15:26:48 +0000 (UTC) X-FDA: 79613506896.18.DDC7096 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by imf26.hostedemail.com (Postfix) with ESMTP id 6542614001F for ; Fri, 24 Jun 2022 15:26:47 +0000 (UTC) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 6894C1C000A; Fri, 24 Jun 2022 15:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656084405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cOBna43ZB0lJCDekpVEqf7GVrwOErW7lnHWKCAFoDIg=; b=VIeBbMouu4FRIkCnML49qgRcF+vMECewXOrt2LsveUbMwYzLoZV83L0rJtnBz1noP2j03E IBxv5QWf0a4wVWi990MihCbQvPsjeLNwONphIbUivuA4IW4mlLiGMc+tJJi1kYOj7EjynR 3VdI+xTP7u0Pz10bcayLH6mo0edU+NJwkHcfGku0Eyik8FZRIp2k81i+/ee7H4CS49UXzx Z4dOBD7G+mjJuBlKza7OVSaQ2v+AMu9j3BKJjxSh7jHhkOxL/3JBZJKgBq3Ijs9x+Pp+U/ BpdQ1+QutoMfiAdcyKDvLc3usPeHUkBgIKyvkdI77hpr3+X8NIgvRpE21SYyuw== Date: Fri, 24 Jun 2022 17:26:44 +0200 From: Paul Kocialkowski To: Julia Lawall Cc: kbuild-all@lists.01.org, lkp@intel.com, Linux Memory Management List , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: fix device_node_continue.cocci warnings (fwd) Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j8s6M7Kf9VxwIgM8" Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=bootlin.com header.s=gm1 header.b=VIeBbMou; dmarc=pass (policy=reject) header.from=bootlin.com; spf=pass (imf26.hostedemail.com: domain of paul.kocialkowski@bootlin.com designates 217.70.183.197 as permitted sender) smtp.mailfrom=paul.kocialkowski@bootlin.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656084407; a=rsa-sha256; cv=none; b=rblptEzsg7LEMj7gEBiU6kk5BxjgRFwd0hii9yaDsJ5FIvUNiGmkA96KcBpyCDyMZajxtI qd9rEbG3x+a+2YDo2Led9OjkwY4rHFot5R8hOmW/8JR647rJ3zBFXtOOGN1e4chm2BEqb1 w903EhacnbsHXxnwtCETO3EWZrxFUVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656084407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cOBna43ZB0lJCDekpVEqf7GVrwOErW7lnHWKCAFoDIg=; b=KsmnSu3H03hJ3v7pe6a+GfVRg5U1nUapbtmuO5qoclIiniZoO/3U0wIpBHirT0OcVYLGrU j79fD0Ywbf0uCXW4slMdzHU+mSOnLPpS7y81/+36cpmEQEtAxhZ1SqLCvfd5L6XhpErxEK PWn1wMtkdnjwlhLiB1o29ch1yCCF368= X-Stat-Signature: caz6ttcbkw66k47cxquoewu61uwzicm5 X-Rspamd-Server: rspam08 X-Rspam-User: X-Rspamd-Queue-Id: 6542614001F Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bootlin.com header.s=gm1 header.b=VIeBbMou; dmarc=pass (policy=reject) header.from=bootlin.com; spf=pass (imf26.hostedemail.com: domain of paul.kocialkowski@bootlin.com designates 217.70.183.197 as permitted sender) smtp.mailfrom=paul.kocialkowski@bootlin.com X-HE-Tag: 1656084407-630041 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --j8s6M7Kf9VxwIgM8 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri 24 Jun 22, 17:08, Paul Kocialkowski wrote: > Hi Julia, >=20 > On Sun 12 Jun 22, 13:02, Julia Lawall wrote: > > The of_node_put does not seem to be needed. Note that there is none at > > the preceeding continues. >=20 > That looks like a correct fix, thanks! Pushed to drm-misc-next, thanks! Paul > > julia > >=20 > > ---------- Forwarded message ---------- > > Date: Sat, 11 Jun 2022 06:02:45 +0800 > > From: kernel test robot > > To: kbuild@lists.01.org > > Cc: lkp@intel.com, Julia Lawall > > Subject: [PATCH] drm: fix device_node_continue.cocci warnings > >=20 > > CC: kbuild-all@lists.01.org > > BCC: lkp@intel.com > > CC: Linux Memory Management List > > TO: Paul Kocialkowski > > CC: Maxime Ripard > > CC: David Airlie > > CC: Daniel Vetter > > CC: dri-devel@lists.freedesktop.org > > CC: linux-kernel@vger.kernel.org > >=20 > > From: kernel test robot > >=20 > > drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable doubl= e put. > >=20 > > Device node iterators put the previous value of the index variable, so= an > > explicit put causes a double put. > >=20 > > Generated by: scripts/coccinelle/iterators/device_node_continue.cocci > >=20 > > Reported-by: kernel test robot > > Signed-off-by: kernel test robot > > --- > >=20 > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= =2Egit master > > head: 6d0c806803170f120f8cb97b321de7bd89d3a791 > > commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add s= upport for the LogiCVC display controller > > :::::: branch date: 17 hours ago > > :::::: commit date: 31 hours ago > >=20 > > Please take the patch only if it's a positive warning. Thanks! > >=20 > > drivers/gpu/drm/logicvc/logicvc_layer.c | 2 -- > > 1 file changed, 2 deletions(-) > >=20 > > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c > > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c > > @@ -612,8 +612,6 @@ int logicvc_layers_init(struct logicvc_d > > ret =3D logicvc_layer_init(logicvc, layer_node, index); > > if (ret) > > goto error; > > - > > - of_node_put(layer_node); > > } > >=20 > > of_node_put(layers_node); >=20 > --=20 > Paul Kocialkowski, Bootlin > Embedded Linux and kernel engineering > https://bootlin.com --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --j8s6M7Kf9VxwIgM8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK117MACgkQ3cLmz3+f v9GFUwf/az5hyKfcTdyQcgK2Hh4Cjqq2ZHdkl8bUbiYalB83GruGXqXVrp5DZ2+v sIg19Ssgv1GMiTAvVZuT8EqHpZPcoPQceVKyFp4S7EmBmxctiyTq7/3FBGZPf8i3 FO2hGK3lbgfL0ur+sUuPugzW8/iUWg2AsWuuzGvEJaTtZmOURPSgJrdgrQrCJK4Q AO4PGOvd8lqC/yqFokvr/XFFnOpm3qF2jdOUJpQ0/n3heMLYHnGmY5XC7VD2LmNf wAVKcakylgPhpDTrbx//lZ6Q1SW/UiWsnexGIIjvBRd4tU+j07A6eQqPx+f1UmsA 9VVviBqMk2ytHuOAOHBjNx+34d/S4Q== =0QdG -----END PGP SIGNATURE----- --j8s6M7Kf9VxwIgM8--