From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD604C433EF for ; Fri, 24 Jun 2022 15:08:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21E788E022D; Fri, 24 Jun 2022 11:08:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CD308E020E; Fri, 24 Jun 2022 11:08:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 095938E022D; Fri, 24 Jun 2022 11:08:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EEE8A8E020E for ; Fri, 24 Jun 2022 11:08:23 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C977761621 for ; Fri, 24 Jun 2022 15:08:23 +0000 (UTC) X-FDA: 79613460486.20.8028B45 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by imf12.hostedemail.com (Postfix) with ESMTP id 1E8B94001D for ; Fri, 24 Jun 2022 15:08:22 +0000 (UTC) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 5DD7D200008; Fri, 24 Jun 2022 15:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656083301; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z6NSlrVRFRynl/P9uRgQINLcwfmlxyYneaSXB7ysLYI=; b=Il3PR66ADF+iXcu0f6Y9QZbVVK0mLk607IPrgZ3yxISVfVlAZyhsbsHWmHgao2qboQBjgC RbZwc0uDuaXiw+OiZwtEEQZpuN6jxg6IkYbuLAsoSiHqEy5cmZYQOMwniCui7B/Sc9fVTW 7h30PPUZby1ko42o3pwI7JOTTNL5Mbj4ikyANydgmg5cWmvBFHVE2q+hd1I3dRoUQcZmDy lmV4Nxo78cL1GimRz4SCg2lDUAbUIBQ7x0U5zdt/SYNF7shGypnS//QufV/IZsYfriZ1dO iTx2RD3NK5w0dIPDkOZ2tubNnHvLdi69LSRdinq8Nb8sZw3tbX2bp1VysKS8sw== Date: Fri, 24 Jun 2022 17:08:19 +0200 From: Paul Kocialkowski To: Julia Lawall Cc: kbuild-all@lists.01.org, lkp@intel.com, Linux Memory Management List , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: fix device_node_continue.cocci warnings (fwd) Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wLn5nGH9z1X1MW5b" Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=bootlin.com header.s=gm1 header.b=Il3PR66A; spf=pass (imf12.hostedemail.com: domain of paul.kocialkowski@bootlin.com designates 217.70.178.232 as permitted sender) smtp.mailfrom=paul.kocialkowski@bootlin.com; dmarc=pass (policy=reject) header.from=bootlin.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656083303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z6NSlrVRFRynl/P9uRgQINLcwfmlxyYneaSXB7ysLYI=; b=Ksa6nGxldmU684Vns/qyONTeFOvuf1FbNb99UlkFvtEl+3yJBJs0Wv1jwQln/mYkMnBSSO 90IXxIbiYNakFgX1ZgsLP5/5GddQC8M6FyeCCHJTYfXAhe0tPKPJnOvCqlO8bvLPYuNuJe i9iTvCDJGTZksksz1saDtihYta1bryM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656083303; a=rsa-sha256; cv=none; b=LhmnG9yL5NLbqzuWjcxidRigAtiQJ9fTLYyRLUoDhWo9VKGUQ8BMGRXLGDdG5B5+VQDrK8 sAalbgvoIR0WyJ15qu00h6hdJ6HXbGLZ3lH4+aEeTczjHmvg39dKWibJ1nzCw9ZMcSaakf YyLyLv+mKIIer9xAATKS/0JL3gzOLe4= X-Stat-Signature: xj5bjfar9n9crxdhddz6gpa59bcttgsd X-Rspamd-Queue-Id: 1E8B94001D X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=bootlin.com header.s=gm1 header.b=Il3PR66A; spf=pass (imf12.hostedemail.com: domain of paul.kocialkowski@bootlin.com designates 217.70.178.232 as permitted sender) smtp.mailfrom=paul.kocialkowski@bootlin.com; dmarc=pass (policy=reject) header.from=bootlin.com X-Rspamd-Server: rspam02 X-HE-Tag: 1656083302-785086 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --wLn5nGH9z1X1MW5b Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Julia, On Sun 12 Jun 22, 13:02, Julia Lawall wrote: > The of_node_put does not seem to be needed. Note that there is none at > the preceeding continues. That looks like a correct fix, thanks! Paul =20 > julia >=20 > ---------- Forwarded message ---------- > Date: Sat, 11 Jun 2022 06:02:45 +0800 > From: kernel test robot > To: kbuild@lists.01.org > Cc: lkp@intel.com, Julia Lawall > Subject: [PATCH] drm: fix device_node_continue.cocci warnings >=20 > CC: kbuild-all@lists.01.org > BCC: lkp@intel.com > CC: Linux Memory Management List > TO: Paul Kocialkowski > CC: Maxime Ripard > CC: David Airlie > CC: Daniel Vetter > CC: dri-devel@lists.freedesktop.org > CC: linux-kernel@vger.kernel.org >=20 > From: kernel test robot >=20 > drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double = put. >=20 > Device node iterators put the previous value of the index variable, so an > explicit put causes a double put. >=20 > Generated by: scripts/coccinelle/iterators/device_node_continue.cocci >=20 > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- >=20 > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 6d0c806803170f120f8cb97b321de7bd89d3a791 > commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add sup= port for the LogiCVC display controller > :::::: branch date: 17 hours ago > :::::: commit date: 31 hours ago >=20 > Please take the patch only if it's a positive warning. Thanks! >=20 > drivers/gpu/drm/logicvc/logicvc_layer.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c > @@ -612,8 +612,6 @@ int logicvc_layers_init(struct logicvc_d > ret =3D logicvc_layer_init(logicvc, layer_node, index); > if (ret) > goto error; > - > - of_node_put(layer_node); > } >=20 > of_node_put(layers_node); --=20 Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com --wLn5nGH9z1X1MW5b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEJZpWjZeIetVBefti3cLmz3+fv9EFAmK102MACgkQ3cLmz3+f v9H80wf+IWSsArK5aJYsP0w7K00FEbqtnEBvifJqcDGhGEgugYMyCDYVJI6Y29Qn EKexL7vlrZUIrHSz/XUXnucgUplWrIt1cr4l1IWSdypaYqONSIdnmVPGOxebhjTs UCJf7WtnFPLSndVLOhGvPa03MXG3c4LrZnLWMl+jWLHBEWeycRAFcIVV69veKb8e Cxm8OIh9SnqgXxv51JWJ3Gs+M38/vuCdWiaoSHqteHpa2b+8a6XeCgmoUgPhDLqk zdkNgSyomugvg/wBv0HsypWzO40/xb2c7bJ1qEV5oTxUCfkSeTH0MAHa8FD8jgN1 0m5Ua77B7Yw0sZt09WkP+M/njhyHIw== =IADY -----END PGP SIGNATURE----- --wLn5nGH9z1X1MW5b--