From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 474C5C43334 for ; Thu, 23 Jun 2022 17:03:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A16848E0165; Thu, 23 Jun 2022 13:03:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C7058E0144; Thu, 23 Jun 2022 13:03:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88DD88E0165; Thu, 23 Jun 2022 13:03:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 793738E0144 for ; Thu, 23 Jun 2022 13:03:14 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 474B42100D for ; Thu, 23 Jun 2022 17:03:14 +0000 (UTC) X-FDA: 79610121108.20.77ED3D3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id B5830400B7 for ; Thu, 23 Jun 2022 17:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UenEwcIN0CvVMMXweP0TWmC7AzLiwOHffKvm7rzsvxY=; b=F60jZ0DijvM0NLeHfLyAZLtO8B cbCSSryf/ZJyUOWsnEtUCDNiwnf8r9kSJNUJoyCOh8/JSjMgZzxWLo2l8nGB+M4V1I64oCbTL8pnG YD/LZs6YKE1Yq40e61dXoVn75QKBz2bsGHtBJwGqalXEPQiKoj5XIahiSxsGOtj/k+nMhmgwTgWW8 7XwYtcrrkIvSvlYu8Los43W1fSgc4MBXDNne0L/6KVVUHONYps1CLTuGkbV4Wx+68AKR3hm6oXagi 2hq7ITECWkzRHY60cGknvOTokRIsGqq0J+1DfEUZQyyIppBLROpiJW5iXocE8Cjnn9GKnJfD8B5kj 0+LhjxVw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4QER-0081dP-VH; Thu, 23 Jun 2022 17:03:03 +0000 Date: Thu, 23 Jun 2022 18:03:03 +0100 From: Matthew Wilcox To: David Hildenbrand Cc: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "damon @ lists . linux . dev" , SeongJae Park Subject: Re: [PATCH v10 09/69] mm: add VMA iterator Message-ID: References: <20220621204632.3370049-1-Liam.Howlett@oracle.com> <20220621204632.3370049-10-Liam.Howlett@oracle.com> <20192b57-30de-1426-6694-238e018104eb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20192b57-30de-1426-6694-238e018104eb@redhat.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656003793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UenEwcIN0CvVMMXweP0TWmC7AzLiwOHffKvm7rzsvxY=; b=2Zg2PeMIfpc8/8OyYI0WtJnZfnRDXBLSINAE1Q7u0qvDr9eXhLfmzK03RAL60/wt09S4+U r5cwqspeVnZf81JCY1me788qbIVj5NlmahuhckbFWiqdXIhTO1D88faCgbF32nhXypqqCO myeaDrmiSQ6PpO0bXKzqT+s3/oY6dRk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=F60jZ0Di; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656003793; a=rsa-sha256; cv=none; b=edNF4rWd5zhCGCRjr4P7NM6eVgP5dKtrVNNW+mSoZDgQMEso3T9qcOwXMJDpPQqV2RG7Qu fgn6yR00aH7pMokOpxFBnilBVEoV9cRLNBHEyMDuYm/AOhjvQZYRcm94voio6J6w+1w8SF duAkjCmKiEXrL0Z4OaUaGJdDUVMqJjU= X-Rspamd-Queue-Id: B5830400B7 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=F60jZ0Di; dmarc=none; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 8zycdrkr6ybw3ygeyqu8u8fq475yfxsw X-HE-Tag: 1656003792-374231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 21, 2022 at 11:10:09PM +0200, David Hildenbrand wrote: > > +#define VMA_ITERATOR(name, mm, addr) \ > > + struct vma_iterator name = { \ > > + .mas = { \ > > + .tree = &mm->mm_mt, \ > > + .index = addr, \ > > + .node = MAS_START, \ > > + }, \ > > + } > > + > > No __* and () macro magic? > > I'd have expected at least > > tree = &(__mm)->mm_mt, > .index = (__addr), > > ;) Fair, fair. Just testing that change now. I always forget to do those things until they bite me. > Reviewed-by: David Hildenbrand Appreciate the review! diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index acbd8d03e01e..8bcbffefdc02 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -686,11 +686,11 @@ struct vma_iterator { struct ma_state mas; }; -#define VMA_ITERATOR(name, mm, addr) \ +#define VMA_ITERATOR(name, _mm, _addr) \ struct vma_iterator name = { \ .mas = { \ - .tree = &mm->mm_mt, \ - .index = addr, \ + .tree = &(_mm)->mm_mt, \ + .index = (_addr), \ .node = MAS_START, \ }, \ }