From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF957C43334 for ; Thu, 23 Jun 2022 16:37:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68B568E0160; Thu, 23 Jun 2022 12:37:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63ABC8E0144; Thu, 23 Jun 2022 12:37:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5030B8E0160; Thu, 23 Jun 2022 12:37:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 42A658E0144 for ; Thu, 23 Jun 2022 12:37:06 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1A8B4A61 for ; Thu, 23 Jun 2022 16:37:06 +0000 (UTC) X-FDA: 79610055252.20.88B02AC Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf06.hostedemail.com (Postfix) with ESMTP id 861E7180031 for ; Thu, 23 Jun 2022 16:37:05 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 404BF1F38C; Thu, 23 Jun 2022 16:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656002224; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xjy8SPQ+d5ER4berxN3l8OR04THIzep3YipbQ/OBM0g=; b=Ew+9Nb9MszfcKz8/CBOy/vbT3LdyWXYXJmxRGKgwX44dyVrdqLUM2gHRY/sEx6UyjnRIDM XzKj749fNM/8KrvLqqDkVWcOjsXB8hvCCVPr2RXCWZIpa/zrlE67nFC15urvWI1xAa1OjU AnLic47l3onMcYVNv9L25O3PWNX0d3c= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 6AD542C197; Thu, 23 Jun 2022 16:37:03 +0000 (UTC) Date: Thu, 23 Jun 2022 18:37:02 +0200 From: Michal Hocko To: Yosry Ahmed Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Matthew Wilcox , Vlastimil Babka , David Hildenbrand , Miaohe Lin , NeilBrown , Alistair Popple , Suren Baghdasaryan , Peter Xu , Linux Kernel Mailing List , Cgroups , Linux-MM Subject: Re: [PATCH] mm: vmpressure: don't count userspace-induced reclaim as memory pressure Message-ID: References: <20220623000530.1194226-1-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656002225; a=rsa-sha256; cv=none; b=K4qSQ5eanBZFh4Bi/2kF8HKgo1fgt0ZZGn7YxtjGaTYNIKWUyBVbsvw7FR8ZWsxKZDs2Hn D5yXMH2LZImM6jZaRh7dVwRaESwZnBu8uRoKepNLrzhV9r0iiI9DDgIpuK1bbG5bdPgrHS jclx5wmFLA9Kpx0tbdho08DOKdNVweE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Ew+9Nb9M; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656002225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xjy8SPQ+d5ER4berxN3l8OR04THIzep3YipbQ/OBM0g=; b=R9d68Fd5svzma3wMOHowumxihv8/xh5Yc/kqmpGXiyCpJqbX0CN1CtxR3cmuavR5sKWsk/ 1bmTysXrv1JB4smq7nNUd9PzNJh0FkNniYMHK+7ofcMd/laUWD+gzpXLZ6RtcpReCXAG9f Fj/pcpb7vrdFSLJju+UXUZ/RyGOEcoM= X-Rspamd-Queue-Id: 861E7180031 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Ew+9Nb9M; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam08 X-Stat-Signature: 6ktp8ke5jemq5f5ze1hwdo6ox7xrt6tn X-HE-Tag: 1656002225-583025 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 23-06-22 09:22:35, Yosry Ahmed wrote: > On Thu, Jun 23, 2022 at 2:43 AM Michal Hocko wrote: > > > > On Thu 23-06-22 01:35:59, Yosry Ahmed wrote: [...] > > > In our internal version of memory.reclaim that we recently upstreamed, > > > we do not account vmpressure during proactive reclaim (similar to how > > > psi is handled upstream). We want to make sure this behavior also > > > exists in the upstream version so that consolidating them does not > > > break our users who rely on vmpressure and will start seeing increased > > > pressure due to proactive reclaim. > > > > These are good reasons to have this patch in your tree. But why is this > > patch benefitial for the upstream kernel? It clearly adds some code and > > some special casing which will add a maintenance overhead. > > It is not just Google, any existing vmpressure users will start seeing > false pressure notifications with memory.reclaim. The main goal of the > patch is to make sure memory.reclaim does not break pre-existing users > of vmpressure, and doing it in a way that is consistent with psi makes > sense. memory.reclaim is v2 only feature which doesn't have vmpressure interface. So I do not see how pre-existing users of the upstream kernel can see any breakage. -- Michal Hocko SUSE Labs