From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92401C433EF for ; Thu, 23 Jun 2022 13:28:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09E7F8E0151; Thu, 23 Jun 2022 09:28:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04E568E0144; Thu, 23 Jun 2022 09:28:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7F238E0151; Thu, 23 Jun 2022 09:28:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DB50E8E0144 for ; Thu, 23 Jun 2022 09:28:49 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B6B62606FF for ; Thu, 23 Jun 2022 13:28:49 +0000 (UTC) X-FDA: 79609580778.27.401D48A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 68FB38002F for ; Thu, 23 Jun 2022 13:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1QLhXNXQq+r3hNERezeB41wLtAhbEfpWTSG6Y6DdYeU=; b=QvjDTMvbet4svpj2PO0DW7TArw IVfhGKCjFkBSadPRkxM4lGwZlXrkCbtJ/SaeKJZGi12prlTbSd4hgxXgQp6Tb9vJLi3PDaRCjTOak rnbrjlV/DcuzK2F2SrJAPyLWnH04HotuXNVqza/lj/vtVrmTDg/rAQxlwcPwjvHJZpbolbNXuPG2b cHR51iP44Y0WOegMxiTrEoHNBAX9PKqdruY3i94RpN1Fa86hKwTaeYkWkxAuGOACEFZQiqXYv8V7V rbOFh+I5g9AaNPrNxXy2d17jeFB2ZUjWPgU/zPSddC5VtLgp9MrSS0Mnq/Z2WU+ZnphXQ5NAyLdNC i5a2To6Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o4Msw-007tUb-RU; Thu, 23 Jun 2022 13:28:39 +0000 Date: Thu, 23 Jun 2022 14:28:38 +0100 From: Matthew Wilcox To: Mike Rapoport Cc: Baolin Wang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 2/3] mm: Add PUD level pagetable account Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655990929; a=rsa-sha256; cv=none; b=NPT8WI9xt/0h3+kmaoc9KfHqFEYB451Nb4qvEN3+scpLcoMA23dUCPs7zPiZ9hQ2aJicvl +HBBHU9kWLkt2HjJuLKBzH+eXqeyhZSQnZgv+f/eRicYm9mc4odH68F3VNHh8hZs8lxEf3 ig2xADy9XpYY9nTdVRfk75vJBtl7zjM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QvjDTMvb; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655990929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1QLhXNXQq+r3hNERezeB41wLtAhbEfpWTSG6Y6DdYeU=; b=OHGoYlvr33nn4t+yFFcpErXXQcHUvAlk8zUTpZe5PLJyPOJ4C0j0QZ3LOkYlRKbFlI48LW v4yx4/SuWk0yxYt3R5JaGtXllbT8C+NvuUyUF3Aop3F8EX3Z/W2rpIzpJyBJM5y7GKa/75 cA//9QJgaQoINHr/HZuI6nIVgH5KZEM= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 68FB38002F Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=QvjDTMvb; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: dep1n86dru83we8j6x8iqp4c6fgh7nr8 X-Rspam-User: X-HE-Tag: 1655990928-725094 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 22, 2022 at 09:38:30AM -0500, Mike Rapoport wrote: > On Wed, Jun 22, 2022 at 04:58:53PM +0800, Baolin Wang wrote: > > +++ b/arch/loongarch/include/asm/pgalloc.h > > @@ -89,10 +89,15 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address) > > static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address) > > { > > pud_t *pud; > > + struct page *pg; > > struct page *page; > > looks better IMO. > > > + > > + pg = alloc_pages(GFP_KERNEL & ~__GFP_HIGHMEM, PUD_ORDER); GFP_KERNEL does not include __GFP_HIGHMEM, so you can just use GFP_KERNEL here. > > + if (!pg) > > + return NULL; > > > > - pud = (pud_t *) __get_free_pages(GFP_KERNEL, PUD_ORDER); > > - if (pud) > > - pud_init((unsigned long)pud, (unsigned long)invalid_pmd_table); > > + pgtable_set_and_inc(pg); > > + pud = (pud_t *)page_address(pg); > > I don't think __get_free_pages() should be replaced with alloc_pages() > here, just call pgtable_set_and_inc() with virt_to_page(pud). I don't understand why you want that. Take a look at the implementation of __get_free_pages(). Converting back to a struct page after calling that seems like a real waste of time to me.