From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1AE4C43334 for ; Thu, 23 Jun 2022 07:24:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D8C48E0135; Thu, 23 Jun 2022 03:24:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 063AC8E0115; Thu, 23 Jun 2022 03:24:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E45688E0135; Thu, 23 Jun 2022 03:24:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CF1BC8E0115 for ; Thu, 23 Jun 2022 03:24:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9E90335190 for ; Thu, 23 Jun 2022 07:24:47 +0000 (UTC) X-FDA: 79608663414.28.21AFE37 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf29.hostedemail.com (Postfix) with ESMTP id 80B4C12001A for ; Thu, 23 Jun 2022 07:24:46 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id 68so12903276pgb.10 for ; Thu, 23 Jun 2022 00:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=V5L4PYUq7nG6vsd/zKr6FHtwDpXOar+I+aRnKcea838=; b=kXnFiHXa8TfbhLaMlCxOnGvwSY1BU6I6mhJuUdTkuMY9AVdnY5ptmMhB0vPFKJ8q1e oeV4dy0l5AyDTMINIDamw0z6GkG9CJoxtgHgPilt/agLUww5AtIOjvskZJTF+Qw7pSxq oHvp3L1DI8fxl1Je77Q06fQ6owNZRmWGZp1p7JcLsG9y3iUkYbmYFW2IEE7XRsMUpjwO BT/XKHiOgLeeuzlgnLkcPjsix24yFVhDWNzm3AUUV2JyfGyIMpDTsh53ukBfaxFQesvh mzlxIpYVpFei1lEKY1RSz2wMLwT5XFnQavOvwCM0wFHrFAeXHtryf57zXd2v8ktOVA/d 64Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=V5L4PYUq7nG6vsd/zKr6FHtwDpXOar+I+aRnKcea838=; b=hQbr8NhhtDuJJUK7gBW72tCurL9+vcUklL4F8apKtg8FfFFWfeNRJEmbDqsbw4bASK 2+zqJ8Fmh59CdtR7RoswA4mjScd8gDdap+e3GgKoXG53Kc8V6ocWK7HGsGiNFOBMZ5di WJ5oyNvd+C7MT5KXF7XFQhdQymO58qZleQSjmRhmZs8u3gkF8hGa57hgUbbsn+mgv+fo rh7mblbdloyQWdYafdmvcy/A9haE2PYClFMaBcSMH3GiHg6S9XGsIi+Zvi2mZ63Qk6aN mVgE04WrC987WhkkSTjbJIjEN1sE6pU2nEqsed2YHFYGd6SHk2G/ys92EPaqQFhtZcnf WIwg== X-Gm-Message-State: AJIora/Ks+EgAQykBGf2xUa8Bi8XPnXm/7LQW+2kn7xLkEoh/GdcmvNM HnvgPBHmc5rnlp1epdO//7hpfS44UVZdjEcN X-Google-Smtp-Source: AGRyM1vzWMhRzAyKQlpGmkzpvA1HBBNwz/FpzCynSYCcP0SEwuq6velzl0QHHGixxYDzMhOnqowOAA== X-Received: by 2002:a63:b54d:0:b0:40c:5917:964b with SMTP id u13-20020a63b54d000000b0040c5917964bmr6478993pgo.241.1655969085368; Thu, 23 Jun 2022 00:24:45 -0700 (PDT) Received: from localhost ([139.177.225.231]) by smtp.gmail.com with ESMTPSA id p188-20020a62d0c5000000b005251fc16ff8sm8664853pfg.220.2022.06.23.00.24.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 00:24:45 -0700 (PDT) Date: Thu, 23 Jun 2022 15:24:41 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, shy828301@gmail.com, willy@infradead.org, zokeefe@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/16] mm/huge_memory: fix comment of page_deferred_list Message-ID: References: <20220622170627.19786-1-linmiaohe@huawei.com> <20220622170627.19786-15-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622170627.19786-15-linmiaohe@huawei.com> ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=kXnFiHXa; spf=pass (imf29.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655969087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V5L4PYUq7nG6vsd/zKr6FHtwDpXOar+I+aRnKcea838=; b=cMcUH5q56JJY6p9b9GHOnuxFAcCkbycjXP5wi8S7dVuI/gzM7n44C66ceWjR/np3QZn9tn WRg9SJhrqmllLAf0LirYJ4lKhSz5edGT+bRGV4ExYHOkEMmDWiqMXpmFbJOqXCypUYc9pq mCg9Ic0BzFjRro5RBBx4DAbEHyX5W7w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655969087; a=rsa-sha256; cv=none; b=X8llcxnLfF9jyqoVKCQRSD2YME4VXV8yvVFVvMlIyAZT/c+y8CFHAJ3BcCFIkRw8T1viFu Xi+KxBs7PGCCVka/JO9du84KiZwkWLKxmpZO555kETnfpbad+DbB305X5lNtcVhW0CsBIy JtGBY8zm0unwjAvFYY49oF21xWumtIs= X-Stat-Signature: wqh6o5xnfdadkcqhx5r1wckstmhnimzx X-Rspam-User: X-Rspamd-Server: rspam07 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=kXnFiHXa; spf=pass (imf29.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Queue-Id: 80B4C12001A X-HE-Tag: 1655969086-929587 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 23, 2022 at 01:06:25AM +0800, Miaohe Lin wrote: > The current comment is confusing because if global or memcg deferred list > in the second tail page is occupied by compound_head, why we still use > page[2].deferred_list here? I think it wants to say that Global or memcg > deferred list in the first tail page is occupied by compound_mapcount and > compound_pincount so we use the second tail page's deferred_list instead. > > Signed-off-by: Miaohe Lin > --- > include/linux/huge_mm.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 12b297f9951d..2e8062b3417a 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -294,8 +294,8 @@ static inline bool thp_migration_supported(void) > static inline struct list_head *page_deferred_list(struct page *page) > { > /* > - * Global or memcg deferred list in the second tail pages is > - * occupied by compound_head. > + * Global or memcg deferred list in the first tail page is > + * occupied by compound_mapcount and compound_pincount. > */ The structure of "struct page" seems to have told us the information that we resue the 2nd tail page to be used as deferred_list. I am not sure the value of those comments. Maybe better to remove them? Thanks. > return &page[2].deferred_list; > } > -- > 2.23.0 > >