From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48024C433EF for ; Thu, 23 Jun 2022 06:43:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8D6F8E012F; Thu, 23 Jun 2022 02:43:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3E208E0115; Thu, 23 Jun 2022 02:43:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9065B8E012F; Thu, 23 Jun 2022 02:43:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 802308E0115 for ; Thu, 23 Jun 2022 02:43:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 59D3360A9C for ; Thu, 23 Jun 2022 06:43:40 +0000 (UTC) X-FDA: 79608559800.08.B4ED790 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf24.hostedemail.com (Postfix) with ESMTP id 0D6C018009A for ; Thu, 23 Jun 2022 06:43:39 +0000 (UTC) Received: by mail-pf1-f181.google.com with SMTP id 128so11202506pfv.12 for ; Wed, 22 Jun 2022 23:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3UJEMTPzICNyXJBehr6tcsfAkHd0uy9Otb6Hy7fSQ2Y=; b=FDEIVzEhQN053Y0VryB4nr6XSAhB+0gOt1XsRAGHLt0l/Pcc/ww/n2lTSCbzxLPjuL d/D8ZtZql76W58xHMIVifgqqEteewDrFyu/YkE7D1TzLtutyqetmeDynhe791vKraHCO 5XC8m6RoWEelQFzveoi5Yli4C1mCLapGXcmI4v+6YxvuW1QMnXF7U66V1VAqVrAmqOHH G+clEZTAA4PZLwG702YD0jaWJW+ejbg4Nts12Vy4oU4etVg/zBadbi7gz0hPh01m1gKA hD7ry2zhPXIC6FlLyOwTyZILDlO+7CQEaKwHiABkvSUqr9u+EvMkAXJiokfl0ZParnUP a86A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3UJEMTPzICNyXJBehr6tcsfAkHd0uy9Otb6Hy7fSQ2Y=; b=kVr1EbtIsYhSUcx6IfZfvFBN/JmLB9JF7lwEO1EL/lAfP1UuQPNSrdZYbzReA5Q89J 4N4GitCBsAbTDviKop4YpYwlIBUFoUJfoPK+oz/r5G5gyOhFIyW6joFnc8nYzO1U+i3t 9+Ljvt2mop4sACtcAY6iGFJ2INtKpLuBMmUbGuL9rt6FRBida6J9miTY6jmwWDHe2Otc YpOt0xhksA+LP1d4KTt89+oDrA+R0o37bsMd3nrQ/YRCzcJQb77+t7zMgPxrJxRti9AD Gi1yNMHLpGDWUDjW7P8gFcWXef0AYWB6TbYQSashc6w6uPQ5uXdidlbtqJZDHyU4M2n1 GWpw== X-Gm-Message-State: AJIora/9aWWnmD6EUMevM+rgq+EDg6l8RNfF2QtmQnHXnujByXm7VCSt w5SYrKB74bpK9AeNBzz5vfeCLQ== X-Google-Smtp-Source: AGRyM1vyV9N2CWpKeg83xNnRcJDfQQjNlH8Emh1YmXsVLwSuJNvyUOkwX2CDOA2UyCBgZtdDlwdgHw== X-Received: by 2002:a05:6a00:10d4:b0:522:8c31:ec23 with SMTP id d20-20020a056a0010d400b005228c31ec23mr39708842pfu.67.1655966619110; Wed, 22 Jun 2022 23:43:39 -0700 (PDT) Received: from localhost ([139.177.225.231]) by smtp.gmail.com with ESMTPSA id n2-20020a63b442000000b003c265b7d4f6sm14489743pgu.44.2022.06.22.23.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 23:43:38 -0700 (PDT) Date: Thu, 23 Jun 2022 14:43:35 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, shy828301@gmail.com, willy@infradead.org, zokeefe@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/16] mm/huge_memory: use helper touch_pmd in huge_pmd_set_accessed Message-ID: References: <20220622170627.19786-1-linmiaohe@huawei.com> <20220622170627.19786-6-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622170627.19786-6-linmiaohe@huawei.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655966620; a=rsa-sha256; cv=none; b=lTtS7sJtkLQSaCfzfSseYwufVh83LmEwa558RmHuUUu4srVyqB3RT9Uy1jp+uM4nmXPXqw 31ALcoHhkZjr/vnzFb+iGacBs9vcP3iHJcTf5MSx4xP9YWOwjErBlHpfyZPG3Zs9CVlOHn 9LQClxSDNBCTjIPDg4zRhluNGF/eW8o= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=FDEIVzEh; spf=pass (imf24.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655966620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3UJEMTPzICNyXJBehr6tcsfAkHd0uy9Otb6Hy7fSQ2Y=; b=fcIrJ14hVIFyArrsJZqzcFnWCtcgiJgQyQfKy13FYpzW24/ot6suLXH6jWnlqWBcBF3S/d 5Uezb+tdklYN7QYwpwKZVETNvYQZwc7Rb8Kk+gyVt7aFpfW2POsksagCr11P9zYdPRjpWz B5JQn1/IlFss6wr7U5Jj79L+XJDYb+Q= X-Stat-Signature: fduk7f76ycob7m3uj1onqjanwddhy5dg X-Rspamd-Server: rspam06 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=FDEIVzEh; spf=pass (imf24.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Rspamd-Queue-Id: 0D6C018009A X-HE-Tag: 1655966619-716110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 23, 2022 at 01:06:16AM +0800, Miaohe Lin wrote: > Use helper touch_pmd to set pmd accessed to simplify the code and improve > the readability. No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index a0c0e4bf9c1e..c6302fe6704b 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1297,21 +1297,15 @@ void huge_pud_set_accessed(struct vm_fault *vmf, pud_t orig_pud) > > void huge_pmd_set_accessed(struct vm_fault *vmf) > { > - pmd_t entry; > - unsigned long haddr; > - bool write = vmf->flags & FAULT_FLAG_WRITE; > - pmd_t orig_pmd = vmf->orig_pmd; > + int flags = 0; > > vmf->ptl = pmd_lock(vmf->vma->vm_mm, vmf->pmd); > - if (unlikely(!pmd_same(*vmf->pmd, orig_pmd))) > + if (unlikely(!pmd_same(*vmf->pmd, vmf->orig_pmd))) > goto unlock; > > - entry = pmd_mkyoung(orig_pmd); > - if (write) > - entry = pmd_mkdirty(entry); > - haddr = vmf->address & HPAGE_PMD_MASK; > - if (pmdp_set_access_flags(vmf->vma, haddr, vmf->pmd, entry, write)) > - update_mmu_cache_pmd(vmf->vma, vmf->address, vmf->pmd); > + if (vmf->flags & FAULT_FLAG_WRITE) > + flags = FOLL_WRITE; Same suggestion as mentioned in previous thread. Thanks. > + touch_pmd(vmf->vma, vmf->address, vmf->pmd, flags); > > unlock: > spin_unlock(vmf->ptl); > -- > 2.23.0 > >