From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81310C43334 for ; Thu, 23 Jun 2022 06:42:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C91D8E012E; Thu, 23 Jun 2022 02:42:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07A7B8E0115; Thu, 23 Jun 2022 02:42:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E84BB8E012E; Thu, 23 Jun 2022 02:42:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D728C8E0115 for ; Thu, 23 Jun 2022 02:42:51 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A64F8214FD for ; Thu, 23 Jun 2022 06:42:51 +0000 (UTC) X-FDA: 79608557742.12.73D6A6A Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf08.hostedemail.com (Postfix) with ESMTP id 56BBA16000E for ; Thu, 23 Jun 2022 06:42:49 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id i15so17336750plr.1 for ; Wed, 22 Jun 2022 23:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=N3ow0jtBMSvR3R34hcnXm0q43de+Gwul4lTzzrZTcJY=; b=rlwEtMsxo+oU8UIJmenkkg+4D3jPsqrDZooGmwn2WODx+SmhSuUWLckmk75rZa+Tx4 Kv9aCR0T3VE2PwY1RIjVyavr9Qhwko5DO0D6CwuLvoREZO8TfSmvnqpQBgn514FxvDG9 8amCnf1k8Q/XJfcb8YE10NJqfkzKOyaEoQqCwsYMkG8UhF++ufFTbZw3lx4DLUedd1z8 +xxWT4Gq97cYxM3Oc9u0W9WWziF17seNE9Xvqzu/ul78dfjWEXomcM6fkSRU8bwZu4OI zr8iCkn5e3crcuj/Kf8UnrssYxAfZaGTPN6prvbMuvKY/nn0TDpkKu+Pi3XNzWMG1DpB LiOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=N3ow0jtBMSvR3R34hcnXm0q43de+Gwul4lTzzrZTcJY=; b=ez/zglUcd8BusfkkLvDVC/4nM5V4DLFxDSr2LRq49ncnNsxoDFubdSZsjfGGX6wWxJ ySYQLseOQKcpnrQEEYZ5u+4aF6SbpOS3yd0lkLTk80lfNYdEnJ3lgmtWqcIe8wPZ9QXc f0MAdTy0+eoGK4dFxsHQQ538uzWWZu4V+dXEAHxJeH8/EP41ve8RKpQOa8bAFkWIuCGd DEgYAHzP/b4dkI4kyeY4MlfWA0lnwWWwiBjar0l/DOpbA52pt8f8Igpgkpegpa8/T50G Oh+stevrF66YVbfPEJ0q05PqZawBP3PCoE8OIlFSvYxZw/8yH+xWpNLNjO5tidaW3001 neMQ== X-Gm-Message-State: AJIora+oS/GCJa4LjYxM6AELx0A7lBhu6yThl0cXd8KKhiZRmesNV7hn knD1PEk9ZKbLQIuNQyqEl3g5Aw== X-Google-Smtp-Source: AGRyM1smMJdtzur3J3fWQHD8V8DVUbiuPVwNyia43HDDD58JdeVt4HmJEpFrt9aOh076iY8FZT3Ihg== X-Received: by 2002:a17:90b:1d90:b0:1e8:5a98:d591 with SMTP id pf16-20020a17090b1d9000b001e85a98d591mr2448827pjb.126.1655966568198; Wed, 22 Jun 2022 23:42:48 -0700 (PDT) Received: from localhost ([139.177.225.231]) by smtp.gmail.com with ESMTPSA id a2-20020a631a02000000b0040d548ab090sm566560pga.32.2022.06.22.23.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 23:42:47 -0700 (PDT) Date: Thu, 23 Jun 2022 14:42:43 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, shy828301@gmail.com, willy@infradead.org, zokeefe@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/16] mm/huge_memory: use helper touch_pud in huge_pud_set_accessed Message-ID: References: <20220622170627.19786-1-linmiaohe@huawei.com> <20220622170627.19786-5-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220622170627.19786-5-linmiaohe@huawei.com> ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=rlwEtMsx; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf08.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655966571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N3ow0jtBMSvR3R34hcnXm0q43de+Gwul4lTzzrZTcJY=; b=t4Lv4D3X3EMspXqeRzTNrx2WDtq3iKfc2spTGG9cFnTnFmGmo4N8XjPy5z0Qx9xYyByJC9 aiy7/fBklxhdeN6oovoYGYOUL7JjFQDxH0JyFMjnLFozMiSRSpOHjcQ6whUBV0hKoWAthx eXii8MjsLXbfgWSzYg6wGwBVLpSKKws= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655966571; a=rsa-sha256; cv=none; b=7LjHOBdWW+kLl5RRpxQBlWMDn/Zw/jRsGOroMi5gV7YqyWPgIWewQ/uCQqy0Ic5Irvh1xP /1bR9NntTRKJ6fyZ+3cYySs2kbM/dTfglJxbyR2yCNMXHJ7Na9qRrTAxzYlezKgoOu7pA6 du2DyzDItGrB+ioXZy/vZW7hsP618+U= X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=rlwEtMsx; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf08.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: 69s6h1aizm1g31k4rmogxekfq1h3jzjy X-Rspamd-Queue-Id: 56BBA16000E X-Rspamd-Server: rspam12 X-HE-Tag: 1655966569-29399 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 23, 2022 at 01:06:15AM +0800, Miaohe Lin wrote: > Use helper touch_pud to set pud accessed to simplify the code and improve > the readability. No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index a26580da8011..a0c0e4bf9c1e 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1281,21 +1281,15 @@ int copy_huge_pud(struct mm_struct *dst_mm, struct mm_struct *src_mm, > > void huge_pud_set_accessed(struct vm_fault *vmf, pud_t orig_pud) > { > - pud_t entry; > - unsigned long haddr; > - bool write = vmf->flags & FAULT_FLAG_WRITE; > + int flags = 0; > > vmf->ptl = pud_lock(vmf->vma->vm_mm, vmf->pud); > if (unlikely(!pud_same(*vmf->pud, orig_pud))) > goto unlock; > > - entry = pud_mkyoung(orig_pud); > - if (write) > - entry = pud_mkdirty(entry); > - haddr = vmf->address & HPAGE_PUD_MASK; > - if (pudp_set_access_flags(vmf->vma, haddr, vmf->pud, entry, write)) > - update_mmu_cache_pud(vmf->vma, vmf->address, vmf->pud); > - > + if (vmf->flags & FAULT_FLAG_WRITE) > + flags = FOLL_WRITE; FOLL_* flags are used for follow_page(). But huge_pud_set_accessed() is used in mm fault path. It is a little weird to me to use FOLL_WRITE here. I suggest replace the last parameter of touch_pud() to "bool writable", then passing "vmf->flags & FAULT_FLAG_WRITE" to it instead of converting from FAULT_FLAG* flag to FOLL* flag. Thanks. > + touch_pud(vmf->vma, vmf->address, vmf->pud, flags); > unlock: > spin_unlock(vmf->ptl); > } > -- > 2.23.0 > >