From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12304C433EF for ; Thu, 23 Jun 2022 04:45:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DB248E0122; Thu, 23 Jun 2022 00:45:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88B2B8E0115; Thu, 23 Jun 2022 00:45:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 754358E0122; Thu, 23 Jun 2022 00:45:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6285F8E0115 for ; Thu, 23 Jun 2022 00:45:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 318D212130C for ; Thu, 23 Jun 2022 04:45:39 +0000 (UTC) X-FDA: 79608262398.17.E25A3DE Received: from mail-oa1-f67.google.com (mail-oa1-f67.google.com [209.85.160.67]) by imf21.hostedemail.com (Postfix) with ESMTP id ABCC01C0002 for ; Thu, 23 Jun 2022 04:45:38 +0000 (UTC) Received: by mail-oa1-f67.google.com with SMTP id 586e51a60fabf-101dc639636so15380179fac.6 for ; Wed, 22 Jun 2022 21:45:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=N1eJjql1DS+4tUOmOmPQ3Sdf7SzV4qJ6k25MmxMxIlo=; b=A9PtieinnX1oh4Vt1n8jWdSiJuHpdYC04CNgpVBHL0s4sf9I2w6qbUGmITInydmuw7 zhHDVED7Eq+9AkR1C6UZBa0laJGpqE2krzx8aBUbxPRNrke9UFIHWvbi01pdHWT6jnwJ Upq87K+McYK8bxHrwmN5cX30wB4wYen5DRLXJs6o/qnFG8QHyKWuQW/fjVh1xtk9TX6x KkUB0Jqw6lsdLwoNt9nNP+WHV+Px5jNQl6VAvgyAy3OAfCIdg6xS1B/ctLaw5WjBQrf0 0JEXBvyWNMq4lzvB37kBbFheMRlNHtd+hiqpawJsFPOrEmcdMw7FeXxUEXVX7/KtC1PM M9RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=N1eJjql1DS+4tUOmOmPQ3Sdf7SzV4qJ6k25MmxMxIlo=; b=ymTpdK+Ds2sduKflZ0sR4C7MgYHwiLqolkCLP2s+g1EoGOjJ/xHz3kpRmYpwSaM7Xo LVzaBVc66QvrADQXDFcVa3ziAsyV6r6t3RCV5T5PVB934YTlmLhW5jMuIN0+82xfwsPt DjtsTCqBvg73NFYtbFKt3+X9Hz3qtastuHj5KQzwhB6AjNaI6U71FuLD19R/EQd+D5Cz Z2eOnh5dZfpPFxOzA7FgmwTYkXeIEEumZ9YKI0rkA0r4Y9HFvpqR95qn/u0NKK3impEA d0kuK/i2EbR4EeDUDlfVk0JzpBJiPY4LMz61w8ojTGx3eKdeTCXO/4a35KuYPfayGASR 8mlQ== X-Gm-Message-State: AJIora99eTuca/omEIeBKTqy1hCM2Wr5whQKiLGdP2v4WvLq3E/cTCEn rSn8oBt7LJW1P3BDALJBcKA= X-Google-Smtp-Source: AGRyM1txdBUeGkwFzvXCQfQ6+abOTYupkMvGUjrSYlrhD2Bjp+E/d6mJjfbvXMq9dWx7EBW2cz9M+w== X-Received: by 2002:a05:6870:6c15:b0:106:919c:80df with SMTP id na21-20020a0568706c1500b00106919c80dfmr1274546oab.111.1655959537968; Wed, 22 Jun 2022 21:45:37 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id 79-20020a9d0bd5000000b0060afaae0e34sm12243064oth.0.2022.06.22.21.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 21:45:37 -0700 (PDT) Date: Wed, 22 Jun 2022 23:45:36 -0500 From: Rebecca Mckeever To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v3 1/4] memblock tests: add user-provided arguments to Makefile Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655959538; a=rsa-sha256; cv=none; b=tiMlBEsit/xiG96mgSsUqvK5c+4K/N4ObM0E/a123kH0kTIuYWVNLrfNnGzUCbAfbd0JdT MyDzhYPUsi9ghsaoPIA7ruaciPJSXuTy3+3jiv4X5Rc0XTS0HcHHCW/G+XngoxLh1IBI3N hoEzfIkijyPV11iMXUWKgRG84JiCnSE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=A9Ptiein; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.67 as permitted sender) smtp.mailfrom=remckee0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655959538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N1eJjql1DS+4tUOmOmPQ3Sdf7SzV4qJ6k25MmxMxIlo=; b=CmjrCm9e0h+q+Yma0yX+j5wNLAu33ync9nJwgvrMVQ8E2VvMsdWAceo6ZXIuXDuu+Ax4no Twqprws7du9BvBc0Z3sPJnazCG8TXxIjuXBmZdVikRbBzrAM+CDhmZvjOC/bm7NrFjUnqR zwZ9bfBmfIlTTrrUDax6+YroybgWOFw= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: ABCC01C0002 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=A9Ptiein; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of remckee0@gmail.com designates 209.85.160.67 as permitted sender) smtp.mailfrom=remckee0@gmail.com X-Stat-Signature: m3j4duoxgp8ir41i4h1oaboj49zt7xy6 X-Rspam-User: X-HE-Tag: 1655959538-704075 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On Wed, Jun 22, 2022 at 10:47:55PM -0500, Mike Rapoport wrote: > Hi Rebecca, > > On Wed, Jun 22, 2022 at 04:29:06AM -0500, Rebecca Mckeever wrote: > > > > Subject: memblock tests: add user-provided arguments to Makefile > > Please be more specific here, e.g. > > memblock tests: Makefile: add arguments to control verbosity > Should I also mention debug messages, or does verbosity refer to both arguments? > > Add VERBOSE and MEMBLOCK_DEBUG user-provided arguments. VERBOSE will > > enable verbose output from Memblock simulator. MEMBLOCK_DEBUG will enable > > memblock_dbg() messages. > > > > Update the help message to include VERBOSE and MEMBLOCK_DEBUG. Update > > the README to include VERBOSE. The README does not include all available > > options and refers to the help message for the remaining options. > > Therefore, omit MEMBLOCK_DEBUG from README. > > > > Reviewed-by: David Hildenbrand > > Signed-off-by: Rebecca Mckeever > > --- > > tools/testing/memblock/Makefile | 4 ++++ > > tools/testing/memblock/README | 10 +++++++++- > > tools/testing/memblock/scripts/Makefile.include | 10 ++++++++++ > > 3 files changed, 23 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/memblock/Makefile b/tools/testing/memblock/Makefile > > index a698e24b35e7..9fde49ad73bd 100644 > > --- a/tools/testing/memblock/Makefile > > +++ b/tools/testing/memblock/Makefile > > @@ -45,6 +45,10 @@ help: > > @echo ' clean - Remove generated files and symlinks in the directory' > > @echo '' > > @echo 'Configuration:' > > + @echo ' make VERBOSE=1 - enable verbose output, which includes the' > > + @echo ' names of functions being tested and the' > > + @echo ' number of test cases passing' > > + @echo ' make MEMBLOCK_DEBUG=1 - enable memblock_dbg() messages' > > @echo ' make NUMA=1 - simulate enabled NUMA' > > @echo ' make MOVABLE_NODE=1 - override `movable_node_is_enabled`' > > @echo ' definition to simulate movable NUMA nodes' > > diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README > > index ca6afcff013a..058146b528a5 100644 > > --- a/tools/testing/memblock/README > > +++ b/tools/testing/memblock/README > > @@ -34,7 +34,15 @@ To run the tests, build the main target and run it: > > $ make && ./main > > > > A successful run produces no output. It is also possible to override different > > -configuration parameters. For example, to simulate enabled NUMA, use: > > +configuration parameters. For example, to include verbose output, specify the > > +VERBOSE flag when building the main target: > > + > > +$ make VERBOSE=1 > > + > > +This will print information about which functions are being tested and the > > +number of test cases that passed. > > + > > +To simulate enabled NUMA, use: > > > > $ make NUMA=1 > > > > diff --git a/tools/testing/memblock/scripts/Makefile.include b/tools/testing/memblock/scripts/Makefile.include > > index 641569ccb7b0..4401f79bed4c 100644 > > --- a/tools/testing/memblock/scripts/Makefile.include > > +++ b/tools/testing/memblock/scripts/Makefile.include > > @@ -17,3 +17,13 @@ ifeq ($(32BIT_PHYS_ADDR_T), 1) > > CFLAGS += -m32 -U CONFIG_PHYS_ADDR_T_64BIT > > LDFLAGS += -m32 > > endif > > + > > +# Enable verbose testing output > > +ifeq ($(VERBOSE), 1) > > + CFLAGS += -D VERBOSE > > +endif > > + > > +# Enable memblock_dbg() messages > > +ifeq ($(MEMBLOCK_DEBUG), 1) > > + CFLAGS += -D MEMBLOCK_DEBUG > > +endif > > -- > > 2.34.1 > > > > -- > Sincerely yours, > Mike. Thanks, Rebecca