From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 749F1C43334 for ; Thu, 23 Jun 2022 04:20:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF0CF8E011F; Thu, 23 Jun 2022 00:20:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA35C8E0115; Thu, 23 Jun 2022 00:20:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B68FA8E011F; Thu, 23 Jun 2022 00:20:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A221B8E0115 for ; Thu, 23 Jun 2022 00:20:15 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 74B5335653 for ; Thu, 23 Jun 2022 04:20:15 +0000 (UTC) X-FDA: 79608198390.29.A296E71 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf06.hostedemail.com (Postfix) with ESMTP id 02E0E180009 for ; Thu, 23 Jun 2022 04:20:14 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id u9so23801089oiv.12 for ; Wed, 22 Jun 2022 21:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=mTdDyLbh8tP6o7Q+FLGKTGG6l09vUb5zEGBwzqDGc4Y=; b=URrd01aPjkPLzZ+FUPVluh3B9wHkVdfFgRToHXuZheiWFUv+m4z7a6jU9QbE7Y2NRw 2n8OJuMkGQk+Uon/H5b1Yim7U8i1uipI8DhfJxx8bzavq7QLWgq1eI5UurJvDeCdDyBt znIxEWHZTND5vdiaoD9ufsJEFetTQU/AhdGX3Yu/qk3md8ByEPC/QYneIQXGi/B8vJ0F 9arl/Cc76b+zJX10jnKh7ffHoUAzdeqySZ2Z5A5Hud1ZK8vxo9qiOIN59Y8rMqVQeIqB 1oyXOl1u+DWre1Xg0egdCgLB1Kholq1edpbCV0EXeXN4aRIJ0hatik8+i53M2yRXRbrX WyYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mTdDyLbh8tP6o7Q+FLGKTGG6l09vUb5zEGBwzqDGc4Y=; b=Ye8RvnIy8MdgFY2j1T3B37zbJ+bU50x7kxOa24FCgBVyKwZeECrC5hNMeom3/1t3FD DExIJ8TEkP54ZiEDw/D1keoI1S9SUlfhnxJgxOjd7thjskjaZICsE6B/embj08fAGFiu 1PLnDyAIPY8JgbxpmV2P7H2jIxMxB47TQUwE3jw4y9RR5D4TiFhv2IXcS/8GgcOWLgXH 8zhsZ+4WnRmu4WavjgoAGdf4StJk37anv+c6e5L2hRxHbqwsO2CaIlH00/mvtSjVcZQc jBkihglrE8tZTbdkLdTSf9vGNGG74LQJvEZCI6/I5YaRBWNQcwgAE+AIpldFDd0UMojF 9zVA== X-Gm-Message-State: AJIora/sd928PBaZ8GWL2TwL0TWfZs1jtP9ojwpJbg7f3nFx8cg29RD2 Ubd10L8RwXDGtZe7L4rYVak= X-Google-Smtp-Source: AGRyM1s2b5Dok077072a1KKGCHrG/ui/nHrguWh4T9QOsw8X8BBakGLhoYiE0l1vUu+BDXSJ2bHlTQ== X-Received: by 2002:aca:674b:0:b0:333:2014:9d6e with SMTP id b11-20020aca674b000000b0033320149d6emr1074143oiy.169.1655958014189; Wed, 22 Jun 2022 21:20:14 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id ep36-20020a056870a9a400b000f886139c51sm12482737oab.53.2022.06.22.21.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 21:20:13 -0700 (PDT) Date: Wed, 22 Jun 2022 23:20:11 -0500 From: Rebecca Mckeever To: Ira Weiny Cc: Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v3 0/4] memblock tests: add VERBOSE and MEMBLOCK_DEBUG Makefile options Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655958015; a=rsa-sha256; cv=none; b=hiSji0t9dCj43gOTDSV9uWVclWeDpitcDztoJM614Ld43XaqpmBLOSXdhcYxqg7TRGH3Zn caxpHyubBTpWwYWK8EsrLG0Lv2dh8L8TkuMaCrcuiBTNtFgi0MaC6qEvXbrigmJb2+WjMQ LmCnj7oQSz+o3YwmoILK/gZw41JmERg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=URrd01aP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.196 as permitted sender) smtp.mailfrom=remckee0@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655958015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mTdDyLbh8tP6o7Q+FLGKTGG6l09vUb5zEGBwzqDGc4Y=; b=WmGg6tbCjvzgb1wBHNkHvrNrMfXVChajsd3Q6tJtH0FTMDLuHONDqVelKucyyAzEJQf9wl Q+WOXvuFV48qlceAr3I69MBm1GA80r7Cu+0FEVd6SXb1b9ebpPJr6zgInYQ77qZc6/jRP8 P+bG3wVZZNGgww45Imb/0VDphS1OR+U= X-Rspamd-Queue-Id: 02E0E180009 X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=URrd01aP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.196 as permitted sender) smtp.mailfrom=remckee0@gmail.com X-Rspamd-Server: rspam03 X-Stat-Signature: ef5jpbx8yjsfowf5u15ie3qn75aidpni X-HE-Tag: 1655958014-876047 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 22, 2022 at 08:30:36PM -0700, Ira Weiny wrote: > On Wed, Jun 22, 2022 at 04:29:05AM -0500, Rebecca Mckeever wrote: > > These patches add options VERBOSE and MEMBLOCK_DEBUG to Memblock > > simulator, which can be specified when running make. These patches also > > implement the functionality for these options. > > I seem to be missing patch 3/4 and I don't see it on lore? > > https://lore.kernel.org/linux-mm/004e021cc3cb7be8749361b3b1cb324459b9cb9f.1655889641.git.remckee0@gmail.com/ > > Did it get sent? Did it define the ASSERT_*() macros? That's strange, my email shows that it was sent to linux-mm@kvack.org and linux-kernel@vger.kernel.org but I'm not seeing it on lore either. Should I resend just patch 3/4? For now, you can take a look at v1. Patch 3 is unchanged from v1, which is showing up on lore: https://lore.kernel.org/linux-mm/fe34452209f54287023ccacd666eade81ecd9a24.1655878337.git.remckee0@gmail.com/T/#u It does not define the ASSERT_*() macros, that happens in patch 2. Patch 3 implements MEMBLOCK_DEBUG. Thanks, Rebecca > > Ira > > > > > VERBOSE > > Usage: > > > > $ make VERBOSE=1 > > > > Passing VERBOSE=1 will enable verbose output from Memblock simulator. For > > each test, the verbose output includes the name of the memblock function > > being tested, the name of the test, and whether the test passed or failed. > > Since all the tests in Memblock simulator run as one monolithic test, this > > output is a quick way to get a summary of test results. > > > > MEMBLOCK_DEBUG > > Usage: > > > > $ make MEMBLOCK_DEBUG=1 > > > > Passing MEMBLOCK_DEBUG=1 will enable memblock_dbg() messages. These > > are debug messages built into several functions in memblock that include > > information such as the name of the function and the size and start and > > end addresses of the memblock region. > > > > Rebecca Mckeever (4): > > memblock tests: add user-provided arguments to Makefile > > memblock tests: add verbose output to memblock tests > > memblock tests: set memblock_debug to enable memblock_dbg() messages > > memblock tests: remove completed TODO items > > > > tools/testing/memblock/Makefile | 4 + > > tools/testing/memblock/README | 10 +- > > tools/testing/memblock/TODO | 14 +- > > tools/testing/memblock/internal.h | 7 + > > .../testing/memblock/scripts/Makefile.include | 10 + > > tools/testing/memblock/tests/alloc_api.c | 241 ++++++++---- > > .../memblock/tests/alloc_helpers_api.c | 135 +++++-- > > tools/testing/memblock/tests/alloc_nid_api.c | 371 ++++++++++++------ > > tools/testing/memblock/tests/basic_api.c | 365 ++++++++++++----- > > tools/testing/memblock/tests/common.c | 58 +++ > > tools/testing/memblock/tests/common.h | 54 +++ > > 11 files changed, 913 insertions(+), 356 deletions(-) > > > > --- > > Changes > > > > v1 -> v2 > > PATCH 2, in common.c: > > Remove #ifdef VERBOSE around prefixes and related constants > > Add __maybe_unused to prefixes > > Move PREFIXES_LEN_MAX, DELIM, and DELIM_LEN so that they are > > immediately after the other constants > > Add #ifdef VERBOSE around definitions for test_*() and prefix_*() > > > > v2 -> v3 > > PATCH 1: > > Add Reviewed-by tag > > --- > > > > -- > > 2.34.1 > > > >