From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F605C433EF for ; Thu, 23 Jun 2022 03:48:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19ABD8E011C; Wed, 22 Jun 2022 23:48:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14BA98E0115; Wed, 22 Jun 2022 23:48:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03B378E011C; Wed, 22 Jun 2022 23:48:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E24BD8E0115 for ; Wed, 22 Jun 2022 23:48:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B1226355BB for ; Thu, 23 Jun 2022 03:48:03 +0000 (UTC) X-FDA: 79608117246.07.E11DD3B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 36A8E1A001B for ; Thu, 23 Jun 2022 03:48:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4BB0161D93; Thu, 23 Jun 2022 03:48:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5122DC3411B; Thu, 23 Jun 2022 03:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655956081; bh=Wp4Jyu7Evu+xPN4gK+sTGNzC8Vqe46xBT6i45WSKSaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Uv7/hRpz7LO+UHEy7KiMB1C3GNb3nXMx4+TY+EGpuKptgxA+XN2NtjJRfsdHoJni6 Fi2wriVnTP2XOnUW+cumELFPRzJh6l+pwxH/W0zAm1tFTaW4GojzNoxKP4veQrwbBZ QSnPadCr6kYObITPuVp42vgkVHcvEP2ssCw/JBDdOrUzdizoSmi/IhinEueqYTEb7k rTEaakIfjT9+yMMuI9lo9x4dUY/Ju6GOozjRve08CHSHH0gTtKTl3FmViGmbgVLnrB cUHmAPzZAr0KxPQp2U4tmbBPQBApcQRhqJj+4LK5hXPSNSP+i+zjZdeeHlGPVNUS2n 2pic+YiLEwieA== Date: Wed, 22 Jun 2022 22:47:55 -0500 From: Mike Rapoport To: Rebecca Mckeever Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v3 1/4] memblock tests: add user-provided arguments to Makefile Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655956083; a=rsa-sha256; cv=none; b=TIV5pKbPQH/x9KrhZJ/UgvohDM/d6IBKrHxaDrnT57i3zDliVAcgQuJ3VkvqafKkQRvdaU +cHtkQEcTGehnSI466/pCR0v+ZsitwwR7ypDQtZvzpIn9ntLMcbMKQ4FH7RXhZr9HX0Ovk sbEgzsSddBiwo9fjXX79N9lM9qlB6Oc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Uv7/hRpz"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655956083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yqPsGFeTOtFP4edAAyrKwf2TG0mIU9k1zBNRId1o/+4=; b=woVg9hCptxd+G/s3wWx7f93skYnMhI5rPpxUS+vQHidls/F1XowjPPAIji1If8FCrZDKOX iizLQuc3C8LyZODA+ZiU+/+u6nddcYdgjhUPGVH42A/IkEy0R+Ss5rKJ8XycVyr9Ohw4NZ vhDuzzE7umqf5X2BwcgKr/ceaikysMM= X-Rspamd-Queue-Id: 36A8E1A001B X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Uv7/hRpz"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspamd-Server: rspam03 X-Stat-Signature: bc8egcrbjk4jzdddsmfoypachdp4pa1b X-HE-Tag: 1655956083-575657 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Rebecca, On Wed, Jun 22, 2022 at 04:29:06AM -0500, Rebecca Mckeever wrote: > > Subject: memblock tests: add user-provided arguments to Makefile Please be more specific here, e.g. memblock tests: Makefile: add arguments to control verbosity > Add VERBOSE and MEMBLOCK_DEBUG user-provided arguments. VERBOSE will > enable verbose output from Memblock simulator. MEMBLOCK_DEBUG will enable > memblock_dbg() messages. > > Update the help message to include VERBOSE and MEMBLOCK_DEBUG. Update > the README to include VERBOSE. The README does not include all available > options and refers to the help message for the remaining options. > Therefore, omit MEMBLOCK_DEBUG from README. > > Reviewed-by: David Hildenbrand > Signed-off-by: Rebecca Mckeever > --- > tools/testing/memblock/Makefile | 4 ++++ > tools/testing/memblock/README | 10 +++++++++- > tools/testing/memblock/scripts/Makefile.include | 10 ++++++++++ > 3 files changed, 23 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/memblock/Makefile b/tools/testing/memblock/Makefile > index a698e24b35e7..9fde49ad73bd 100644 > --- a/tools/testing/memblock/Makefile > +++ b/tools/testing/memblock/Makefile > @@ -45,6 +45,10 @@ help: > @echo ' clean - Remove generated files and symlinks in the directory' > @echo '' > @echo 'Configuration:' > + @echo ' make VERBOSE=1 - enable verbose output, which includes the' > + @echo ' names of functions being tested and the' > + @echo ' number of test cases passing' > + @echo ' make MEMBLOCK_DEBUG=1 - enable memblock_dbg() messages' > @echo ' make NUMA=1 - simulate enabled NUMA' > @echo ' make MOVABLE_NODE=1 - override `movable_node_is_enabled`' > @echo ' definition to simulate movable NUMA nodes' > diff --git a/tools/testing/memblock/README b/tools/testing/memblock/README > index ca6afcff013a..058146b528a5 100644 > --- a/tools/testing/memblock/README > +++ b/tools/testing/memblock/README > @@ -34,7 +34,15 @@ To run the tests, build the main target and run it: > $ make && ./main > > A successful run produces no output. It is also possible to override different > -configuration parameters. For example, to simulate enabled NUMA, use: > +configuration parameters. For example, to include verbose output, specify the > +VERBOSE flag when building the main target: > + > +$ make VERBOSE=1 > + > +This will print information about which functions are being tested and the > +number of test cases that passed. > + > +To simulate enabled NUMA, use: > > $ make NUMA=1 > > diff --git a/tools/testing/memblock/scripts/Makefile.include b/tools/testing/memblock/scripts/Makefile.include > index 641569ccb7b0..4401f79bed4c 100644 > --- a/tools/testing/memblock/scripts/Makefile.include > +++ b/tools/testing/memblock/scripts/Makefile.include > @@ -17,3 +17,13 @@ ifeq ($(32BIT_PHYS_ADDR_T), 1) > CFLAGS += -m32 -U CONFIG_PHYS_ADDR_T_64BIT > LDFLAGS += -m32 > endif > + > +# Enable verbose testing output > +ifeq ($(VERBOSE), 1) > + CFLAGS += -D VERBOSE > +endif > + > +# Enable memblock_dbg() messages > +ifeq ($(MEMBLOCK_DEBUG), 1) > + CFLAGS += -D MEMBLOCK_DEBUG > +endif > -- > 2.34.1 > -- Sincerely yours, Mike.