From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3BCC43334 for ; Thu, 23 Jun 2022 01:01:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA2BE8E0106; Wed, 22 Jun 2022 21:01:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E52978E00FA; Wed, 22 Jun 2022 21:01:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF3428E0106; Wed, 22 Jun 2022 21:01:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BA6AD8E00FA for ; Wed, 22 Jun 2022 21:01:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9053AA5E for ; Thu, 23 Jun 2022 01:01:03 +0000 (UTC) X-FDA: 79607696406.29.021667E Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf05.hostedemail.com (Postfix) with ESMTP id 43D04100015 for ; Thu, 23 Jun 2022 01:01:03 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id e131so3302166oif.13 for ; Wed, 22 Jun 2022 18:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HTsgBhm/o/POE84ZagYPea5g/wEfGrvEaZuql2akX8Q=; b=luP7QRCN4pK4yP/6BHzyWgQq/q4WvC6dyd0mnfav2FGYwz+rP7eP4AWFo0Uu+4sWgb LV4eh/ZWV4BbQH13zvuB7WX32sVMV5Cxf6dlLF2nXvckIhcpY2th3UTk7DsIvfOJFgKj zgrwsCYKHnGtjU6AqeqQckBvtjmhL+hOmWXx1wx75jfcHMs3HWdwPsQwJUGrKSUqt4Y+ zX8RIBjRuklvwQ4/EriIaRYZNHwmBsUGURUa6Z/bFvH5yHDYZi9MfNnPJSENNj8RgMrK qD9KFnGimxI3itmMVdnNK79gPXAX3f1CfXDRlkvPDBLkzf5whk4xxO1DRhbP+azH73bh 12Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HTsgBhm/o/POE84ZagYPea5g/wEfGrvEaZuql2akX8Q=; b=kJpXq2o1SYoGdAdfd9N5rYMxsUe0LRA7a14TUWh4JHe+Kf7z9DolU5A42TIb70H6uI RF5RDdN7ExZS55nUynmliGACki7jxx5qeH3H94iLasSYYvo6HFvjN71H/62ToeDcVvLW G7LFmKNEkG4qVTSHq51ijiEeSe3dtQFYVGdNHXV9nbMq/WYDsJVTBUBFxPmKgfZcG2UF E6vnlaC9jicdKD3wIZ1f5ZSL8fKny5+c6OAhSfMToRqTi7Ga7tkiAQSVrKaXD2Z5fmTz hIOmTMnHhIQhoOdXtJ2eESaiSRx6WA9nh4fl0/lonTR+7HOQZeajOVxJ6cocOUhER3zW PF9w== X-Gm-Message-State: AJIora9+g+Ckm4Q8EtT0dmvMYEssLlx1g8BLz8eTiINNCAH56lZa1NVt c3udXWGzJAW/Uo+mHqD3L3KQVu7R3ZM= X-Google-Smtp-Source: AGRyM1uqtsOJo9g9sNTQT300yh2v/9ie7zO7e7yXYQl/mrsXXvBIwJuOiVWLoO9+PqfcFqGj1ADnew== X-Received: by 2002:a05:6808:1387:b0:333:4c4:ef81 with SMTP id c7-20020a056808138700b0033304c4ef81mr725105oiw.46.1655946062527; Wed, 22 Jun 2022 18:01:02 -0700 (PDT) Received: from bertie (072-190-140-117.res.spectrum.com. [72.190.140.117]) by smtp.gmail.com with ESMTPSA id s204-20020aca45d5000000b0032f662af5d5sm12041579oia.1.2022.06.22.18.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 18:01:02 -0700 (PDT) Date: Wed, 22 Jun 2022 20:01:00 -0500 From: Rebecca Mckeever To: Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v3 0/4] memblock tests: add VERBOSE and MEMBLOCK_DEBUG Makefile options Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655946063; a=rsa-sha256; cv=none; b=2E6ZHu301UHjSo+YsUMqi/ti5LaFD3wrk3acU6RcyJUMNCHkUa3kyX4WB8l0IrGzvDRPY2 o9wOOlF4FTO7LFscQDYcVc+nYeB4FZTKyE6Oqs82L6p61cqoPD3W/BUZLt3Oe8CdkG0yz4 QfO+kGhadnRbA6vxXSBjxZbao4l4SZw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=luP7QRCN; spf=pass (imf05.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.196 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655946063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HTsgBhm/o/POE84ZagYPea5g/wEfGrvEaZuql2akX8Q=; b=wDeBUuuosHhEZt6vICbg6lnVoH2F2X3+JaL0NoccE5W4pbfVvg/tHW00bl0p2v2xhHOsZP 62elhtxmA0bv7i0PFOe9zO+8Hx3u7/AztWbv4FB0bY5jXRqvdKDm4jEpAJS4tvPNqnKhap A3W8QEgtZB2GmsVDvp7fMgXe+Vwat2c= Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=luP7QRCN; spf=pass (imf05.hostedemail.com: domain of remckee0@gmail.com designates 209.85.167.196 as permitted sender) smtp.mailfrom=remckee0@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 43D04100015 X-Stat-Signature: 4rhaajfms5rpze6dg5djx8j8hn851woq X-Rspam-User: X-HE-Tag: 1655946063-510016 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On Wed, Jun 22, 2022 at 09:17:24AM -0500, Mike Rapoport wrote: > Hi Rebecca, > > On Wed, Jun 22, 2022 at 04:29:05AM -0500, Rebecca Mckeever wrote: > > These patches add options VERBOSE and MEMBLOCK_DEBUG to Memblock > > simulator, which can be specified when running make. These patches also > > implement the functionality for these options. > > > > VERBOSE > > Usage: > > > > $ make VERBOSE=1 > > > > Passing VERBOSE=1 will enable verbose output from Memblock simulator. For > > each test, the verbose output includes the name of the memblock function > > being tested, the name of the test, and whether the test passed or failed. > > Since all the tests in Memblock simulator run as one monolithic test, this > > output is a quick way to get a summary of test results. > > > > MEMBLOCK_DEBUG > > Usage: > > > > $ make MEMBLOCK_DEBUG=1 > > > > Passing MEMBLOCK_DEBUG=1 will enable memblock_dbg() messages. These > > are debug messages built into several functions in memblock that include > > information such as the name of the function and the size and start and > > end addresses of the memblock region. > > > > Rebecca Mckeever (4): > > memblock tests: add user-provided arguments to Makefile > > memblock tests: add verbose output to memblock tests > > memblock tests: set memblock_debug to enable memblock_dbg() messages > > memblock tests: remove completed TODO items > > > > tools/testing/memblock/Makefile | 4 + > > tools/testing/memblock/README | 10 +- > > tools/testing/memblock/TODO | 14 +- > > tools/testing/memblock/internal.h | 7 + > > .../testing/memblock/scripts/Makefile.include | 10 + > > tools/testing/memblock/tests/alloc_api.c | 241 ++++++++---- > > .../memblock/tests/alloc_helpers_api.c | 135 +++++-- > > tools/testing/memblock/tests/alloc_nid_api.c | 371 ++++++++++++------ > > tools/testing/memblock/tests/basic_api.c | 365 ++++++++++++----- > > tools/testing/memblock/tests/common.c | 58 +++ > > tools/testing/memblock/tests/common.h | 54 +++ > > 11 files changed, 913 insertions(+), 356 deletions(-) > > > > --- > > Changes > > > > v1 -> v2 > > PATCH 2, in common.c: > > Remove #ifdef VERBOSE around prefixes and related constants > > Add __maybe_unused to prefixes > > Move PREFIXES_LEN_MAX, DELIM, and DELIM_LEN so that they are > > immediately after the other constants > > Add #ifdef VERBOSE around definitions for test_*() and prefix_*() > > > > v2 -> v3 > > PATCH 1: > > Add Reviewed-by tag > > --- > > The patch changelog in a cover letter usually goes before the commit list > and diffstat. > Thanks for letting me know, I will do that next time. > > -- > > 2.34.1 > > > > -- > Sincerely yours, > Mike. Thanks, Rebecca