From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADDC0CCA480 for ; Thu, 23 Jun 2022 00:29:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34C938E0102; Wed, 22 Jun 2022 20:29:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FCAA8E00FA; Wed, 22 Jun 2022 20:29:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EBFD8E0102; Wed, 22 Jun 2022 20:29:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0CEDE8E00FA for ; Wed, 22 Jun 2022 20:29:56 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D690F34AA9 for ; Thu, 23 Jun 2022 00:29:55 +0000 (UTC) X-FDA: 79607617950.13.1328ADD Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf09.hostedemail.com (Postfix) with ESMTP id 31DA6140026 for ; Thu, 23 Jun 2022 00:29:55 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DFB27B8216E; Thu, 23 Jun 2022 00:29:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FDC5C34114; Thu, 23 Jun 2022 00:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655944192; bh=aAoFgHtWas++I53ocsvZ6Q17Zzsw1Rs+N4ahYVrgBOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a8sEpVbYfYOXuyt0gsYxvuJoq7iiX7/sksHGJ38xs+6WfBhE86MzVoKM7PFB/Ip0q OvvD66ubSx5e+JUYg9sUzWZUhnifs/KufGdnHmRnxPQqCFRS+DQea5ngdHULEsc7yP WsV2p1GZipw5yMsgOE9Xm9oDpIFySdw+yDWMVr83W6kHvhP8IDdlb+yNNOeTms5/wy Fcae6Ej2WgdZq8I3VA3YMREVMcpLlSHXN6u0pETkTl6Pur2vQOADfqER8M7uowT0dj sJgnEQFTc+D5AexJ8nnHvxhDYPIZI+e7tlfWgJ+F5prD9DvpYoEvHg/Ng41tZ/0grP U0iigj3pFrygg== Date: Wed, 22 Jun 2022 17:29:52 -0700 From: "Darrick J. Wong" To: Jens Axboe Cc: linux-mm@kvack.org, kernel-team@fb.com, linux-xfs@vger.kernel.org, io-uring@vger.kernel.org, shr@fb.com, linux-fsdevel@vger.kernel.org, david@fromorbit.com, hch@infradead.org, jack@suse.cz, willy@infradead.org Subject: Re: [PATCH v9 00/14] io-uring/xfs: support async buffered writes Message-ID: References: <20220616212221.2024518-1-shr@fb.com> <165593682792.161026.12974983413174964699.b4-ty@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <165593682792.161026.12974983413174964699.b4-ty@kernel.dk> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655944195; a=rsa-sha256; cv=none; b=L6FfLuPXGUSemKOqt82OQBjTzi7eAzetQPJ+VzydNqQLQZIc0Zzn4bF0kt6AmMchgHB5we GE/0iv6Cdh9a2QaTE1+bU766WR8E6E0tojQT9Y7uIIE9Q+r7iQQhrr8f/UQcGXhN/XvGCA /RgAy96yfaoQPp9SNmmO0yZnAQbDrUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655944195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P5Cq6paABGvHRqNBjwYAtJFBf0u9rDkltEKHKf7RzzA=; b=O51M07bWFDwrwvZEhv/AwzdyBd7UrEjTC2fi6fb29QEeGsinIMVUnFxRtlAvEQdHe7k9Sy U3oeiBvSSi/GZoyqqgL2PccCdjWBMkIOzVPx6b7pLOXEv22SF7a2DQGT7PywQDYDShwJtt AVhAVSJQ/snLvUkqbRxlcREFxMiR6ww= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a8sEpVbY; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org X-Rspam-User: X-Rspamd-Queue-Id: 31DA6140026 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=a8sEpVbY; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org X-Stat-Signature: kiqs1zmkz1m8p6skwmoh766nf9hbrc17 X-Rspamd-Server: rspam09 X-HE-Tag: 1655944195-773789 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 22, 2022 at 04:27:07PM -0600, Jens Axboe wrote: > On Thu, 16 Jun 2022 14:22:07 -0700, Stefan Roesch wrote: > > This patch series adds support for async buffered writes when using both > > xfs and io-uring. Currently io-uring only supports buffered writes in the > > slow path, by processing them in the io workers. With this patch series it is > > now possible to support buffered writes in the fast path. To be able to use > > the fast path the required pages must be in the page cache, the required locks > > in xfs can be granted immediately and no additional blocks need to be read > > form disk. > > > > [...] > > Applied, thanks! > > [01/14] mm: Move starting of background writeback into the main balancing loop > commit: 29c36351d61fd08a2ed50a8028a7f752401dc88a > [02/14] mm: Move updates of dirty_exceeded into one place > commit: a3fa4409eec3c094ad632ac1029094e061daf152 > [03/14] mm: Add balance_dirty_pages_ratelimited_flags() function > commit: 407619d2cef3b4d74565999a255a17cf5d559fa4 > [04/14] iomap: Add flags parameter to iomap_page_create() > commit: 49b5cd0830c1e9aa0f9a3717ac11a74ef23b9d4e > [05/14] iomap: Add async buffered write support > commit: ccb885b4392143cea1bdbd8a0f35f0e6d909b114 > [06/14] iomap: Return -EAGAIN from iomap_write_iter() > commit: f0f9828d64393ea2ce87bd97f033051c8d7a337f I'm not sure /what/ happened here, but I never received the full V9 series, and neither did lore: https://lore.kernel.org/linux-fsdevel/165593682792.161026.12974983413174964699.b4-ty@kernel.dk/T/#t As it is, I already have my hands full trying to figure out why generic/522 reports file corruption after 20 minutes of running on vanilla 5.19-rc3, so I don't think I'm going to get to this for a while either. The v8 series looked all right to me, but ********* I hate how our development process relies on such unreliable **** tooling. I don't think it's a /great/ idea to be pushing new code into -next when both the xfs and pagecache maintainers are too busy to read the whole thing through... but did hch actually RVB the whole thing prior to v9? --D > [07/14] fs: Add check for async buffered writes to generic_write_checks > commit: cba06e23bc664ef419d389f1ed4cee523f468f8f > [08/14] fs: add __remove_file_privs() with flags parameter > commit: 79d8ac83d6305fd8e996f720f955191e0d8c63b9 > [09/14] fs: Split off inode_needs_update_time and __file_update_time > commit: 1899b196859bac61ad71c3b3916e06de4b65246c > [10/14] fs: Add async write file modification handling. > commit: 4705f225a56f216a59e09f7c2df16daabb7b4f76 > [11/14] io_uring: Add support for async buffered writes > commit: 6c8bbd82a43a0c7937e3e8e38cf46fcd90e15e68 > [12/14] io_uring: Add tracepoint for short writes > commit: 6c33dae4526ad079af6432aaf76827d0a27a9690 > [13/14] xfs: Specify lockmode when calling xfs_ilock_for_iomap() > commit: ddda2d473df70607bb456c515d984d05bf689790 > [14/14] xfs: Add async buffered write support > commit: e9cfc64a27f7a581b8c5d14da4efccfeae9c63bd > > Best regards, > -- > Jens Axboe > >