From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608E0C433EF for ; Wed, 22 Jun 2022 14:17:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E00B98E00B6; Wed, 22 Jun 2022 10:17:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB0A08E00AB; Wed, 22 Jun 2022 10:17:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9F128E00B6; Wed, 22 Jun 2022 10:17:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BF5668E00AB for ; Wed, 22 Jun 2022 10:17:56 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 85EF13476A for ; Wed, 22 Jun 2022 14:17:56 +0000 (UTC) X-FDA: 79606075752.21.BF771D1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id 0144F14002E for ; Wed, 22 Jun 2022 14:17:50 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 60A79B81F5B; Wed, 22 Jun 2022 14:17:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E50FC34114; Wed, 22 Jun 2022 14:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655907451; bh=zRN8pMikC873iNt1UJIlldjE9fXl+iAWKj+fmNVfc4E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BL1Gxil96ejsriMZjrrBOYuKst8H/GStZG+U7S+PB9tgm1raxZ3FEJZF6NQWqs0lP FZHE2HSITFEisrke+GN2B4gwihEPE6H5pX2MRQqNLGVzPkHJyLvfJilvUZBpjlpYMk MYmSLdEyAFvq1w/9O6PuwLQ54Im1bxHmwMi0TIFPYNxcqCOTeZRTx6RdF3aNJwDllc uW/ypMZ29kksalATXvIhNnWHibxCPy0UKxZY4OZzymQzWBiI+Z0zDXAIkV1gXcJxfp +gnwU/e9Gl8L52aeHYKSGp2/TSKR2lhg4a8jibYV5PUoXICCGfCuQg+zKfT3XMAXhv GlyrJA3lu7dug== Date: Wed, 22 Jun 2022 09:17:24 -0500 From: Mike Rapoport To: Rebecca Mckeever Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v3 0/4] memblock tests: add VERBOSE and MEMBLOCK_DEBUG Makefile options Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=kernel.org header.s=k20201202 header.b=BL1Gxil9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655907476; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O5LtE+RxhKUAeSs+RBmmD3QbSXn1vLPFnF1cfqwpxo0=; b=ELepiFuhGAZYE0Iq2DTm1tYcEph1O0SpfjJ+WJzhdvAVPa2ywkaqa2nBWDOkVvcL/0rf1A 2NNsrRbmujy3v35ZOQR4j7cIu/kMjNTiAe3uP+QzwxFWvNRaEgYY5/vlN33p1Jg15wvVVb VegPJA546caGHBgW+CorvpzHD+rE7kA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655907476; a=rsa-sha256; cv=none; b=UXKWTgcEF+4WVTAW6ekygEzJXpaG4K7BTVKRounn90ysgaBq02Z8o7XUr1LIl4bj7irLal UdewJtqrDlGnVp5FNmq5hClgQCBOqQ/VmsEwiVRraA7IR34fT4v00uzKP4qlEq8DQc2y3A 5TmRCkStPepb4WDth8fEYdmMlwj4iQs= X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0144F14002E X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=kernel.org header.s=k20201202 header.b=BL1Gxil9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Stat-Signature: 5oufn3nzr9dbrs3e8i9rpdn6rrp9dpk6 X-HE-Tag: 1655907470-963716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Rebecca, On Wed, Jun 22, 2022 at 04:29:05AM -0500, Rebecca Mckeever wrote: > These patches add options VERBOSE and MEMBLOCK_DEBUG to Memblock > simulator, which can be specified when running make. These patches also > implement the functionality for these options. > > VERBOSE > Usage: > > $ make VERBOSE=1 > > Passing VERBOSE=1 will enable verbose output from Memblock simulator. For > each test, the verbose output includes the name of the memblock function > being tested, the name of the test, and whether the test passed or failed. > Since all the tests in Memblock simulator run as one monolithic test, this > output is a quick way to get a summary of test results. > > MEMBLOCK_DEBUG > Usage: > > $ make MEMBLOCK_DEBUG=1 > > Passing MEMBLOCK_DEBUG=1 will enable memblock_dbg() messages. These > are debug messages built into several functions in memblock that include > information such as the name of the function and the size and start and > end addresses of the memblock region. > > Rebecca Mckeever (4): > memblock tests: add user-provided arguments to Makefile > memblock tests: add verbose output to memblock tests > memblock tests: set memblock_debug to enable memblock_dbg() messages > memblock tests: remove completed TODO items > > tools/testing/memblock/Makefile | 4 + > tools/testing/memblock/README | 10 +- > tools/testing/memblock/TODO | 14 +- > tools/testing/memblock/internal.h | 7 + > .../testing/memblock/scripts/Makefile.include | 10 + > tools/testing/memblock/tests/alloc_api.c | 241 ++++++++---- > .../memblock/tests/alloc_helpers_api.c | 135 +++++-- > tools/testing/memblock/tests/alloc_nid_api.c | 371 ++++++++++++------ > tools/testing/memblock/tests/basic_api.c | 365 ++++++++++++----- > tools/testing/memblock/tests/common.c | 58 +++ > tools/testing/memblock/tests/common.h | 54 +++ > 11 files changed, 913 insertions(+), 356 deletions(-) > > --- > Changes > > v1 -> v2 > PATCH 2, in common.c: > Remove #ifdef VERBOSE around prefixes and related constants > Add __maybe_unused to prefixes > Move PREFIXES_LEN_MAX, DELIM, and DELIM_LEN so that they are > immediately after the other constants > Add #ifdef VERBOSE around definitions for test_*() and prefix_*() > > v2 -> v3 > PATCH 1: > Add Reviewed-by tag > --- The patch changelog in a cover letter usually goes before the commit list and diffstat. > -- > 2.34.1 > -- Sincerely yours, Mike.