From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B5F7C43334 for ; Wed, 22 Jun 2022 08:54:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFA728E009D; Wed, 22 Jun 2022 04:54:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAAD38E008A; Wed, 22 Jun 2022 04:54:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C73D88E009D; Wed, 22 Jun 2022 04:54:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B49E88E008A for ; Wed, 22 Jun 2022 04:54:58 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 8C706807EC for ; Wed, 22 Jun 2022 08:54:58 +0000 (UTC) X-FDA: 79605261876.13.835FD21 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf04.hostedemail.com (Postfix) with ESMTP id E4A91400A4 for ; Wed, 22 Jun 2022 08:54:50 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id z14so15558687pgh.0 for ; Wed, 22 Jun 2022 01:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NPz6aysJ4lKE5JHLkll4+SwUhp9oiQCtyExa/aZASL4=; b=t8+Nm/Nm3fXHIky43hvB+9u58dnsstVeJtDa1cLpnYXi3KWOTWJz9oC0BVaeFQB+ge mtdYrumXWF5Lr6HmweRlNPE1tDXUKb+tj8tT2BeJoyl4uKUK6fc3JCnCZTD7C87gqKTx GO+0JsZnSnzpyuc+rLCfG1Ek4tUtEWC62rGye6AGP3UvKsyajg8FS7uHZqMc7W90I8ZM hWfWwo1gp9RlFLdW2W3ApzWN9o2kHzFIczO6MzuT8b04PIDl4n9BL6eu7MACppiaA8xk AKZ1UPPELrH8bHYsgRZPJzT8EdtqN5RQ7L7rDPhyq/L2lhtB/eksIqnXQHMKKreH2W2Q jXcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NPz6aysJ4lKE5JHLkll4+SwUhp9oiQCtyExa/aZASL4=; b=Lea/fnT6+HOeGRrrhYPpIoGPJfpgyRTPSvkUM4Hr5CWzlBb6UCr5kiE61oMZmr2mcd tjA/oFQH+LVKRHgIjO2rRZDkCQhmBrQLMeYXI8dB6XAGB5nlJjflOT0JWNUPdH9W4SFp o8H3XlilSVyjyrBBjPoL/fVGNaXYeeSZ+kee80oS6EO8paTSv/3HenqspNelJWJgtnd+ NWZJVSMSpE9bBlJt9dqT+SvGK/w/EBta48WX13KNxFz6AIBfTx1dO4Bui/ql2qwKm9s0 hHwPXfrHl9eH4U1jIj476SKn1WKdStObye3kVX6iOz+OzkcvzxS59+UHWPA4Q4auRkLW 8SDg== X-Gm-Message-State: AJIora9iX1khBQikx0e6DwT+0RBWSMSsvd0xrBD4DPNQdgbpAsXI4q56 +EJcm3AnCgiTZzcD+1CIK8r7DQ== X-Google-Smtp-Source: AGRyM1uo0P4pX8SHoZRe2EUDrLwxiOIPYCP6UvpzcVZkKBOhowttVZ9N680TUQINuxLGzg8z8AUNDA== X-Received: by 2002:a05:6a00:1a09:b0:525:a0d:d1d3 with SMTP id g9-20020a056a001a0900b005250a0dd1d3mr21848009pfv.27.1655888089663; Wed, 22 Jun 2022 01:54:49 -0700 (PDT) Received: from localhost ([139.177.225.231]) by smtp.gmail.com with ESMTPSA id f11-20020a170902684b00b00163f3e91ea0sm1641513pln.238.2022.06.22.01.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jun 2022 01:54:49 -0700 (PDT) Date: Wed, 22 Jun 2022 16:54:46 +0800 From: Muchun Song To: David Hildenbrand Cc: Oscar Salvador , Andrew Morton , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/page_alloc: Do not calculate node's total pages and memmap pages when empty Message-ID: References: <20220621041717.6355-1-osalvador@suse.de> <20220621041717.6355-2-osalvador@suse.de> <506203e3-1de0-1187-5234-7afc66d4ddfe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="t8+Nm/Nm"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf04.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655888098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NPz6aysJ4lKE5JHLkll4+SwUhp9oiQCtyExa/aZASL4=; b=sUhL1LPbBDB66WLjMRc+h0MEBvSL582ihDQJUv7pXUf0gT3NHzpO09LAUpDNhHJXZydYtw 6kgpeyhp64CQ/sVWpgdc1dFV92Tv5SW9Bdx1LdhtoaAI+NGviovJg22Nsnhd8Zy05EaUuC VpFzlquECFq1TiYcgt0uFSMhn4pcWoo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655888098; a=rsa-sha256; cv=none; b=26c/vpU+AfvZmafuOKX/lN5ugNbpFYpMjI/bVMYZf7ImeVNkQqMwz9hkmRR8JRELvqFc3b Y1tNtWBsDGEa0/NxubH5hT8QepuTZ2PWhmNLQjW3XcUvir886d5mWzEnGo1dy9p+VBjdPw IAO82kB8SoPYeg2eHJlbqpcwfF7Y7PE= X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E4A91400A4 X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b="t8+Nm/Nm"; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf04.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: 76nujsmk5d95t7tqaqhy46miisrikff8 X-HE-Tag: 1655888090-47774 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 22, 2022 at 10:31:12AM +0200, David Hildenbrand wrote: > On 22.06.22 05:56, Muchun Song wrote: > > On Wed, Jun 22, 2022 at 05:47:22AM +0200, Oscar Salvador wrote: > >> On Tue, Jun 21, 2022 at 09:44:47AM +0200, David Hildenbrand wrote: > >>> > >>> > >>> It's worth noting that the check in pgdat_is_empty() is slightly > >>> different. I *think* it doesn't matter in practice, yet I wonder if we > >>> should simply fixup (currently unused) pgdat_is_empty(). > >> > >> I guess we could change it to > >> > >> static inline bool pgdat_is_empty(pg_data_t *pgdat) > >> { > >> return node_start_pfn(pgdat->node_id) == node_end_pfn(pgdat->node_id) > >> } > >> > >> ? And maybe even rename it to to node_is_empty (not sure why but I tend to like > > > > At least I like this name (node_is_empty) as well. > > > > Let's try keeping it consistent. I think node_is_empty() might indicate > that we're punching in a node id instead of a pgdat. > I suspect Oscar will change the argument to "nid" as well, like: static inline bool node_is_empty(int nid) { return node_start_pfn(nid) == node_end_pfn(nid); } Does this look good? Thanks. > > -- > Thanks, > > David / dhildenb > >