From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F7F8C43334 for ; Wed, 22 Jun 2022 03:56:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26A3A8E007C; Tue, 21 Jun 2022 23:56:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 219198E006E; Tue, 21 Jun 2022 23:56:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E0F58E007C; Tue, 21 Jun 2022 23:56:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F23ED8E006E for ; Tue, 21 Jun 2022 23:56:42 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id CFF3061114 for ; Wed, 22 Jun 2022 03:56:42 +0000 (UTC) X-FDA: 79604510244.14.7F69DDA Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf22.hostedemail.com (Postfix) with ESMTP id 45DF5C001B for ; Wed, 22 Jun 2022 03:56:38 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id m14so14275663plg.5 for ; Tue, 21 Jun 2022 20:56:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7h4tU4Rx3U/aIsjIhPJPJ//Klp0wPGPWFG+nXRn0z4k=; b=VoGA3tGfVl0A535ILyhPoL2KpOukdlOj3rNC5fsvPcm3///hr+HGF7a0rFpP8pHwug Ea21Uv2xLBA0CcShpV/WJBq2HirQkCEvE/jTFghhSG4buBAj+24nc7n/OwDZX77uQfIh UmJ5Cy+kXhjpC0hjjWlvjd7msMTEtfdXsH2c2GWRz7uplQ7NV6M6xfJgUPBh871m6CQ7 qvPhdMAMD1eTig2ShT/piDj3yfdwvo2OEGhdY5Nk5J5UUylEAhhVLZMyyfCX7ugB/Z6f fnzq4elp5dEXjZ49mx4oCcMiCEvwbDx3kJpD5Pq18mZFVOAZQ8waL2fpiOfXLbJ7Trmd ieBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7h4tU4Rx3U/aIsjIhPJPJ//Klp0wPGPWFG+nXRn0z4k=; b=BzkqILmtp5zKzwzmtVe6z4xuz/pGStDreynt4jW7q+wChSyllLGpdXZ28ynWfg7uVS 3y8Rc93XY70wszqUP5NzY9Xav6FJQYWOhYhHKgcvbSwFoPPCI8rck8Kh+sKE+w3B6V2W 35WuLax8lmqwT2YGOfP/oaSvP6mysMSZ9IDXPGyCWrR9uTWjkHg/RpVHzGRyRMxWmuHu B4W+hc+ymTSR8LeVQG8kc9a12ZppxdaGsKws9ZDPcj4H8BVqlGiYpIisoI4crM4ZCoSq IoI6m24FvCsvZ+6bb1DIOXMy2qRLKPTI5HS/KYU/GLNsEbBzSWDbxa4+owkAbpV2C6mW Pd9w== X-Gm-Message-State: AJIora/xduzWbDeUUjvv13y1f19j0L2ZH9crvtRB8J54sKUcr33JHyAA 9QpxX/WhS8Jdz0h8BRke8nUZ0w== X-Google-Smtp-Source: AGRyM1vomi7WtYi0MwLGcNqNMDkpdNI3UJkQxUuWSDdYYFFOq/OjMCfULai2r84xUu1AoWniSXrphg== X-Received: by 2002:a17:90a:eb05:b0:1ec:b85a:e1ac with SMTP id j5-20020a17090aeb0500b001ecb85ae1acmr1434571pjz.103.1655870188983; Tue, 21 Jun 2022 20:56:28 -0700 (PDT) Received: from localhost ([2404:9dc0:cd01::23]) by smtp.gmail.com with ESMTPSA id b9-20020a170902d88900b001663185e654sm11440301plz.280.2022.06.21.20.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 20:56:28 -0700 (PDT) Date: Wed, 22 Jun 2022 11:56:25 +0800 From: Muchun Song To: Oscar Salvador Cc: David Hildenbrand , Andrew Morton , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/page_alloc: Do not calculate node's total pages and memmap pages when empty Message-ID: References: <20220621041717.6355-1-osalvador@suse.de> <20220621041717.6355-2-osalvador@suse.de> <506203e3-1de0-1187-5234-7afc66d4ddfe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655870202; a=rsa-sha256; cv=none; b=c3Hypo+t2iavwAONCIswgK4yFJ5WfYQVo0To+CqrT6TmVo1idxQphc1B70GP94MO002ByC sM1v9U7irWUkbHeqov3DNcOXLcJhcw62tWqL1fHzXi5gUvwkFBIDdb/fTC/ShqF3Nacnj2 BIi2G3l9vGePuFg2Fwbn9cMwVvVQ/ys= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=VoGA3tGf; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf22.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655870202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7h4tU4Rx3U/aIsjIhPJPJ//Klp0wPGPWFG+nXRn0z4k=; b=Vt/4DsXSe+r9bW8VC2VEGYNKFMbovr9mZGaw3ETx1xSaZ2kxEjkBPn6AGV60ObRmmCM9su LqqEWw9uL1l6EtXkmk0nxyqCA/E4MZ05OffyJDMQtaoNoCB+my0YARSV4LQWBEKh73bmEr SBrruHKMpe56xi6qpwW20zuQ+QIpsm0= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 45DF5C001B Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=VoGA3tGf; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf22.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com X-Stat-Signature: e75sdwybprh18q9xfmp1yumj7bci71zk X-Rspam-User: X-HE-Tag: 1655870198-975926 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 22, 2022 at 05:47:22AM +0200, Oscar Salvador wrote: > On Tue, Jun 21, 2022 at 09:44:47AM +0200, David Hildenbrand wrote: > > > > > > It's worth noting that the check in pgdat_is_empty() is slightly > > different. I *think* it doesn't matter in practice, yet I wonder if we > > should simply fixup (currently unused) pgdat_is_empty(). > > I guess we could change it to > > static inline bool pgdat_is_empty(pg_data_t *pgdat) > { > return node_start_pfn(pgdat->node_id) == node_end_pfn(pgdat->node_id) > } > > ? And maybe even rename it to to node_is_empty (not sure why but I tend to like At least I like this name (node_is_empty) as well. Thanks. > that more than pgdat) > > I could squeeze a "fixup" patch for that before this one. > > > > > Anyhow > > > > Reviewed-by: David Hildenbrand > > Thanks! > > > -- > Oscar Salvador > SUSE Labs >