From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F420C43334 for ; Wed, 22 Jun 2022 03:47:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3F6A6B0080; Tue, 21 Jun 2022 23:47:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEF976B0081; Tue, 21 Jun 2022 23:47:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B62A8E006E; Tue, 21 Jun 2022 23:47:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8E6916B0080 for ; Tue, 21 Jun 2022 23:47:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5E345354CC for ; Wed, 22 Jun 2022 03:47:36 +0000 (UTC) X-FDA: 79604487312.04.3179902 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf17.hostedemail.com (Postfix) with ESMTP id E713140016 for ; Wed, 22 Jun 2022 03:47:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 51DDB1F985; Wed, 22 Jun 2022 03:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1655869644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cE0rQjAA42eU80dv5qRJXXM0yGtnKl5fWjJdWhwMZOs=; b=wyzwtDz8nUgOOSUThBQLx/THMAKUiRlAZDiQFl9VFGiUenMabY0x2WFp1dTCiOc59o0s52 8sUvx9LCwIZ5wu2+VwZIG7agReZu4oMZx+oRdk/McQ0NmCTBISGPHOnOf/uyFnIwcUHMQO AxlMCAAT56ew/JQprKMjXPo81/XUHTk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1655869644; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cE0rQjAA42eU80dv5qRJXXM0yGtnKl5fWjJdWhwMZOs=; b=26jW/p2hSSQdrcX8rpve2Sq/al99Jctb0vc9NvLsDVipsyzYA6iLcVOllw+6CLRXN4SO9f pnXWkcHl1Qu2yIBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC955134A9; Wed, 22 Jun 2022 03:47:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id M0jQNsuQsmJSEAAAMHmgww (envelope-from ); Wed, 22 Jun 2022 03:47:23 +0000 Date: Wed, 22 Jun 2022 05:47:22 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/page_alloc: Do not calculate node's total pages and memmap pages when empty Message-ID: References: <20220621041717.6355-1-osalvador@suse.de> <20220621041717.6355-2-osalvador@suse.de> <506203e3-1de0-1187-5234-7afc66d4ddfe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <506203e3-1de0-1187-5234-7afc66d4ddfe@redhat.com> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655869651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cE0rQjAA42eU80dv5qRJXXM0yGtnKl5fWjJdWhwMZOs=; b=Qg7e6kbkugRIsoD/qNRSLvwZfI/d/+yMjvI6z+ibf8djbcz4IaegDoZMgeQqhUr3H2oBzd kuYRwxRFuAY6CHWPD400m75zKL/DKDzhreEFvAAh4Cv6jOHhIUkCw1iVj7uiPijqc1X4Od 3wvUfqeWN+UGTZXdhYnd89H0qWBtujg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655869651; a=rsa-sha256; cv=none; b=Wr8u/0c+1gnq0/6xXNF5LDWBnTj1tHirAtGHwGuY9f3McWbFMSdHMrsysl75FIHR3VxDll nz57sVlPQdTBVhN2s+Jrvcn9MhZ++p7jLNtddwqQg03T4q7NPN+IlQ6UUlunzbaIagEp8I C2X0CoPxo8DnwZ/Sv+4A0/fcazE9fWM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wyzwtDz8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="26jW/p2h"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Stat-Signature: 9u99wexe41zq1yj4wxwq5cuf8zizyntz X-Rspamd-Queue-Id: E713140016 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wyzwtDz8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="26jW/p2h"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=osalvador@suse.de X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1655869649-212097 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 21, 2022 at 09:44:47AM +0200, David Hildenbrand wrote: > > > It's worth noting that the check in pgdat_is_empty() is slightly > different. I *think* it doesn't matter in practice, yet I wonder if we > should simply fixup (currently unused) pgdat_is_empty(). I guess we could change it to static inline bool pgdat_is_empty(pg_data_t *pgdat) { return node_start_pfn(pgdat->node_id) == node_end_pfn(pgdat->node_id) } ? And maybe even rename it to to node_is_empty (not sure why but I tend to like that more than pgdat) I could squeeze a "fixup" patch for that before this one. > > Anyhow > > Reviewed-by: David Hildenbrand Thanks! -- Oscar Salvador SUSE Labs