From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B276C43334 for ; Wed, 22 Jun 2022 03:09:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64DB68E0079; Tue, 21 Jun 2022 23:09:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FDFF8E006E; Tue, 21 Jun 2022 23:09:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EC758E0079; Tue, 21 Jun 2022 23:09:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4018C8E006E for ; Tue, 21 Jun 2022 23:09:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 0292A60BFA for ; Wed, 22 Jun 2022 03:09:29 +0000 (UTC) X-FDA: 79604391300.01.3D5AD45 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf16.hostedemail.com (Postfix) with ESMTP id F384F1800A0 for ; Wed, 22 Jun 2022 03:09:25 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id a14so5277318pgh.11 for ; Tue, 21 Jun 2022 20:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qeFLGzKyEitMeyLAF5p2SS4hTRAjoU69UDSP6vdWSjY=; b=p2wwgxhu9ut5UKfrtDC0rPYOS8CGYB4DZKXrTV8Z6vFZaGsCErBuey217nlClTv6sL F4xbgHt4MjpUrGsIfxCNeQqcdvLLcCo8zQRCZPoMa/FSPeUWBDmMVga+VitfhQKbIXKs RWirpynPoN/X+YpCHLmDmw67sKTa0bl3A0lzfyzEG2A/lyGOcWItAYsfTznkQRS6SQ/+ /8m20H/hLi2E1/xgjLH9iLLvl+XnO3MrlCz8jZtna9qWwcAWVOrl04NY+SUT/ceAJF8j XhTyy6Yr4uf1yihCeZwvc3UQv1ubTwxn9/GHyyMgo+h+0pPS4enGayVOVjCuAKzF8Vkn MNUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qeFLGzKyEitMeyLAF5p2SS4hTRAjoU69UDSP6vdWSjY=; b=a9rHF5ci/tEGDsVqf/gvlc8B9oGWsY3sKvZg59B3SiPU5kvMQLJAr5lkGXpXIKLrCO ZiJ9yHp/o7635690TGsWbZ4RBiNysYbdem2D/cBEGlb2S3IH2XdVxtSIlJj4ATDkg4X0 v4IQSvgAfb/EUWJfhL3469qjGcb8ZGTPElHe4TM+OMAwjIjQ9OViQHXEa55wBBnsTvFS RiWkEEyW0eKuyw1vFrudbqMgj+JuMxQX62dCTsS2Hq9M+BBiyveXS8/39EzSQJonmXes L3qdO1pf5qWBe9b64isbNp0Jjsdv08Gnx/ap5dyegky+t+PH910NhO/0/S8PmmOtj40X qvHQ== X-Gm-Message-State: AJIora+wkDkIgRbra6vueS9We8WeR00Q+C77VBy1BSucewkfNCq/wan1 nWdQzAE7MeUXvVMdfBec8UZzrQ== X-Google-Smtp-Source: AGRyM1v/MjNT/bnm9g6Ofg4xP2CNsIToPVWuYeLOj+RxjCRuiNQqo1YZVEhQtNsoecrOZLGUHppubw== X-Received: by 2002:a63:68c4:0:b0:3fb:984f:6779 with SMTP id d187-20020a6368c4000000b003fb984f6779mr1066855pgc.444.1655867361716; Tue, 21 Jun 2022 20:09:21 -0700 (PDT) Received: from localhost ([139.177.225.231]) by smtp.gmail.com with ESMTPSA id x16-20020a17090a165000b001e667f932cdsm13118167pje.53.2022.06.21.20.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 20:09:21 -0700 (PDT) Date: Wed, 22 Jun 2022 11:09:16 +0800 From: Muchun Song To: Baolin Wang Cc: sj@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon: Use set_huge_pte_at() to make huge pte old Message-ID: References: <1655692482-28797-1-git-send-email-baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1655692482-28797-1-git-send-email-baolin.wang@linux.alibaba.com> ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=p2wwgxhu; spf=pass (imf16.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655867369; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qeFLGzKyEitMeyLAF5p2SS4hTRAjoU69UDSP6vdWSjY=; b=3q2lVohf0Wm49BmzNhsvbJ7KEq1M0kd+i1j1Ma169oYoeOyoVSq2uLEuU52DThW3YF9KBT gHA56VuQX8gqkaKMG51DjLrnNvl8lF5XDc15WmkwArl1py1najJL2Uk2BTfnbkGXpjm7dX 1C6a/dayHMDGl9zVEn2/Q3x/bqiiLwc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655867369; a=rsa-sha256; cv=none; b=BVwoYIh5Ud00QQRcdJ1jthxOEk8vLcCfNFXuHpH3WQ8vuPaw8pYl99iSP4gehUVd1W2EIm w0dissieKjSGrbm071wz/lkm+yaXnK36xU9ocMOJxztIlouWBkgQQ7NjvdfjqOFQN9jg36 i8t8fomNa0P2ujGLrg66ygfRjymvKko= X-Stat-Signature: ax7mopdkqqy8spkoj3cocwwoz1qy3das X-Rspam-User: X-Rspamd-Server: rspam07 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=p2wwgxhu; spf=pass (imf16.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Queue-Id: F384F1800A0 X-HE-Tag: 1655867365-865817 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 20, 2022 at 10:34:42AM +0800, Baolin Wang wrote: > The huge_ptep_set_access_flags() can not make the huge pte old according > to the discussion [1], that means we will always mornitor the young state > of the hugetlb though we stopped accessing the hugetlb, as a result DAMON > will get inaccurate accessing statistics. > > So changing to use set_huge_pte_at() to make the huge pte old to fix this > issue. > > [1] https://lore.kernel.org/all/Yqy97gXI4Nqb7dYo@arm.com/ > > Fixes: 49f4203aae06 ("mm/damon: add access checking for hugetlb pages") > Signed-off-by: Baolin Wang The changes make sense to me. Reviewed-by: Muchun Song