From: Peter Xu <peterx@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Nadav Amit <nadav.amit@gmail.com>,
linux-mm@kvack.org, Nadav Amit <namit@vmware.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: [RFC PATCH v2 1/5] userfaultfd: introduce uffd_flags
Date: Tue, 21 Jun 2022 11:31:06 -0400 [thread overview]
Message-ID: <YrHkOpBIb0goccSS@xz-m1.local> (raw)
In-Reply-To: <f58a7012-3d7a-a1b1-6af0-df971287ec7c@redhat.com>
On Tue, Jun 21, 2022 at 10:41:19AM +0200, David Hildenbrand wrote:
> > @@ -1726,10 +1728,15 @@ static int userfaultfd_copy(struct userfaultfd_ctx *ctx,
> > goto out;
> > if (uffdio_copy.mode & ~(UFFDIO_COPY_MODE_DONTWAKE|UFFDIO_COPY_MODE_WP))
> > goto out;
> > +
> > + mode_wp = uffdio_copy.mode & UFFDIO_COPY_MODE_WP;
> > +
> > + uffd_flags = mode_wp ? UFFD_FLAGS_WP : 0;
>
> why not simply
>
> uffd_flags = 0;
> if (uffdio_copy.mode & UFFDIO_COPY_MODE_WP)
> uffd_flags |= UFFD_FLAGS_WP;
>
> ?
Seconded, or even one-line it?
uffd_flags = (uffdio_copy.mode & UFFDIO_COPY_MODE_WP) ? UFFD_FLAGS_WP : 0;
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2022-06-21 15:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 23:34 [RFC PATCH v2 0/5] userfaultfd: support access/write hints Nadav Amit
2022-06-19 23:34 ` [RFC PATCH v2 1/5] userfaultfd: introduce uffd_flags Nadav Amit
2022-06-21 8:41 ` David Hildenbrand
2022-06-21 15:31 ` Peter Xu [this message]
2022-06-21 15:29 ` Peter Xu
2022-06-21 17:41 ` Nadav Amit
2022-06-19 23:34 ` [RFC PATCH v2 2/5] userfaultfd: introduce access-likely mode for copy/wp operations Nadav Amit
2022-06-21 8:48 ` David Hildenbrand
2022-06-21 15:42 ` Peter Xu
2022-06-21 17:27 ` Nadav Amit
2022-06-19 23:34 ` [RFC PATCH v2 3/5] userfaultfd: introduce write-likely " Nadav Amit
2022-06-21 16:38 ` Peter Xu
2022-06-21 17:14 ` Nadav Amit
2022-06-21 18:10 ` Peter Xu
2022-06-21 18:30 ` Nadav Amit
2022-06-21 18:43 ` Peter Xu
2022-06-19 23:34 ` [RFC PATCH v2 4/5] userfaultfd: zero access/write hints Nadav Amit
2022-06-21 17:04 ` Peter Xu
2022-06-21 17:17 ` Nadav Amit
2022-06-21 17:56 ` Peter Xu
2022-06-21 17:58 ` Nadav Amit
2022-06-19 23:34 ` [RFC PATCH v2 5/5] selftest/userfaultfd: test read/write hints Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrHkOpBIb0goccSS@xz-m1.local \
--to=peterx@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=nadav.amit@gmail.com \
--cc=namit@vmware.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox