From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 065E8C43334 for ; Tue, 21 Jun 2022 15:29:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94EB76B0074; Tue, 21 Jun 2022 11:29:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F02A6B0073; Tue, 21 Jun 2022 11:29:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 791E36B0074; Tue, 21 Jun 2022 11:29:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6A6D26B0072 for ; Tue, 21 Jun 2022 11:29:06 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 407EA20553 for ; Tue, 21 Jun 2022 15:29:06 +0000 (UTC) X-FDA: 79602626292.31.D38018E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 33DD7200B6 for ; Tue, 21 Jun 2022 15:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655825344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ld5/p2spmdwZxQpoNl01rDCae2kS+nuSh0wDWsFUNtQ=; b=D05wOq7cOSC8z1yIzArANhB5kySy2iS9PEVl/3v+zuH5Bv1ENeUOn1H7Nw6l19XnHQplSz B20jxzHQ2GeqGcWGyvWLTufXJReLLq4Wj/SnCxaJyHO82ebNUqQNZ4gle6RqFPDOC87WHY Js5QDBNIO77KG6zLdza3Ba8hn9DLcfM= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-407-cZVZISTzNCSZY9DdHCm8mQ-1; Tue, 21 Jun 2022 11:29:03 -0400 X-MC-Unique: cZVZISTzNCSZY9DdHCm8mQ-1 Received: by mail-io1-f72.google.com with SMTP id n20-20020a6b7214000000b00669cae33d00so7776289ioc.17 for ; Tue, 21 Jun 2022 08:29:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ld5/p2spmdwZxQpoNl01rDCae2kS+nuSh0wDWsFUNtQ=; b=Y63OD9lyk+GFKJOgDEXzfOOZ/wDj19INQRRLPKUgIMcZmxNQRPfacIS7i4Wg3zbWur YxpOgHc+i1VJL0oJVATJQ4Z6tEJg/UDVUYraIbbgQLmpxjkGUb/W4JnAljM8rs/kM3VU +SOTEzYftNHITVAe2FtuFuH+uugCMqyWcd9ud4x+6L2K3f3NYEON9xckENnuk74ItmOw DXrFfHwtTAyKqgrDXb0+VT6IOwiIymNjEz+GV5CoSkc8mf4RmKpGN778jkBDHNsuUdSj mW7fA5oU+jrgSco2QltzQ0sngPWP9e8DlNUS4M46eJwZ2S023ft0C65hReb5ycOVivco NcCQ== X-Gm-Message-State: AJIora9zgHN6375kplkL+S4aQf+zlbXp0X5FvGrqAcZb+BXj4ynfo7eV 2Ifh7cMLNXsQcu6vYn4BpRPIcCAgF7fuaivJQ8rT/fAsOxxCfWCqzQrBxyuSwQQZ10UfKRnik2C lqEMncEHjdIg= X-Received: by 2002:a05:6638:2486:b0:331:f9b9:a8ef with SMTP id x6-20020a056638248600b00331f9b9a8efmr16206607jat.139.1655825342659; Tue, 21 Jun 2022 08:29:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1smFlk9xd8e9cW7ShbN6J0nyds7yFXHl03siUkLKmp1hs7KnsI502YXFyCvyRWdG4JGZIz80Q== X-Received: by 2002:a05:6638:2486:b0:331:f9b9:a8ef with SMTP id x6-20020a056638248600b00331f9b9a8efmr16206595jat.139.1655825342422; Tue, 21 Jun 2022 08:29:02 -0700 (PDT) Received: from xz-m1.local (cpec09435e3e0ee-cmc09435e3e0ec.cpe.net.cable.rogers.com. [99.241.198.116]) by smtp.gmail.com with ESMTPSA id f39-20020a022427000000b00331743a983asm7190172jaa.179.2022.06.21.08.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jun 2022 08:29:01 -0700 (PDT) Date: Tue, 21 Jun 2022 11:29:00 -0400 From: Peter Xu To: Nadav Amit Cc: linux-mm@kvack.org, Nadav Amit , Mike Kravetz , Hugh Dickins , Andrew Morton , Axel Rasmussen , David Hildenbrand , Mike Rapoport Subject: Re: [RFC PATCH v2 1/5] userfaultfd: introduce uffd_flags Message-ID: References: <20220619233449.181323-1-namit@vmware.com> <20220619233449.181323-2-namit@vmware.com> MIME-Version: 1.0 In-Reply-To: <20220619233449.181323-2-namit@vmware.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655825345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ld5/p2spmdwZxQpoNl01rDCae2kS+nuSh0wDWsFUNtQ=; b=He3Suta9ul69tgsamPfNqMRm9Ok+Uk1AbTn2ZAdNtp8vMUosknyS9oB2NiIrqBuzqO4sYo 42BXbDXrJYIWapCpGyQnlFEwmzykZu8pPLJAjQms8APEpB34IdETcxYkVAGNUNRPUFKdRD OmpM7zUfGcyFeDNdQWYL8MvOg+5a0TA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D05wOq7c; spf=none (imf13.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655825345; a=rsa-sha256; cv=none; b=dbWM8T9eDd5lH7Vs/x4igggUw7+KUeqWakAEyqdoJpjRi4/rNpPEtYpxgsVya6gc8OYa9w +XGQVWmETUT7mhH94NZ5FeKzLacwGLLTWZlKJ04MN04OdlXepNpbyHQna2pjf6aYZIFB/e Dm+1KluESl/V/YVH3juqxRQllJXCWeI= X-Stat-Signature: ewg39cmzk8m6bj3j4sr7y6gf5r4x39hu X-Rspamd-Queue-Id: 33DD7200B6 X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=D05wOq7c; spf=none (imf13.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1655825344-53673 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 19, 2022 at 04:34:45PM -0700, Nadav Amit wrote: > @@ -683,30 +681,33 @@ static __always_inline ssize_t __mcopy_atomic(struct mm_struct *dst_mm, > > ssize_t mcopy_atomic(struct mm_struct *dst_mm, unsigned long dst_start, > unsigned long src_start, unsigned long len, > - atomic_t *mmap_changing, __u64 mode) > + atomic_t *mmap_changing, uffd_flags_t uffd_flags) > { > return __mcopy_atomic(dst_mm, dst_start, src_start, len, > - MCOPY_ATOMIC_NORMAL, mmap_changing, mode); > + MCOPY_ATOMIC_NORMAL, mmap_changing, uffd_flags); > } > > ssize_t mfill_zeropage(struct mm_struct *dst_mm, unsigned long start, > - unsigned long len, atomic_t *mmap_changing) > + unsigned long len, atomic_t *mmap_changing, > + uffd_flags_t uffd_flags) Should this be fed into the last parameter of __mcopy_atomic() below? > { > return __mcopy_atomic(dst_mm, start, 0, len, MCOPY_ATOMIC_ZEROPAGE, > mmap_changing, 0); > } > > ssize_t mcopy_continue(struct mm_struct *dst_mm, unsigned long start, > - unsigned long len, atomic_t *mmap_changing) > + unsigned long len, atomic_t *mmap_changing, > + uffd_flags_t uffd_flags) Same question here.. > { > return __mcopy_atomic(dst_mm, start, 0, len, MCOPY_ATOMIC_CONTINUE, > mmap_changing, 0); > } -- Peter Xu