From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7E3C433EF for ; Mon, 20 Jun 2022 16:57:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60BDC6B0071; Mon, 20 Jun 2022 12:57:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BBC08E0001; Mon, 20 Jun 2022 12:57:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AB1B6B0074; Mon, 20 Jun 2022 12:57:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3AD976B0071 for ; Mon, 20 Jun 2022 12:57:25 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 158F9208F9 for ; Mon, 20 Jun 2022 16:57:25 +0000 (UTC) X-FDA: 79599220050.01.7225B1C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 9A294A0010 for ; Mon, 20 Jun 2022 16:57:24 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD751614EF; Mon, 20 Jun 2022 16:57:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28337C3411B; Mon, 20 Jun 2022 16:57:20 +0000 (UTC) Date: Mon, 20 Jun 2022 17:57:17 +0100 From: Catalin Marinas To: Muchun Song Cc: mike.kravetz@oracle.com, david@redhat.com, akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Will Deacon , Anshuman Khandual Subject: Re: [PATCH 1/6] mm: hugetlb_vmemmap: delete hugetlb_optimize_vmemmap_enabled() Message-ID: References: <20220613063512.17540-1-songmuchun@bytedance.com> <20220613063512.17540-2-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220613063512.17540-2-songmuchun@bytedance.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655744244; a=rsa-sha256; cv=none; b=kK7LY6XLN314Hh2+kPC659KvMWqMfrh2Lf6dAchkBfnDtjV1uRpUYkIPHeTCFMqGqHIN+u evqlRbpS2gIHwmFU7N86SoWY1RVouvolzw93t6QrbQQHrXN5Pp9x4uGBMZtrkkf9912oU7 bgpZYBBwuT1TCdOe7rrAJofqVVb6mS8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655744244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EcgwD++hL/WPcHI5Z7WrMorXO3+Voyemu9/E6lv92DM=; b=I+Q7Nq8LEHZ71QV2ZVUKaSsGxj2/PqCWp/RilAPosBlM0NHkgqJzByqmcYfNA2N4KVMBiH 7GhQtDWhWLzZgsMq2D2PoGkjTKIKcLyBeyduv88kN637qi3KS6kv64UJiFiNZd1syMmGhI lv2X0oUSM3czrceJ3UYu+QWUbvtnuVM= X-Rspamd-Server: rspam01 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Stat-Signature: qpakok57pnk6t4daztcuui1pawtnknbz X-Rspamd-Queue-Id: 9A294A0010 X-HE-Tag: 1655744244-680242 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 13, 2022 at 02:35:07PM +0800, Muchun Song wrote: > The name hugetlb_optimize_vmemmap_enabled() a bit confusing as it tests > two conditions (enabled and pages in use). Instead of coming up to > an appropriate name, we could just delete it. There is already a > discussion about deleting it in thread [1]. > > There is only one user of hugetlb_optimize_vmemmap_enabled() outside of > hugetlb_vmemmap, that is flush_dcache_page() in arch/arm64/mm/flush.c. > However, it does not need to call hugetlb_optimize_vmemmap_enabled() > in flush_dcache_page() since HugeTLB pages are always fully mapped and > only head page will be set PG_dcache_clean meaning only head page's flag > may need to be cleared (see commit cf5a501d985b). So it is easy to > remove hugetlb_optimize_vmemmap_enabled(). > > Link: https://lore.kernel.org/all/c77c61c8-8a5a-87e8-db89-d04d8aaab4cc@oracle.com/ [1] > Signed-off-by: Muchun Song > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Anshuman Khandual Reviewed-by: Catalin Marinas