From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5FE1C43334 for ; Mon, 20 Jun 2022 10:18:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79B218E0001; Mon, 20 Jun 2022 06:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74B666B0073; Mon, 20 Jun 2022 06:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6143D8E0001; Mon, 20 Jun 2022 06:18:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 514D86B0071 for ; Mon, 20 Jun 2022 06:18:21 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1B33E60DAE for ; Mon, 20 Jun 2022 10:18:21 +0000 (UTC) X-FDA: 79598214402.14.4B4C40A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id B546780003 for ; Mon, 20 Jun 2022 10:18:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0772460EAD; Mon, 20 Jun 2022 10:18:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AFD5C3411B; Mon, 20 Jun 2022 10:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655720299; bh=xbUYrGZ4lJgGxgsFFzQXmYD9L6O/YoMdaDnokqi6Zkk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z8wTss+dR6BlX5Bx6Lc0LjllOqloq24Qf+DvdPAWza0do0JFMFoUZNupVcURaje8r uNxgMKIv9x8egrb9aBqPOR2fyyeL5DNB3cghyANk5D2o0M4exLBtYa0RDapsGUzW6q HPjcNwvSc0PHN++tcuAOkWsXY/knHbX1da9hpYcg= Date: Mon, 20 Jun 2022 12:17:56 +0200 From: Greg KH To: Xianting Tian Cc: akpm@linux-foundation.org, ziy@nvidia.com, stable@vger.kernel.org, guoren@kernel.org, huanyi.xj@alibaba-inc.com, guohanjun@huawei.com, zjb194813@alibaba-inc.com, tianhu.hh@alibaba-inc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5.15] mm: validate buddy page before using Message-ID: References: <20220616161746.3565225-1-xianting.tian@linux.alibaba.com> <20220616161746.3565225-6-xianting.tian@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616161746.3565225-6-xianting.tian@linux.alibaba.com> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655720300; a=rsa-sha256; cv=none; b=byTxVsd92UoBa9oco5V3z3UCvXsiXiqeBt9edDVd4mBPnR6xhqvXBvQ06GGBnb/hN5dwqn miKTyZc2xmXoxzFoQzy6B8dRJL+1N2Eyo4Oh1esgTFPZq/Tj1Hl/8CahsRz1Y1sNtrTtto ehmdlFSaegUKyOt9muzwDgaDEKqPutc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655720300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rNNBhTsDzzWyQX9/N+dn0UaIyMQ/DTqmDmFzZPiKFvo=; b=j5biudjVbnZCCFDT39UytpHCquVoM30Muan2g19x+tnMjh3uZfDhAccs2k4NlYaynX5r5C I1qmNZEazzo0IpnGRTFjGSOWnqhDOJ8WQboAlN69CWr2YnuOu0jlygxosagcwTw7UX5pVg g59OYKEZ4R4rQ8/pa4/bQgZQBZMKDOQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Z8wTss+d; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf30.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=Z8wTss+d; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf30.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B546780003 X-Stat-Signature: dbp4ezz3c3bdh1amem9pbk1g7kasxx3w X-HE-Tag: 1655720300-886228 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 17, 2022 at 12:17:45AM +0800, Xianting Tian wrote: > Commit 787af64d05cd ("mm: page_alloc: validate buddy before check its migratetype.") > fixes a bug in 1dd214b8f21c and there is a similar bug in d9dddbf55667 that > can be fixed in a similar way too. > > In unset_migratetype_isolate(), we also need the fix, so move page_is_buddy() > from mm/page_alloc.c to mm/internal.h > > In addition, for RISC-V arch the first 2MB RAM could be reserved for opensbi, > so it would have pfn_base=512 and mem_map began with 512th PFN when > CONFIG_FLATMEM=y. > But __find_buddy_pfn algorithm thinks the start pfn 0, it could get 0 pfn or > less than the pfn_base value. We need page_is_buddy() to verify the buddy to > prevent accessing an invalid buddy. > > Fixes: d9dddbf55667 ("mm/page_alloc: prevent merging between isolated and other pageblocks") > Cc: stable@vger.kernel.org > Reported-by: zjb194813@alibaba-inc.com > Reported-by: tianhu.hh@alibaba-inc.com > Signed-off-by: Xianting Tian > --- > mm/internal.h | 34 ++++++++++++++++++++++++++++++++++ > mm/page_alloc.c | 37 +++---------------------------------- > mm/page_isolation.c | 3 ++- > 3 files changed, 39 insertions(+), 35 deletions(-) What is the commit id of this in Linus's tree? thanks, greg k-h