From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592B6C43334 for ; Mon, 20 Jun 2022 09:54:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4D606B0071; Mon, 20 Jun 2022 05:54:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFCBD6B0073; Mon, 20 Jun 2022 05:54:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC4088E0001; Mon, 20 Jun 2022 05:54:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 976686B0071 for ; Mon, 20 Jun 2022 05:54:33 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 68CA532A79 for ; Mon, 20 Jun 2022 09:54:33 +0000 (UTC) X-FDA: 79598154426.18.8D3397C Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf19.hostedemail.com (Postfix) with ESMTP id 0A05B1A0009 for ; Mon, 20 Jun 2022 09:54:28 +0000 (UTC) Received: by mail-wr1-f48.google.com with SMTP id m1so6126356wrb.2 for ; Mon, 20 Jun 2022 02:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/5XQWxUT78CJ9q4IKK57xGusAoxHrjt7w5b5bQek9HA=; b=HeTIwbsdqxTlA6dnJyf7K/MPvYGDs+ekgNBGuf/QI/nMpkPVYE/lzCyvyLrzqiUlIi YGN8SG5jr5aCTedEE5DrZ0AQ9cStZmCYIs5+FDtef0xGw57/QYpSn7teIYN7Bsxz6kco ZgFFHAlBfzUHox6+rXb20NTfCJ6d8c/en1GKc4GhrlsERxjMsYLYV5dUYlfCYmiqGbkl LvMrADI2Y1du47q5PLoR7vEUvV131eHlDe3CgaeK6u+xz6THfV3bHIZZzc1xZfpjew3w Vsho5v7hLodwpKyGgoMt7eQnmR/3tJH8RuTXyHcTlUNAjELbiPEQN14td7jsvPX4aruE 202w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/5XQWxUT78CJ9q4IKK57xGusAoxHrjt7w5b5bQek9HA=; b=Ns2xcUStAr7HCa2QNijvfP4BrZSYZ3VdbI3kYMxhcxwAOSL0+XEP2gfw8tLqAwdcQL n4BLGizqywGZlC+a9IbZShWxrP1s7MwlDDAzbQLFottvZPkk010Fb3+7zfLjR0olTLS/ Z2x9xhjjCjiEJf0HmpbFzX21cKXODIU8CmNNKtMu8riRATaBtRLfR5keoBeAUZ3UuhZK wQh/oThGeSYKXelz/7xZpt9pUl3gFnHYbXxJxu85H7it6C2dn4Ms+X52zmvQReNtBgz/ fOgzoG6X0BgfbpVF8OG40dq0vt1TeD9hfdO7BXy+OnNcSIkPXxkUX+afWkeyyEuc7VyF A9qw== X-Gm-Message-State: AJIora8HmOJfbh7l3hnn4N334JHn8SzbJfSbe7XgETptNEpNnt2RtYcM bovf3x2fp6+9NGFk2H3vcRtfcg== X-Google-Smtp-Source: AGRyM1syJP7htSzs0rJB262nXQ0Y+FJd1OOBP4w+WYMDOyC5HF6+bK1dXdRGh0DPmaMD+cqj9jFKzQ== X-Received: by 2002:a5d:47a7:0:b0:218:5a5d:6c55 with SMTP id 7-20020a5d47a7000000b002185a5d6c55mr22074873wrb.192.1655718867517; Mon, 20 Jun 2022 02:54:27 -0700 (PDT) Received: from elver.google.com ([2a00:79e0:9c:201:3746:a989:7595:e29f]) by smtp.gmail.com with ESMTPSA id z6-20020a5d4d06000000b0021a3dd1c5d5sm10312787wrt.96.2022.06.20.02.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 02:54:26 -0700 (PDT) Date: Mon, 20 Jun 2022 11:54:20 +0200 From: Marco Elver To: andrey.konovalov@linux.dev Cc: Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 19/32] kasan: pass tagged pointers to kasan_save_alloc/free_info Message-ID: References: <9363b16202fb04a3223de714e70b7a6b72c4367e.1655150842.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9363b16202fb04a3223de714e70b7a6b72c4367e.1655150842.git.andreyknvl@google.com> User-Agent: Mutt/2.2.3 (2022-04-12) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655718869; a=rsa-sha256; cv=none; b=0PGIu7K54OylvADOA6HsenqURnd5RQv+bwYi9bhrA3PkukkQDdPeJBAh3wjItjI0FxCPao l+UKTmf5PMs5KOGIpw/hRIkSD9LjdObV86/bDGjdZXSCTYU3TTCygS7NgxsfdSdxI1Go18 Q/rDAQXmpn3/WxehczRJA0cFfrgwCgI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=HeTIwbsd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655718869; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/5XQWxUT78CJ9q4IKK57xGusAoxHrjt7w5b5bQek9HA=; b=iwnrejRc8yKFcyvOXYH1wrc7NX9AI1OCQ0h4p2CZHL86LTC9zq4P9IZOP1HOZdaFFK6efO EBDDWzgq2Px8oBytCegv8e6FJe7oLHcuCsz8k4WzE4OvQoNGfopw42+uyi42XHVTQPoYf0 rDguqB2kDlwRnEZrNtQFibODw2t8blA= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=HeTIwbsd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=elver@google.com X-Rspam-User: X-Stat-Signature: b1aood813w8rycxjxob3k6a74gauq6r7 X-Rspamd-Queue-Id: 0A05B1A0009 X-Rspamd-Server: rspam08 X-HE-Tag: 1655718868-230815 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 13, 2022 at 10:14PM +0200, andrey.konovalov@linux.dev wrote: > From: Andrey Konovalov > > Pass tagged pointers to kasan_save_alloc/free_info(). > > This is a preparatory patch to simplify other changes in the series. > > Signed-off-by: Andrey Konovalov > --- > mm/kasan/common.c | 4 ++-- > mm/kasan/generic.c | 3 +-- > mm/kasan/kasan.h | 2 +- > mm/kasan/tags.c | 3 +-- > 4 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index f937b6c9e86a..519fd0b3040b 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -227,7 +227,7 @@ static inline bool ____kasan_slab_free(struct kmem_cache *cache, void *object, > return false; > > if (kasan_stack_collection_enabled()) > - kasan_save_free_info(cache, object, tag); > + kasan_save_free_info(cache, tagged_object); > Variable 'tag' becomes unused in this function after this patch. > return kasan_quarantine_put(cache, object); > } > @@ -316,7 +316,7 @@ void * __must_check __kasan_slab_alloc(struct kmem_cache *cache, > > /* Save alloc info (if possible) for non-kmalloc() allocations. */ > if (kasan_stack_collection_enabled() && !cache->kasan_info.is_kmalloc) > - kasan_save_alloc_info(cache, (void *)object, flags); > + kasan_save_alloc_info(cache, tagged_object, flags); > > return tagged_object; > } > diff --git a/mm/kasan/generic.c b/mm/kasan/generic.c > index f6bef347de87..aff39af3c532 100644 > --- a/mm/kasan/generic.c > +++ b/mm/kasan/generic.c > @@ -500,8 +500,7 @@ void kasan_save_alloc_info(struct kmem_cache *cache, void *object, gfp_t flags) > kasan_set_track(&alloc_meta->alloc_track, flags); > } > > -void kasan_save_free_info(struct kmem_cache *cache, > - void *object, u8 tag) > +void kasan_save_free_info(struct kmem_cache *cache, void *object) > { > struct kasan_free_meta *free_meta; > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 30ec9ebf52c3..e8329935fbfb 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -308,7 +308,7 @@ static inline void kasan_init_object_meta(struct kmem_cache *cache, const void * > depot_stack_handle_t kasan_save_stack(gfp_t flags, bool can_alloc); > void kasan_set_track(struct kasan_track *track, gfp_t flags); > void kasan_save_alloc_info(struct kmem_cache *cache, void *object, gfp_t flags); > -void kasan_save_free_info(struct kmem_cache *cache, void *object, u8 tag); > +void kasan_save_free_info(struct kmem_cache *cache, void *object); > struct kasan_track *kasan_get_alloc_track(struct kmem_cache *cache, > void *object); > struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > diff --git a/mm/kasan/tags.c b/mm/kasan/tags.c > index 4f24669085e9..fd11d10a4ffc 100644 > --- a/mm/kasan/tags.c > +++ b/mm/kasan/tags.c > @@ -21,8 +21,7 @@ void kasan_save_alloc_info(struct kmem_cache *cache, void *object, gfp_t flags) > { > } > > -void kasan_save_free_info(struct kmem_cache *cache, > - void *object, u8 tag) > +void kasan_save_free_info(struct kmem_cache *cache, void *object) > { > } > > -- > 2.25.1 > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/9363b16202fb04a3223de714e70b7a6b72c4367e.1655150842.git.andreyknvl%40google.com.