From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77ECDC433EF for ; Mon, 20 Jun 2022 06:25:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03D358E0001; Mon, 20 Jun 2022 02:25:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2EEB6B0073; Mon, 20 Jun 2022 02:25:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1D9F8E0001; Mon, 20 Jun 2022 02:25:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D05896B0071 for ; Mon, 20 Jun 2022 02:25:35 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id A010460958 for ; Mon, 20 Jun 2022 06:25:35 +0000 (UTC) X-FDA: 79597627830.19.D96C130 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP id 38BD61C00AF for ; Mon, 20 Jun 2022 06:25:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DJcka4nk6nI6gmKXL/SKNBMqMDesGUybf1AX+sEYsjs=; b=czWVtFhBdwHslSccdEtX+EqsHY BXT/X5x7kJpFdgto+fK9tEQfUu4HVTAXm8Gt12gxH1Pf2XlVLiu1EjdhDWxijK19WxYHdJ0pLx8i9 C5O2YVzJ0zwBdc1AK/m+1SbgtLbVnJ3i5ehRCaN7yMUebRIcdtP8meJdpBUmm9ONSj3i2Gp/dFv8q 8E35uZZlppmIKENk0zhDUvfCSNo+kHHm5QClMqcJYE+oUqEXSBpEWyAxNQcHYvavmswdMTwMlQRz1 QVfB8hiY4pPnINNNwWdst66h92fysQCq3tBja2zJvgzEM54ieOlr6II3VoZ5jvZHm7LzMenhpoTEs TDspvUog==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3Aqp-00GQxm-22; Mon, 20 Jun 2022 06:25:31 +0000 Date: Sun, 19 Jun 2022 23:25:31 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Yu Kuai , Kent Overstreet Subject: Re: [PATCH 1/3] filemap: Correct the conditions for marking a folio as accessed Message-ID: References: <20220619151143.1054746-1-willy@infradead.org> <20220619151143.1054746-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220619151143.1054746-2-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=czWVtFhB; dmarc=none; spf=none (imf21.hostedemail.com: domain of BATV+e4e1516b09a747b462e2+6875+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e4e1516b09a747b462e2+6875+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655706334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DJcka4nk6nI6gmKXL/SKNBMqMDesGUybf1AX+sEYsjs=; b=KX9tXs8MJKAmRj+rcu4hzabYylTdZ6kGnGrOet3/aLSxOwTbqlex6lLV5lCNLM0Cfdxv7W 2I0D+NbfA4V/SpAQoyOo+808r90qPEfiMtXpuUCnCQqfUmtnFSx5p87FOSauBlgUhKOgML LnIrXoW5EWOV6u+LNxRkkwIiMWCo3vg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655706334; a=rsa-sha256; cv=none; b=OR4/AFn/PgvU1RIsew6kqH8y13NsE1fo5/qZMMr4v4NGNVLTrEZk6W2nARClrCfIovYzh+ exWFAW4vkwKURXUXe2oYOa62Sz9XnD+gVjjn/CdT97IagkUZdJKcgSrN8+Wdo8sbB821z5 PuI6a5AcRhCq4+i/95TXpR5UdCcRVQI= X-Stat-Signature: tnak8u7dmcxqbynhyf3cugtunfzgskwa X-Rspamd-Queue-Id: 38BD61C00AF X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=czWVtFhB; dmarc=none; spf=none (imf21.hostedemail.com: domain of BATV+e4e1516b09a747b462e2+6875+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+e4e1516b09a747b462e2+6875+infradead.org+hch@bombadil.srs.infradead.org X-Rspamd-Server: rspam10 X-HE-Tag: 1655706334-860796 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 19, 2022 at 04:11:41PM +0100, Matthew Wilcox (Oracle) wrote: > +static inline bool pos_same_folio(loff_t pos1, loff_t pos2, struct folio *folio) > > +{ > + unsigned int shift = folio_shift(folio); > + > + return (pos1 >> shift == pos2 >> shift); > +} The calling convention with the folio as the last argument seems a bit odd to me. But then again so does passing just one folio for checking if something is in the same folio. But as I can't come up with something better I'll just deposit these mumblings here insted of actually complaining.